From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: Cherrypicking commit e08de2bae2a8e91c0245259dfcbfdca1d191a119 onto emacs-26 Date: Thu, 15 Mar 2018 19:37:57 +0000 Message-ID: References: <83zi39p38o.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="089e0829c8fc97b30b056778a1cf" X-Trace: blaine.gmane.org 1521142580 4759 195.159.176.226 (15 Mar 2018 19:36:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 15 Mar 2018 19:36:20 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 15 20:36:16 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewYfg-00019i-5Z for ged-emacs-devel@m.gmane.org; Thu, 15 Mar 2018 20:36:16 +0100 Original-Received: from localhost ([::1]:53106 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewYhj-0002qB-AX for ged-emacs-devel@m.gmane.org; Thu, 15 Mar 2018 15:38:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59053) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewYhZ-0002pq-35 for emacs-devel@gnu.org; Thu, 15 Mar 2018 15:38:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ewYhX-00080c-TD for emacs-devel@gnu.org; Thu, 15 Mar 2018 15:38:13 -0400 Original-Received: from mail-lf0-x22c.google.com ([2a00:1450:4010:c07::22c]:35623) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ewYhW-0007zM-9f; Thu, 15 Mar 2018 15:38:10 -0400 Original-Received: by mail-lf0-x22c.google.com with SMTP id t132-v6so11941690lfe.2; Thu, 15 Mar 2018 12:38:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=h7DGpakUsXp4NvLIzthwVp7QkUKGng9Z2gsndOuQnPc=; b=tTgJ1PNrpH844PhbCA0TpfGAllWPtCjvE8qu8krJbCl4Ew2n3p76ucb+ni6GysY6eH lZm8eyvNL+KsXjy4sIM2WoEauB2zGZGISh+KMxn+gKcFGIF1O17AxFIV5n3m71KiYd6H TXJTnJwDo0NjsQJwRcV/6ASGa4uDnVLX+20bZSkt1nhH0eqaWjVaLo56FFk2Ek+abpq/ vPOWuwe5VhI6rXS2KIm+1KKI6/642K4VinDxpRyZV7jgU2TMYpfIThLjit9uFb4BcXgb aqSYOzIfwwt3ElJ6aYbG9oCumVU+MYFfAXYzQyBtD2elGOmCZIwPEeTSZ2iRqZ7w+1fD ouqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=h7DGpakUsXp4NvLIzthwVp7QkUKGng9Z2gsndOuQnPc=; b=cUAWKbnrSa3aYConql3qY11TU3zIKHeFbI3MMiL8jQk1lxd/BIQelxnEyNjjlwkdPi 8ga0GDJfsGFuCXrefk7vmjNmEh4JE3zwEkxzuyEKeWVipr+rIXSA3Ro83k/qlmZJTqjY 5ayPULiFddmkJK16yUOAs6Jhdt8SLms5NoRkLzEsUuTEsPfpXq5sBmMh+x8UrbbEaw2A ormzr4MJYL5gtrZOPABbAdECoGhSoeQHbAjk60M1d2vEIxfSOSBHGJylxbFrWLFg67lk qg8mOVd+iWA9MC6/OhkAgZUmfCSOxRh19wInNwchdSwfyy0wuExbVTBXkQydMF6rPzVv oQfA== X-Gm-Message-State: AElRT7GIwQxOIJnAaxB9F+7fmJM4+Hph3O3FO0c1/35xSCaZliCgii9+ nGHChdxMxI9xubU3nq67so333soIA+Fz1TnB0x1KPg== X-Google-Smtp-Source: AG47ELtOP+qEvE3VkzWLLr4QzZdHDFIJJGsbpswded9gkcWCxueetuWD75uMIqDnQ84FBuhuC50raBz9sJu28MwidKs= X-Received: by 10.46.129.88 with SMTP id t24mr6881844ljg.60.1521142688361; Thu, 15 Mar 2018 12:38:08 -0700 (PDT) In-Reply-To: <83zi39p38o.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::22c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:223761 Archived-At: --089e0829c8fc97b30b056778a1cf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Eli Zaretskii schrieb am Do., 15. M=C3=A4rz 2018 um 20:07 Uh= r: > > From: Philipp Stephani > > Date: Thu, 15 Mar 2018 18:34:27 +0000 > > > > would it be OK to cherrypick commit > e08de2bae2a8e91c0245259dfcbfdca1d191a119 onto the release > > branch? It fixes a bug that makes filenotify watches essentially > unusable with quoted filenames, and is very > > short and localized. > > How can anything related to quoted file name be urgent to fix? > Quoted filenames are a core Emacs function that is prominently documented, see e.g. https://www.gnu.org/software/emacs/manual/html_node/emacs/Quoted-File-Names= .html. They are also the only reliable method for external scripts and libraries to ensure that Emacs doesn't mangle a local filename in unpredictable ways. Therefore it's very important that quoted filenames are bugfree. Perhaps even more importantly, that commit fixes a regression: emacs -Q -batch -l filenotify --eval=3D"(file-notify-rm-watch (file-notify-add-watch \"/:/tmp/\" '(change) 'ignore))" works in master and Emacs 25.2, but not with the release branch. --089e0829c8fc97b30b056778a1cf Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Eli Za= retskii <eliz@gnu.org> schrieb am= Do., 15. M=C3=A4rz 2018 um 20:07=C2=A0Uhr:
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Thu, 15 Mar 2018 18:34:27 +0000
>
> would it be OK to cherrypick commit e08de2bae2a8e91c0245259dfcbfdca1d1= 91a119 onto the release
> branch? It fixes a bug that makes filenotify watches essentially unusa= ble with quoted filenames, and is very
> short and localized.

How can anything related to quoted file name be urgent to fix?

Quoted filenames are a core Emacs function that is = prominently documented, see e.g.=C2=A0https://www.gnu.org= /software/emacs/manual/html_node/emacs/Quoted-File-Names.html. They are= also the only reliable method for external scripts and libraries to ensure= that Emacs doesn't mangle a local filename in unpredictable ways. Ther= efore it's very important that quoted filenames are bugfree.
= Perhaps even more importantly, that commit fixes a regression:
em= acs -Q -batch -l filenotify --eval=3D"(file-notify-rm-watch (file-noti= fy-add-watch \"/:/tmp/\" '(change) 'ignore))"
works in master and Emacs 25.2, but not with the release branch.
--089e0829c8fc97b30b056778a1cf--