From: Philipp Stephani <p.stephani2@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: phst@google.com, emacs-devel@gnu.org
Subject: Re: [PATCH] Improve error reporting when serializing non-Unicode strings to JSON
Date: Sat, 23 Dec 2017 15:19:17 +0000 [thread overview]
Message-ID: <CAArVCkT1tNki8D2V-gdwm8ixjRxYN6QNOPo36bv5-aFOAm+OKg@mail.gmail.com> (raw)
In-Reply-To: <83shc1jy3j.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 2608 bytes --]
Eli Zaretskii <eliz@gnu.org> schrieb am Sa., 23. Dez. 2017 um 15:52 Uhr:
> > From: Philipp Stephani <p.stephani2@gmail.com>
> > Date: Sat, 23 Dec 2017 14:29:56 +0000
> > Cc: emacs-devel@gnu.org, phst@google.com
> >
> > OK, but why do we need external functions for doing that? What is
> > missing in our own code to detect such a situation?
> >
> > Not much I think, it's just easiest to use Gnulib functions because they
> are well-documented, have a clean
> > interface, and are probably bug-free.
> > coding.c has check_utf_8, which is quite similar, but has an
> incompatible interface (it takes struct
> > coding_system objects) and also checks for embedded newlines, which
> isn't necessary here.
>
> So let's use check_utf_8, as its downsides don't sound serious to me,
>
Well it needs to be rewritten significantly to take a char*, length
argument instead of the coding_system struct.
> and OTOH using unistring functions will bloat Emacs
u8-check.c is just 77 LoC (including all boilerplate, comments, and empty
lines), so I don't think it blows up Emacs in any significant way.
> for the benefit of
> a single use case, not to mention create two different methods for
> doing the same job, which IMO is even more confusing to any newcomer
> to the Emacs internals.
>
Agreed it's somewhat confusing, but I think not too much. The two functions
have quite different use cases: check_utf_8 is a specialized function that
requires a coding system with significant set-up and is only used once (in
decode_coding_gap), while u8_check is a general-purpose function.
Having not much experience with coding.c, I find the functions in that file
much more confusing and harder to understand than the ones from
libunistring. The libunistring functions tend to have a single, clear
purpose, while the coding.c functions often do many different things at
once.
>
> Btw, doesn't find_charsets_in_text do the same job cleaner and
> quicker? AFAIU, all you need is make sure there are no characters
> from the 2 eight-bit-* charsets in the text, or did I miss something?
>
What I need to check is one of the following:
- Is the initial string either a well-formed UTF-8 unibyte string, or a
multibyte string that represents a Unicode scalar value sequence?
- Is the encoded string a well-formed UTF-8 unibyte string?
Given my understanding of the implementation of coding.c, these two
criteria should be equivalent. (Unfortunately that doesn't seem to be
documented.) So I choose to implement the second check, which is easier and
allows delaying the check until we know we have to signal an error.
[-- Attachment #2: Type: text/html, Size: 3655 bytes --]
next prev parent reply other threads:[~2017-12-23 15:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 21:00 [PATCH] Improve error reporting when serializing non-Unicode strings to JSON Philipp Stephani
2017-12-23 8:28 ` Eli Zaretskii
2017-12-23 12:33 ` Philipp Stephani
2017-12-23 13:44 ` Eli Zaretskii
2017-12-23 14:29 ` Philipp Stephani
2017-12-23 14:52 ` Eli Zaretskii
2017-12-23 15:00 ` Eli Zaretskii
2017-12-23 15:07 ` Philipp Stephani
2017-12-23 15:19 ` Philipp Stephani [this message]
2017-12-23 15:34 ` Eli Zaretskii
2017-12-23 16:20 ` Philipp Stephani
2017-12-23 16:36 ` Eli Zaretskii
2017-12-23 16:58 ` Philipp Stephani
2017-12-23 16:58 ` Philipp Stephani
2017-12-30 22:20 ` Philipp Stephani
2017-12-31 15:52 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAArVCkT1tNki8D2V-gdwm8ixjRxYN6QNOPo36bv5-aFOAm+OKg@mail.gmail.com \
--to=p.stephani2@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=phst@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.