From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#20643: 24.5; Please improve documentation of `pcase-let' Date: Sun, 21 Jun 2015 13:10:13 +0000 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=f46d044304404d781b051906e147 X-Trace: ger.gmane.org 1434892283 13054 80.91.229.3 (21 Jun 2015 13:11:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 21 Jun 2015 13:11:23 +0000 (UTC) Cc: 20643@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 21 15:11:15 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z6f1m-0000La-AH for geb-bug-gnu-emacs@m.gmane.org; Sun, 21 Jun 2015 15:11:14 +0200 Original-Received: from localhost ([::1]:36311 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z6f1l-0005dn-LS for geb-bug-gnu-emacs@m.gmane.org; Sun, 21 Jun 2015 09:11:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55498) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z6f1i-0005dX-9c for bug-gnu-emacs@gnu.org; Sun, 21 Jun 2015 09:11:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z6f1b-0008S0-Ap for bug-gnu-emacs@gnu.org; Sun, 21 Jun 2015 09:11:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51657) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z6f1b-0008Rs-4F for bug-gnu-emacs@gnu.org; Sun, 21 Jun 2015 09:11:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Z6f1a-0006EC-Nn for bug-gnu-emacs@gnu.org; Sun, 21 Jun 2015 09:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Jun 2015 13:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20643 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20643-submit@debbugs.gnu.org id=B20643.143489223223900 (code B ref 20643); Sun, 21 Jun 2015 13:11:02 +0000 Original-Received: (at 20643) by debbugs.gnu.org; 21 Jun 2015 13:10:32 +0000 Original-Received: from localhost ([127.0.0.1]:53103 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z6f15-0006DP-9B for submit@debbugs.gnu.org; Sun, 21 Jun 2015 09:10:31 -0400 Original-Received: from mail-wi0-f173.google.com ([209.85.212.173]:34419) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z6f13-0006DD-Dr for 20643@debbugs.gnu.org; Sun, 21 Jun 2015 09:10:29 -0400 Original-Received: by wicnd19 with SMTP id nd19so54479287wic.1 for <20643@debbugs.gnu.org>; Sun, 21 Jun 2015 06:10:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-type; bh=dKoOJvD+4rwWpEdrpJqGzRtnqZ6iwpZ8yw1h7pD1mwo=; b=Xl0yJshGFsxZlQk3plxHCer6GSKPzyTyO46HTmLS6AEFVilSFwT0Bsif4lDUj4oB8S kN72tG4+nBS+wmu/yfVMg3btrlQtXoVPPcFsMgXhfM82H2WXtAyt7ZZLCQOvN76tg/g+ dPJx4HGY9T0LiVRWiFKu1JHLyHuOhfu8aus2Sn454RpNxRQc0Aht9pYiTfoUEnIu2IwZ oOXnB1qQXSRnfTTt/JdxyuX+UvVzoiAnd6vOUrnAS8H5fzPhGgBJYnDahGDlsbaFOYam 9rX8tCiO6LnFJx2A6bsbg5ZOo1asKwPzboyZIlwC7mS2YypIPbuXy2FDSNmFoVrv6hLo aP4g== X-Received: by 10.180.97.7 with SMTP id dw7mr23312093wib.74.1434892224000; Sun, 21 Jun 2015 06:10:24 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:104169 Archived-At: --f46d044304404d781b051906e147 Content-Type: text/plain; charset=UTF-8 Stefan Monnier schrieb am Mo., 25. Mai 2015 um 04:39 Uhr: > > The documentation of `pcase-let' is very terse. Please expand it to > > state what happens to each binding in the case that the pattern of a > > binding matches, in the case where it doesn't match, and in the case > > where there are no binding constructs in a pattern. > > I added: > > The macro is expanded and optimized under the assumption that those > patterns *will* match, so a mismatch may go undetected or may cause > any kind of error." > > > Thanks. Though I think it would be better to be more defensive and guarantee to raise a signal in the case of a mismatch. --f46d044304404d781b051906e147 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Stefan= Monnier <monnier@iro.umontr= eal.ca> schrieb am Mo., 25. Mai 2015 um 04:39=C2=A0Uhr:
> The documentation of `pcase-let' is ve= ry terse.=C2=A0 Please expand it to
> state what happens to each binding in the case that the pattern of a > binding matches, in the case where it doesn't match, and in the ca= se
> where there are no binding constructs in a pattern.

I added:

=C2=A0 =C2=A0The macro is expanded and optimized under the assumption that = those
=C2=A0 =C2=A0patterns *will* match, so a mismatch may go undetected or may = cause
=C2=A0 =C2=A0any kind of error."



Thanks. Though I think it would be bet= ter to be more defensive and guarantee to raise a signal in the case of a m= ismatch.=C2=A0
--f46d044304404d781b051906e147--