From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#26073: workaround Date: Thu, 28 Sep 2017 19:39:02 +0000 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a1141a45c190980055a45104e" X-Trace: blaine.gmane.org 1506627623 22519 195.159.176.226 (28 Sep 2017 19:40:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 28 Sep 2017 19:40:23 +0000 (UTC) Cc: 26073@debbugs.gnu.org To: Stefan Monnier , Paul Pogonyshev Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 28 21:40:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxefI-0004pc-2c for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Sep 2017 21:40:08 +0200 Original-Received: from localhost ([::1]:60581 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxefP-000423-EE for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Sep 2017 15:40:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39222) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxefI-0003za-6S for bug-gnu-emacs@gnu.org; Thu, 28 Sep 2017 15:40:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dxefC-0008K1-AX for bug-gnu-emacs@gnu.org; Thu, 28 Sep 2017 15:40:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56657) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dxefC-0008Jr-6g for bug-gnu-emacs@gnu.org; Thu, 28 Sep 2017 15:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dxefB-0003fK-Rw for bug-gnu-emacs@gnu.org; Thu, 28 Sep 2017 15:40:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Sep 2017 19:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26073 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 26073-submit@debbugs.gnu.org id=B26073.150662756014034 (code B ref 26073); Thu, 28 Sep 2017 19:40:01 +0000 Original-Received: (at 26073) by debbugs.gnu.org; 28 Sep 2017 19:39:20 +0000 Original-Received: from localhost ([127.0.0.1]:37104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxeeW-0003eI-A3 for submit@debbugs.gnu.org; Thu, 28 Sep 2017 15:39:20 -0400 Original-Received: from mail-oi0-f41.google.com ([209.85.218.41]:54479) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxeeU-0003e5-Ov for 26073@debbugs.gnu.org; Thu, 28 Sep 2017 15:39:19 -0400 Original-Received: by mail-oi0-f41.google.com with SMTP id u130so4052908oib.11 for <26073@debbugs.gnu.org>; Thu, 28 Sep 2017 12:39:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=F0SsP3NUy0dnpefHNYbNoqH3WguRMiXoYef3RYvRNNA=; b=R3GeIejwcKqoyDgOyg3bOflLWgcIw+MW4nKEQMH7XxCb0aeSr9aOQwP5jGOQtfWRDb dV64i+6E6MLc4hohCSQtY/xzgkwJIYoAQkyMq4cphMEAjRMwKGKEpWIPb/KKdO/ckqU+ hjHXsWdzfrnrTg59bq2W1Z2PpyTAz7CUDl9+O3qwaDD4wtoUi7dQ86F91+BKeqMEMnpq wcej5Krk3vYsg2z0XRUCNy0RQ7Ob74XvyAnRafv7kY0yLqllgM6fplelYY1r3afJ9+qy t2uwLpSHLYqLg6HQ4fGPzVba6Gc5FpFpQBXo+5rq2/nmobVyeST6LwC1He0E6dM4wck0 vvxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F0SsP3NUy0dnpefHNYbNoqH3WguRMiXoYef3RYvRNNA=; b=ZgVWdTYe0LXkxdFf03Ba41UwJvDtVawEi2opu1oljyPHLQbamsAzITNuF48lSmyt/R MWliYqgLxH0EIFJj7yI4i36BlOeUIaJwG96J2o/g5lXmO+3ghiBd5uuiy8vQH5rbmJfh u18qkPkZJsPE/CqRO56vVq8tL02xiCb6CE+AkZ7V3zE/g7yFRJ0ZEOErSUuUyseSwDEW Gf+HMLEYSr/Us/8DOyI5+fpyexvdT4viFH/UxkEWO6PHk3FhWrg0E3EvCo7mkce6bRJ8 ka3GNCMWgg1wvm+NAwQ0dVRFUOxWFyoH0FSd2bR+VaX24TOYGgEkbpZ2n12I6+dLBnUW pJ2Q== X-Gm-Message-State: AMCzsaXLh6Umz3h3FwxDlK9/oXgm55Y0FaaQtMd5IeJ87tYMQfL7j1s+ rVrXqNZwHH0oaAB5YcZxqN4sKCRcjT0Md1T1tXY= X-Google-Smtp-Source: AOwi7QDc2qvoPPk3i4hYlGYheJxXhrXHf6MtzCGiXeYVwVOUv93qvIpgXt4C9R+DKtzw+8AbTei8b7qoI2OK5TskCU0= X-Received: by 10.202.229.5 with SMTP id c5mr1051967oih.82.1506627552871; Thu, 28 Sep 2017 12:39:12 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137543 Archived-At: --001a1141a45c190980055a45104e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Stefan Monnier schrieb am Di., 26. Sep. 2017 um 16:47 Uhr: > > Not sure what might break if we do that: the main user of > cl-symbol-macrolet outside of generator.el AFAIK is the with-slots of > eieio, so the question is whether some users of with-slots expect > a subsequent `let` binding to temporarily change the slot's value. > I just checked and it seems that no code in Emacs itself relies on this > behavior, so maybe it's "safe" to change it. > At least the docstring of `with-slots' and the EIEIO manual both state: "Both =E2=80=98setf=E2=80=99 and =E2=80=98setq=E2=80=99 can be used to set = the value of the slot." In particular, it doesn't state that `let' can be used for this purpose. So as long as `setf' and `setq' continue working, I think it should be OK to change the behavior (it should still be documented as incompatible Lisp change though). --001a1141a45c190980055a45104e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Stefan= Monnier <monnier@iro.umontr= eal.ca> schrieb am Di., 26. Sep. 2017 um 16:47=C2=A0Uhr:

Not sure what might break if we do that: the main user of
cl-symbol-macrolet outside of generator.el AFAIK is the with-slots of
eieio, so the question is whether some users of with-slots expect
a subsequent `let` binding to temporarily change the slot's value.
I just checked and it seems that no code in Emacs itself relies on this
behavior, so maybe it's "safe" to change it.

At least the docstring of `with-slots'= and the EIEIO manual both state: "Both =E2=80=98setf=E2=80=99 and =E2= =80=98setq=E2=80=99 can be used to set the value of the slot." In part= icular, it doesn't state that `let' can be used for this purpose. S= o as long as `setf' and `setq' continue working, I think it should = be OK to change the behavior (it should still be documented as incompatible= Lisp change though).
--001a1141a45c190980055a45104e--