From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#34655: 26.1.92; Segfault in module with --module-assertions Date: Thu, 21 Mar 2019 20:23:30 +0100 Message-ID: References: <874l8r1t3a.fsf@tcd.ie> <8336oamu3y.fsf@gnu.org> <87h8c1cv6l.fsf@tcd.ie> <83lg1dwhse.fsf@gnu.org> <87va0h12js.fsf@tcd.ie> <835zsgw3ui.fsf@gnu.org> <87ef7486h0.fsf@tcd.ie> <83r2b4ul1c.fsf@gnu.org> <831s30upqd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="91283"; mail-complaints-to="usenet@blaine.gmane.org" Cc: "Basil L. Contovounesios" , 34655@debbugs.gnu.org, Stefan Monnier To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 21 20:42:51 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h73aS-000NXl-30 for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Mar 2019 20:42:48 +0100 Original-Received: from localhost ([127.0.0.1]:45830 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h73aR-0000Ne-2u for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Mar 2019 15:42:47 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58914) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h73UN-0003C4-TX for bug-gnu-emacs@gnu.org; Thu, 21 Mar 2019 15:36:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h73IL-00031j-AY for bug-gnu-emacs@gnu.org; Thu, 21 Mar 2019 15:24:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40069) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h73II-0002vD-N2 for bug-gnu-emacs@gnu.org; Thu, 21 Mar 2019 15:24:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h73II-0006yw-I6 for bug-gnu-emacs@gnu.org; Thu, 21 Mar 2019 15:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Mar 2019 19:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34655 X-GNU-PR-Package: emacs Original-Received: via spool by 34655-submit@debbugs.gnu.org id=B34655.155319623026813 (code B ref 34655); Thu, 21 Mar 2019 19:24:02 +0000 Original-Received: (at 34655) by debbugs.gnu.org; 21 Mar 2019 19:23:50 +0000 Original-Received: from localhost ([127.0.0.1]:53612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h73I5-0006yO-Q1 for submit@debbugs.gnu.org; Thu, 21 Mar 2019 15:23:50 -0400 Original-Received: from mail-ot1-f44.google.com ([209.85.210.44]:46997) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h73I4-0006y9-7t for 34655@debbugs.gnu.org; Thu, 21 Mar 2019 15:23:48 -0400 Original-Received: by mail-ot1-f44.google.com with SMTP id c18so6410092otl.13 for <34655@debbugs.gnu.org>; Thu, 21 Mar 2019 12:23:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=7ZGwer1W0tdj+wnKS4mp4+J6wlMXpE1xwFAgblo1gUk=; b=jQnpoY0nQHsi7uZanzTSRMgUY272gFzugHDsoQpcGjnBm8YL2vUlv9vJPdSkVHLJGz XtdnUFdC3IvUJUQm5bClhx9VFyUK8kjwMPY1McgccEuvpHfk1x2P+/b4jAb4S9+W7ftJ 1DipYfJX4aATH9jKD4ai9Po+wFhUSmdEQpkVY9epW22lGA9U7Z5v7x4a1YU3naAKdZCJ m8bVAy7dYx9QsCtN5Ph80VtLyhcbJrYT69hnrowgMz6uVfuK9fEMKlTmw+4taf0Fxhuz K3tYw7pgcz7pVorlRPJ+01HnkJJtAV4kbVYRFzlYoAtrY0yewewLWrIhEENarrgQu+Ek zBIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=7ZGwer1W0tdj+wnKS4mp4+J6wlMXpE1xwFAgblo1gUk=; b=TE0wW7ObYH7dKD7toMgMUAm4dAyquf5HfhHOKjDjLYrrb6HpzSp2PbnCPWynBmiJko 48wlAUMvTab/OrP9+YBikIAcfeHvYc1jif91evmF9eLDQwHB+okSf6RkTDUdHDhSjse7 PyzgXmaKUZXIMUHyxlXDLAPTd5/uk1F8K6LFa7TQF6iLgEkjlF8tpt4wrAuEy3/3rgRZ Go18IEUX1w8aYQ4ngM+n0KRby3SRA7e4fr7Qb7voA9NBLo/u0+txInQlHDk2B4eJutmy O69p5OkMYT3pCgkq7OmZSv0l5ZsNKpy3E1LQLXQ53DB8TEQoey1RY6y6catJ0qu6w88s ox2w== X-Gm-Message-State: APjAAAUiIIxhokhpsT0xtaIaA4XwwuTCelEDIVWi/8bklQ9O9jscW6XS NX1FH1WRzogfawiIAyAbXBDIw+1pddu5FIXouIw= X-Google-Smtp-Source: APXvYqyEQUGEDxIuRr/aH5x0fvKRUZY+6oDtnmoG6xAFXygt4IX52EV4Ga1XWMbOuPF4btmPpbmiXESmENOgzWB2mMk= X-Received: by 2002:a9d:62c8:: with SMTP id z8mr3797319otk.144.1553196221499; Thu, 21 Mar 2019 12:23:41 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156581 Archived-At: Am Do., 21. M=C3=A4rz 2019 um 19:28 Uhr schrieb Philipp Stephani : > > Am Do., 21. M=C3=A4rz 2019 um 18:00 Uhr schrieb Eli Zaretskii : > > > > > From: Philipp Stephani > > > Date: Thu, 21 Mar 2019 17:11:41 +0100 > > > Cc: "Basil L. Contovounesios" , 34655@debbugs.gnu.or= g > > > > > > I haven't checked everything in detail, but my impression is that thi= s > > > is rather another instance of bug#31238. Fixing this only when module > > > assertions are enabled will probably not fix anything, but rather mas= k > > > issues. Reverting commit 3eb93c07f7a60ac9ce8a16f10c3afd5a3a31243a is > > > still the right approach here. Can you please hold off a bit? I've > > > almost completed the revert, but haven't pushed it yet. Once that's i= n > > > we can check whether it also fixes this issue. > > > > I will CC Stefan, who committed 3eb93c07f7a60ac9ce8a16f10c3afd5a3a31243= a. > > > > I'm not sure we should revert that; we could instead add GC protection > > for those parts that need it. > > Yes, that's what reverting that commit does :-) > We need to mark the objects in all cases, not just when module > assertions are enabled. > Note that both the designer of the module API (Daniel) and I as one of > its main implementers disagree with commit > 3eb93c07f7a60ac9ce8a16f10c3afd5a3a31243a. I'm happy to discuss > alternatives, but for now we should revert it and discuss the > alternatives *before* implementing them. I've already confirmed that > reverting commit 3eb93c07f7a60ac9ce8a16f10c3afd5a3a31243a fixes > bug#31238, and I can try it with this bug as well. I wasn't able to reproduce bug#34655 myself (these things tend to be rather flaky), but I've now reverted commit 3eb93c07f7a60ac9ce8a16f10c3afd5a3a31243a, and at least bug#31238 is now consistently fixed (for me at least). Basil, can you check whether you can still reproduce bug#34655 with the current master? Thanks!