From: Philipp Stephani <p.stephani2@gmail.com>
To: Emacs developers <emacs-devel@gnu.org>
Subject: String encoding in json.c
Date: Sat, 23 Dec 2017 14:26:09 +0000 [thread overview]
Message-ID: <CAArVCkSoF9SQx_tUyx_wHc5bMKavY+qOeBYo=xiCLO4oXdz7jQ@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 867 bytes --]
Hi,
I've benchmarked serialization and parsing of JSON with and without
explicit encoding. I've found that leaving out the coding makes both
operations significantly faster – from a speedup of a factor of 1.11 ± 0.06
for parsing canada.json to 1.57 ± 0.08 for serializing twitter.json. Other
speedups are in between, but the speedup is always significant (to at least
one standard deviation). All unit tests pass when leaving out the coding
steps – which isn't surprising given that currently the coding operations
are expensive no-ops. Therefore I'd suggest to document the internal string
encoding in lisp.h or character.h and remove the explicit coding in json.c
and emacs-module.c. It's very unlikely that the internal string encoding
will change frequently, and if so, the unit tests should catch potential
issues caused by that.
Philipp
[-- Attachment #2: Type: text/html, Size: 941 bytes --]
next reply other threads:[~2017-12-23 14:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-23 14:26 Philipp Stephani [this message]
2017-12-23 14:43 ` String encoding in json.c Eli Zaretskii
2017-12-23 15:31 ` Philipp Stephani
2017-12-23 15:53 ` Eli Zaretskii
2017-12-23 17:27 ` Philipp Stephani
2017-12-23 18:18 ` Eli Zaretskii
2017-12-26 21:42 ` Philipp Stephani
2017-12-27 16:08 ` Eli Zaretskii
2017-12-24 20:48 ` Dmitry Gutov
2017-12-25 16:21 ` Eli Zaretskii
2017-12-25 20:51 ` Dmitry Gutov
2017-12-26 4:35 ` Eli Zaretskii
2017-12-26 21:50 ` Philipp Stephani
2017-12-27 2:00 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAArVCkSoF9SQx_tUyx_wHc5bMKavY+qOeBYo=xiCLO4oXdz7jQ@mail.gmail.com' \
--to=p.stephani2@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.