From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: master 8dcb19f 4/4: Add a unit test testing interaction between threads and processes. Date: Sat, 23 Jan 2021 21:33:29 +0100 Message-ID: References: <83k0s34eo1.fsf@gnu.org> <83h7n74cwe.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26989"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philipp Stephani , Emacs developers To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 23 21:36:25 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l3Pdw-0006uf-FI for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Jan 2021 21:36:24 +0100 Original-Received: from localhost ([::1]:35458 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3Pdv-0001LK-GN for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Jan 2021 15:36:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40286) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3PbL-0006yj-8G for emacs-devel@gnu.org; Sat, 23 Jan 2021 15:33:43 -0500 Original-Received: from mail-oi1-x230.google.com ([2607:f8b0:4864:20::230]:36993) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l3PbJ-0004bA-Gh; Sat, 23 Jan 2021 15:33:42 -0500 Original-Received: by mail-oi1-x230.google.com with SMTP id r189so10297867oih.4; Sat, 23 Jan 2021 12:33:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aKqtsZETMqK8e76UAgFFfeZSZN1XHapsUv1aXJzMbqk=; b=YmMIuXpz7DxgvGpxNvARseT+ABSijeWThswjMskUQvhHPL+KPo2HfksLt9LcRzlSv4 1hEYrtCAanBxyJQflzHAlFKuDkGLmHAzEJ7PZoggnAeo4MB7m3W53OdDKfQr2/FN6OV3 SZfGZfJ6xOlf7vpd5ge3wCWMomcR9qyuZIAAReHAE25v2UR9+7Z/LPXQUOSc667bc3nz skBRXYvFhU0NHuwhojwmvsr+/B7hremH5UP6ZzXW264IINZnSSwOmUqCmhQS+M59bhRr DNbXV0ZQICQTjOrui/OalbqQuDK7q6AsyYRqAS5scQU0ZucsG56nLvEln5lIP2/Cg41H UfGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aKqtsZETMqK8e76UAgFFfeZSZN1XHapsUv1aXJzMbqk=; b=joGQDPipBaNSNL+28touYzLnqRldAnrYYr13/mHW7Sse5aqeaLvQf5rcaAIzwReDdN eX3p/YbvJ6iRHCNN3nv2eFMDmh6CjU+VN6sx+Nk2Z8KUZWk07VPxNFs7pMBn/+PmsCWs f8ohJYB4+X6RgD1jqlINyiOQ2JkfHB5x0nd3TnT4q2uFhWg1fRYWBPEbdiET1guWxSCt uvWR/XAZUghOYfDPz28Q6wc2cPLeiR8GFK32CtghX2BREM7Hp4E4f3ncn1NNe7D4XkMa efOJCli6aKWd5HtsHn1FFTVh5ZV+TsWj3HC1cGyf/yxNVoBJDuJkAMOtzz+XyL3TitPs hZyw== X-Gm-Message-State: AOAM530u4gEGjxyYoI+bONbSb++Os/zZjLDUB9w78qUsPteA4uvrv888 jq01++WLp9sdN8KI5/xYi1DeV+u2wm3pE8zhmpq8a8TLzss= X-Google-Smtp-Source: ABdhPJwi140cMp0lCeQKPVh5pX11dNv/F79MaouCEUDpLZhYO1z0jf/9ulZr2PawnVhT2irM2YDdnUpQKGwAKHNd4HA= X-Received: by 2002:aca:ea08:: with SMTP id i8mr815398oih.150.1611434019840; Sat, 23 Jan 2021 12:33:39 -0800 (PST) In-Reply-To: <83h7n74cwe.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::230; envelope-from=p.stephani2@gmail.com; helo=mail-oi1-x230.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263320 Archived-At: Am Sa., 23. Jan. 2021 um 21:27 Uhr schrieb Eli Zaretskii : > > > Date: Sat, 23 Jan 2021 21:49:18 +0200 > > From: Eli Zaretskii > > Cc: Philipp Stephani , emacs-devel@gnu.org > > > > Test process-tests/multiple-threads-waiting condition: > > (ert-test-failed > > ((should > > (eql > > (process-exit-status process) > > 0)) > > :form > > (eql 1 0) > > :value nil)) > > FAILED 21/26 process-tests/multiple-threads-waiting (8.859375 sec) > > And if I run just this one test (using SELECTOR=...), it hangs in the > first call to thread-join. > > Can you describe the idea of the test, This test essentially implements your request to verify the interactions between the self-pipe for SIGCHLD and threads. Seems it discovered some issues on Windows instead! The test works fine on GNU/Linux and macOS. > and in particular why did you > expect the threads to start running? IOW, which part of this test is > supposed to force the main thread to yield so that one of the other > threads starts running? thread-join should yield.