From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#54410: One cl-defgeneric in xref.el should be cl-defmethod Date: Thu, 17 Mar 2022 13:07:52 +0100 Message-ID: References: <838rtainhy.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36796"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 54410-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 17 13:13:35 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nUp0Z-0009UG-JO for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Mar 2022 13:13:35 +0100 Original-Received: from localhost ([::1]:46466 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nUp0Y-0007CG-DU for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Mar 2022 08:13:34 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57810) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUowA-0004tQ-ES for bug-gnu-emacs@gnu.org; Thu, 17 Mar 2022 08:09:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59519) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nUowA-0002gV-5Z for bug-gnu-emacs@gnu.org; Thu, 17 Mar 2022 08:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nUowA-0008UN-0J for bug-gnu-emacs@gnu.org; Thu, 17 Mar 2022 08:09:02 -0400 Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Mar 2022 12:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 54410 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 54410@debbugs.gnu.org, p.stephani2@gmail.com, p.stephani2@gmail.com Original-Received: via spool by 54410-done@debbugs.gnu.org id=D54410.164751889732572 (code D ref 54410); Thu, 17 Mar 2022 12:09:01 +0000 Original-Received: (at 54410-done) by debbugs.gnu.org; 17 Mar 2022 12:08:17 +0000 Original-Received: from localhost ([127.0.0.1]:53414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUovK-0008TB-2i for submit@debbugs.gnu.org; Thu, 17 Mar 2022 08:08:17 -0400 Original-Received: from mail-oo1-f41.google.com ([209.85.161.41]:42620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUovJ-0008Sz-A2 for 54410-done@debbugs.gnu.org; Thu, 17 Mar 2022 08:08:09 -0400 Original-Received: by mail-oo1-f41.google.com with SMTP id s203-20020a4a3bd4000000b003191c2dcbe8so6121291oos.9 for <54410-done@debbugs.gnu.org>; Thu, 17 Mar 2022 05:08:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=mlIRGiuNKdajABQf0snuriAf9GUOSlXp8LO+PaB0LN4=; b=HFnznij+x37oasMCk53EN/f6CCJkuQDKZ0dRZftwsfn0eRxrpSbavnM3KqZ4pRyePw 2T/pIHvimvCFx7UBjCU5yf5uhAECVgMeRr7kr159mSTR9xEYB4J253Tew7wq6hNpIB+Z qwnmzfAmLrvYi4eecIRIcFL0Cl905k8PfGPoj+g5lBIbcvFPVQ5YauiDoL0SmNS9e3Ka x8SwRpNIBk1xbhHGqjVkmxq6FM3jF0uU0/SCbmzpWMrX8T4+ybk+dlYMUSnamKTjCxw+ 14zv1tNHgEhqlZm+bhW5LdQKsiYiWls+lVuq/k+1O5BlIK7bJhQPhf7RgWtWpnQXvKH4 UAAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=mlIRGiuNKdajABQf0snuriAf9GUOSlXp8LO+PaB0LN4=; b=hGH+xt8YM6MfVBTOFkj+wgvH8vWrTqvEHh3fl+cpGdIHHkdwNvI/YM/pSfV72EEG0F niyHILHjoMDr4j42O8o9nqNVPacj2QioGbvdckpMibmxFcbY+cZv+eQK6NbZtw6996EZ 6dTEbOa82Go9XjgVMpQQc8GFEtMrXf7UU7J9Njr7L7/oYwxhuBdcfAgpJVwDL+ct/y4S kkkP+Iw6cxniQdiYkM5vDp5rIzQdyx5Ogm1WDnJSTgUl6elsOLtQy50PX92Byfp+uXlN V3Ob9fCQtFCa67RzDGzBy6Dlo3vSZZ2CLlvACwlEoLYdEK6zkMGZJyMtXaHyS4WcJTe9 gK+A== X-Gm-Message-State: AOAM533miYrIWAWt63BrF03etakQsYmNX8zZP0YEqrP3fNRQmwbqjIm3 7esYd14LFuM6JUjawsKFEBvkCA3W72MTfs1ERRA= X-Google-Smtp-Source: ABdhPJx1GT91KNDBZjHUWKHcPIRM+ra8EU2Yq8lnKbobRNwnDfuWAey2AQlT0iL8qxQLiSQeQVCm+oQu4+d64+z8KqA= X-Received: by 2002:a05:6870:1605:b0:dd:a358:61b with SMTP id b5-20020a056870160500b000dda358061bmr3139822oae.134.1647518883459; Thu, 17 Mar 2022 05:08:03 -0700 (PDT) In-Reply-To: <838rtainhy.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228479 Archived-At: Am Mi., 16. M=C3=A4rz 2022 um 04:29 Uhr schrieb Eli Zaretskii : > > > From: Philipp Stephani > > Date: Wed, 16 Mar 2022 00:09:23 +0100 > > > > Is the following patch good for the release branch? > > What problems are caused by the current code? I'm using Edebug for coverage instrumentation, and that only works right in an automated way if there are no duplicate instrumented symbols, because Edebug attaches coverage information to individual symbols. cl-defmethod takes care of this by generating additional symbols, but cl-defgeneric doesn't. > > In general, I'd prefer to leave the release branch alone at this time, > so we could release Emacs 28.1 soon. It seems quite ready. Fine with me, I've pushed it to master as commit 6ed3f04e5a3c8aee40a26805bb00cdd070eba319.