From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#24710: 26.0.50; Feature request: Replace double quotes in electric-quote-mode Date: Sat, 30 Sep 2017 22:21:21 +0000 Message-ID: References: <4fc323e0-ed0a-cc36-08df-d337200d1549@cs.ucla.edu> <83h8vsajyg.fsf@gnu.org> <83efqq9e2t.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a113779ea3d34e1055a6f90f8" X-Trace: blaine.gmane.org 1506810130 11506 195.159.176.226 (30 Sep 2017 22:22:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 30 Sep 2017 22:22:10 +0000 (UTC) Cc: eggert@cs.ucla.edu To: Eli Zaretskii , 24710-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 01 00:22:06 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dyQ97-0002hY-Pm for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 Oct 2017 00:22:06 +0200 Original-Received: from localhost ([::1]:40526 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dyQ9F-0005iG-5z for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Sep 2017 18:22:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43523) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dyQ98-0005hI-S7 for bug-gnu-emacs@gnu.org; Sat, 30 Sep 2017 18:22:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dyQ94-0004lX-Q5 for bug-gnu-emacs@gnu.org; Sat, 30 Sep 2017 18:22:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:32890) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dyQ94-0004l3-Mk for bug-gnu-emacs@gnu.org; Sat, 30 Sep 2017 18:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dyQ94-0004Av-Fy for bug-gnu-emacs@gnu.org; Sat, 30 Sep 2017 18:22:02 -0400 Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Sep 2017 22:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 24710 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 24710@debbugs.gnu.org, p.stephani2@gmail.com, p.stephani2@gmail.com Original-Received: via spool by 24710-done@debbugs.gnu.org id=D24710.150681009916003 (code D ref 24710); Sat, 30 Sep 2017 22:22:02 +0000 Original-Received: (at 24710-done) by debbugs.gnu.org; 30 Sep 2017 22:21:39 +0000 Original-Received: from localhost ([127.0.0.1]:41569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dyQ8g-0004A3-33 for submit@debbugs.gnu.org; Sat, 30 Sep 2017 18:21:38 -0400 Original-Received: from mail-oi0-f48.google.com ([209.85.218.48]:54689) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dyQ8f-00049k-0z for 24710-done@debbugs.gnu.org; Sat, 30 Sep 2017 18:21:37 -0400 Original-Received: by mail-oi0-f48.google.com with SMTP id u130so4224904oib.11 for <24710-done@debbugs.gnu.org>; Sat, 30 Sep 2017 15:21:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ep+wWgP+stMQdoDTWPpZ3/darYqcXI9il74y3FkTuHg=; b=GJch8AiAt3LgqFoT0k3fqrKdtQAvxeq/9vSsOSckrBfb12lkLBFTu93Zpu5Cgis0Sv r1YrGFUHO0f5maiGkHNsutLoPyv7XUK3R03WSOBiiYiUVGCaExa9u6/zNvO0ZWHFwoD9 XgMRAnfI1ggbhfQADcjcXdHuNYaXk5G41/i14/z05lShlqaQGgXxdvqyCpUPNuHxvAqD 2M5rwpkrTZ0pq89zlNuRzn+nZdW6RJiJ3mmfi3XFcbasWy55FZFgLUwW9niK6jzvvtr5 xPoOQiwj5wlnirqJc+L9lWeFLyOJBuHx8SVfWquEwkfbG2sJUIbSuEWvZDeHlxFdftk6 RYkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ep+wWgP+stMQdoDTWPpZ3/darYqcXI9il74y3FkTuHg=; b=Gr4LJ4jZUKMMN46qR56PrI/8AuGNBomp7/VONCw7Vl48v3fy2nN6DYWdZFCguRx0EF oAdzhJqGssgPJHE8L6A+AudDdQVjyrEvcSmwGEQbnBK1SzBJGB9WF2Gckhqs44T1yUKT o9XEbj6/ttRTw6IVTyeWhdkqCH6FrGA52Vas5OYW5XmiErGZgMrDR6K7wy0r27u2Hym4 DIZn8MUDCP7df1SB8BlkvAEzRJnTuvBwRHe6yjKqRM5qd2JVuNd6UFeoMbuAdEv2skv4 Gfxzyp1ywfcyM4xXkwe5ip5ZVEbgtWlnHFz2/CZfFBypJCWU99oHf/rHjo3NxXgKYb4j NGBQ== X-Gm-Message-State: AMCzsaU62pJYiV2q1DVwSS0C61W5l/MG74gN78zg4W1cvq85uy4TLB6N yhWUvifbtAdKsb3JnMEgIlqq9bKWJq8Lmte2iBA= X-Google-Smtp-Source: AOwi7QB6RAIuAAC377r5GtmySLEiRn9ge4kYSBHu2HRtsdLPRru9XiZSf0FP9vTPF/44JDIhQ1AS41xg7oagEF1J0ho= X-Received: by 10.157.59.55 with SMTP id z52mr738006otb.75.1506810091351; Sat, 30 Sep 2017 15:21:31 -0700 (PDT) In-Reply-To: <83efqq9e2t.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137718 Archived-At: --001a113779ea3d34e1055a6f90f8 Content-Type: text/plain; charset="UTF-8" Eli Zaretskii schrieb am Fr., 29. Sep. 2017 um 09:09 Uhr: > > From: Philipp Stephani > > Date: Sun, 24 Sep 2017 07:04:07 +0000 > > Cc: 24710@debbugs.gnu.org > > > > Eli Zaretskii wrote: > > > Thanks. How about updating the Emacs manual as well? > > > > Yes, other than that it looks good to me. > > > > OK, here's a new patch. > > Thanks, this LGTM. > > > Subject: [PATCH] Electric quote mode: Conditionally replace " (Bug#24710) > > > > * lisp/electric.el (electric-quote-replace-double): New user option. > > (electric-quote-post-self-insert-function): Use it. > > > > * electric-tests.el (electric-quote-replace-double-disabled) > > (electric-quote-replace-double-bob) > > (electric-quote-replace-double-bol) > > (electric-quote-replace-double-after-space) > > (electric-quote-replace-double-after-letter) > > (electric-quote-replace-double-after-paren): New unit tests. > > Please add the log entries for the documentation here, when you push. > Pushed as d247e1d30a to master. --001a113779ea3d34e1055a6f90f8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Eli Za= retskii <eliz@gnu.org> schrieb am= Fr., 29. Sep. 2017 um 09:09=C2=A0Uhr:
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Sun, 24 Sep 2017 07:04:07 +0000
> Cc: 24710@d= ebbugs.gnu.org
>
>=C2=A0 Eli Zaretskii wrote:
>=C2=A0 > Thanks. How about updating the Emacs manual as well?
>
>=C2=A0 Yes, other than that it looks good to me.
>
> OK, here's a new patch.

Thanks, this LGTM.

> Subject: [PATCH] Electric quote mode: Conditionally replace " (Bu= g#24710)
>
> * lisp/electric.el (electric-quote-replace-double): New user option. > (electric-quote-post-self-insert-function): Use it.
>
> * electric-tests.el (electric-quote-replace-double-disabled)
> (electric-quote-replace-double-bob)
> (electric-quote-replace-double-bol)
> (electric-quote-replace-double-after-space)
> (electric-quote-replace-double-after-letter)
> (electric-quote-replace-double-after-paren): New unit tests.

Please add the log entries for the documentation here, when you push.

Pushed as d247e1d30a to master.=C2=A0
--001a113779ea3d34e1055a6f90f8--