Build breakage of master on MacOS 10.13

Build breakage of master on MacOS 10.13

[Mikhail Gusarov]

Hi.

I see a breakage of Emacs build on master under MacOS 10.13. Build stops with the following message:

org/org-timer.el:39:1:Error: Searching for program: Is a directory, /bin/zsh

The file in question is not a directory:

% ls -l /bin/zsh
404K -rwxr-xr-x 1 root wheel 596K Sep 21 06:35 /bin/zsh

I have bisected it to 327d251f8a857350a78029c31c7ab3f9797cc727 "Avoid EOVERFLOW problems with file-directory-p", reverting it unbreaks the build.

Please let me know how to further debug the issue.

Mikhail.

Re: Build breakage of master on MacOS 10.13

[Philipp Stephani]

[-- Attachment #1: Type: text/plain, Size: 684 bytes --]

Mikhail Gusarov <dottedmag@dottedmag.net> schrieb am Di., 6. Feb. 2018,
07:32:

> Hi.
>
> I see a breakage of Emacs build on master under MacOS 10.13. Build stops
> with the following message:
>
> org/org-timer.el:39:1:Error: Searching for program: Is a directory,
> /bin/zsh
>
> The file in question is not a directory:
>
> % ls -l /bin/zsh
> 404K -rwxr-xr-x 1 root wheel 596K Sep 21 06:35 /bin/zsh
>
> I have bisected it to 327d251f8a857350a78029c31c7ab3f9797cc727 "Avoid
> EOVERFLOW problems with file-directory-p", reverting it unbreaks the build.
>
> Please let me know how to further debug the issue.
>
> Mikhail.
>

This is https://debbugs.gnu.org/cgi/bugreport.cgi?bug=30350.

[-- Attachment #2: Type: text/html, Size: 1221 bytes --]

bug#30350: Build breakage of master on MacOS 10.13

[Mikhail Gusarov]

[-- Attachment #1: Type: text/plain, Size: 690 bytes --]

Hi.

On Tue, 6 Feb 2018, at 09:08, Philipp Stephani wrote:
>> I see a breakage of Emacs build on master under MacOS 10.13. Build
>> stops with the following message:>> 
>> org/org-timer.el:39:1:Error: Searching for program: Is a directory,
>> /bin/zsh>> 
>> The file in question is not a directory:
>> 
>> % ls -l /bin/zsh
>> 404K -rwxr-xr-x 1 root wheel 596K
> This is https://debbugs.gnu.org/cgi/bugreport.cgi?bug=30350.

Yes, it is. I can't find the relevant sources right away, but opening a
file inside a file is a syntax for opening  resource forks under OS X,
so `/foo/bar/baz/.` is a "directory" of resource forks there. This
syntax is not likely to go away anytime soon.
Mikhail.


[-- Attachment #2: Type: text/html, Size: 1378 bytes --]

bug#30350: Build breakage of master on MacOS 10.13

[John Wiegley]

>>>>> "MG" == Mikhail Gusarov <dottedmag@dottedmag.net> writes:

MG>         org/org-timer.el:39:1:Error: Searching for program: Is a
MG> directory, /bin/zsh

MG>         The file in question is not a directory:

MG> Yes, it is. I can't find the relevant sources right away, but opening a
MG> file inside a file is a syntax for opening resource forks under OS X, so
MG> `/foo/bar/baz/.` is a "directory" of resource forks there. This syntax is
MG> not likely to go away anytime soon.

Mikhail, are you saying that "/bin/zsh", where /bin/zsh is a file, should
report as a directory on OS X? I think I've misunderstood your comment.

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

bug#30350: Build breakage of master on MacOS 10.13

[Mikhail Gusarov]

Hi John,

On Tue, 6 Feb 2018, at 18:40, John Wiegley wrote:

> Mikhail, are you saying that "/bin/zsh", where /bin/zsh is a file, should
> report as a directory on OS X? I think I've misunderstood your comment.

I'm saying that on OS X stat'ing /bin/zsh and /bin/zsh/ (or /bin/zsh/.) gives different results:

% stat /bin/zsh
16777220 721698 -rwxr-xr-x 1 root wheel 0 610288 "Feb  6 22:24:24 2018" "Sep 21 06:35:23 2017" "Nov  6 13:34:29 2017" "Sep 21 06:35:23 2017" 4194304 808 0x80020 /bin/zsh
% stat /bin/zsh/.
stat: /bin/zsh/.: stat: Not a directory
% stat /bin/zsh/
stat: /bin/zsh/: stat: Not a directory
%

bug#30350: Build breakage of master on MacOS 10.13

[Philipp Stephani]

[-- Attachment #1: Type: text/plain, Size: 891 bytes --]

Mikhail Gusarov <dottedmag@dottedmag.net> schrieb am Di., 6. Feb. 2018 um
22:26 Uhr:

> Hi John,
>
> On Tue, 6 Feb 2018, at 18:40, John Wiegley wrote:
>
> > Mikhail, are you saying that "/bin/zsh", where /bin/zsh is a file, should
> > report as a directory on OS X? I think I've misunderstood your comment.
>
> I'm saying that on OS X stat'ing /bin/zsh and /bin/zsh/ (or /bin/zsh/.)
> gives different results:
>
> % stat /bin/zsh
> 16777220 721698 -rwxr-xr-x 1 root wheel 0 610288 <06102%2088> "Feb  6
> 22:24:24 2018" "Sep 21 06:35:23 2017" "Nov  6 13:34:29 2017" "Sep 21
> 06:35:23 2017" 4194304 808 0x80020 /bin/zsh
> % stat /bin/zsh/.
> stat: /bin/zsh/.: stat: Not a directory
> % stat /bin/zsh/
> stat: /bin/zsh/: stat: Not a directory
> %
>

That's the behavior required by POSIX, and Linux behaves in exactly the
same way, so it's not something where we'd need to special-case macOS.

[-- Attachment #2: Type: text/html, Size: 1343 bytes --]

bug#30350: Build breakage of master on MacOS 10.13

[Mikhail Gusarov]

[-- Attachment #1: Type: text/plain, Size: 714 bytes --]


On Tue, 6 Feb 2018, at 22:29, Philipp Stephani wrote:
>  I'm saying that on OS X stat'ing /bin/zsh and /bin/zsh/ (or
>  /bin/zsh/.) gives different results:>> 
>>  % stat /bin/zsh
>>  16777220 721698 -rwxr-xr-x 1 root wheel 0 610288[1] "Feb  6 22:24:24
>>  2018" "Sep 21 06:35:23 2017" "Nov  6 13:34:29 2017" "Sep 21 06:35:23
>>  2017" 4194304 808 0x80020 /bin/zsh>>  % stat /bin/zsh/.
>>  stat: /bin/zsh/.: stat: Not a directory
>>  % stat /bin/zsh/
>>  stat: /bin/zsh/: stat: Not a directory
>>  %
> 
> That's the behavior required by POSIX, and Linux behaves in
> exactly the same way, so it's not something where we'd need to special-
> case macOS.
Ah, ignore me then, please :)


Links:

  1. tel:06102%2088

[-- Attachment #2: Type: text/html, Size: 1400 bytes --]

bug#30350: Build breakage of master on MacOS 10.13

[Mikhail Gusarov]

On Tue, 6 Feb 2018, at 22:26, Mikhail Gusarov wrote:

> I'm saying that on OS X stat'ing /bin/zsh and /bin/zsh/ (or /bin/zsh/.) 
> gives different results:

And here is a test program and its output:

#include <sys/stat.h>
#include <errno.h>
#include <stdio.h>

static void teststat(const char *filename)
{
    struct stat st;
    errno = 0;
    int res = stat(filename, &st);
    printf("%s stat->%d errno->%d\n", filename, res, errno);
}

int main()
{
    teststat("/bin/zsh");
    teststat("/bin/zsh/");
    teststat("/bin/zsh/.");
    return 0;
}

% ./a
/bin/zsh stat->0 errno->0
/bin/zsh/ stat->-1 errno->20
/bin/zsh/. stat->-1 errno->20
%

errno 20 is ENOTDIR.

bug#30350: Build breakage of master on MacOS 10.13

[Alan Third]

On Tue, Feb 06, 2018 at 04:27:40PM +0100, Mikhail Gusarov wrote:
> Yes, it is. I can't find the relevant sources right away, but opening a
> file inside a file is a syntax for opening  resource forks under OS X,
> so `/foo/bar/baz/.` is a "directory" of resource forks there. This
> syntax is not likely to go away anytime soon.

Hmm, perhaps this method of checking for a directory just won’t ever
work reliably on macOS then.
-- 
Alan Third

bug#30350: Build breakage of master on MacOS 10.13

[Philipp Stephani]

[-- Attachment #1: Type: text/plain, Size: 686 bytes --]

Alan Third <alan@idiocy.org> schrieb am Di., 6. Feb. 2018 um 19:56 Uhr:

> On Tue, Feb 06, 2018 at 04:27:40PM +0100, Mikhail Gusarov wrote:
> > Yes, it is. I can't find the relevant sources right away, but opening a
> > file inside a file is a syntax for opening  resource forks under OS X,
> > so `/foo/bar/baz/.` is a "directory" of resource forks there. This
> > syntax is not likely to go away anytime soon.
>
> Hmm, perhaps this method of checking for a directory just won’t ever
> work reliably on macOS then.
>
>
But it works reliable in all isolated test cases that I've tried. Only the
combination with call-process seems to cause issues for some weird reason.

[-- Attachment #2: Type: text/html, Size: 999 bytes --]

bug#30350: Build breakage of master on MacOS 10.13

[Philipp Stephani]

[-- Attachment #1: Type: text/plain, Size: 1054 bytes --]

Mikhail Gusarov <dottedmag@dottedmag.net> schrieb am Di., 6. Feb. 2018 um
16:28 Uhr:

> Hi.
>
> On Tue, 6 Feb 2018, at 09:08, Philipp Stephani wrote:
>
> I see a breakage of Emacs build on master under MacOS 10.13. Build stops
> with the following message:
>
> org/org-timer.el:39:1:Error: Searching for program: Is a directory,
> /bin/zsh
>
> The file in question is not a directory:
>
> % ls -l /bin/zsh
> 404K -rwxr-xr-x 1 root wheel 596K
>
> This is https://debbugs.gnu.org/cgi/bugreport.cgi?bug=30350.
>
>
> Yes, it is. I can't find the relevant sources right away, but opening a
> file inside a file is a syntax for opening resource forks under OS X, so
> `/foo/bar/baz/.` is a "directory" of resource forks there. This syntax is
> not likely to go away anytime soon.
>
>
It's true that you can access the forks in a pseudo-directory
/foo/bar/baz/..namedforks/, but faccessat still seems to work correctly
even for files containing resource forks, at least on my system. That is,
the POSIX API doesn't actually treat /foo/bar/baz/. as a directory.

[-- Attachment #2: Type: text/html, Size: 1919 bytes --]