From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Wed,=C2=A0 4 Apr 2018 14:02:18 +0200
> Cc: Philipp Stephani <phst@google.com>
>
> * src/process.c (Fmake_process): Inherit output coding system to
> newly-created pipe process.
I'm sorry, I don't understand the need for this "inheriting&qu= ot;.=C2=A0 If the
problem is that make-process and make-pipe-process use different logic
to decide on the default coding-systems, then I think we should make
them use the same logic, and then there will be no need for
"inheriting".=C2=A0 Or is there something else I'm missing?
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 (let ((process (make-process
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 :name "stderr-coding"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 :command (list shell-file-name shell-command-switch
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(conc= at "echo -e '\\xC3\\xA4\\r'; "
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0"echo -e '\\xC3\\xB6\\r' >&2&qu= ot;))
This shell command is non-portable.=C2=A0 I think even "echo -e" = is not
portable enough, let alone with hex escapes and the trailing \r.
Can't we use Emacs instead?=C2=A0 There's also the ";" is= sue again.
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (should (equal (buffer-string) &qu= ot;\u00C3\u00B6\n"))))
> +=C2=A0 =C2=A0 =C2=A0 (should (equal (buffer-string) "\u00C3\u00A= 4\n")))))
Why not use literal characters here?=C2=A0 It will make the source more
readable, IMO.