From mboxrd@z Thu Jan 1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Philipp Stephani
Newsgroups: gmane.emacs.bugs
Subject: bug#31676: 27.0.50;
More helpful error message for unescaped character literals
Date: Fri, 19 Apr 2019 11:54:32 +0200
Message-ID:
References:
<837en9uyaq.fsf@gnu.org>
<83k1r7sw7m.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
logging-data="245035"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: Lars Ingebrigtsen , 31676@debbugs.gnu.org
To: Eli Zaretskii
Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 19 11:56:26 2019
Return-path:
Envelope-to: geb-bug-gnu-emacs@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
(Exim 4.89)
(envelope-from )
id 1hHQFt-0011eZ-Rw
for geb-bug-gnu-emacs@m.gmane.org; Fri, 19 Apr 2019 11:56:25 +0200
Original-Received: from localhost ([127.0.0.1]:54085 helo=lists.gnu.org)
by lists.gnu.org with esmtp (Exim 4.71)
(envelope-from )
id 1hHQFs-00080Q-TC
for geb-bug-gnu-emacs@m.gmane.org; Fri, 19 Apr 2019 05:56:24 -0400
Original-Received: from eggs.gnu.org ([209.51.188.92]:46639)
by lists.gnu.org with esmtp (Exim 4.71)
(envelope-from ) id 1hHQEZ-0006zf-Dk
for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2019 05:55:04 -0400
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from ) id 1hHQEY-00077A-F8
for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2019 05:55:03 -0400
Original-Received: from debbugs.gnu.org ([209.51.188.43]:58159)
by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
(Exim 4.71) (envelope-from )
id 1hHQEY-00076s-BB
for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2019 05:55:02 -0400
Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
(envelope-from ) id 1hHQEY-0000OA-4m
for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2019 05:55:02 -0400
X-Loop: help-debbugs@gnu.org
Resent-From: Philipp Stephani
Original-Sender: "Debbugs-submit"
Resent-CC: bug-gnu-emacs@gnu.org
Resent-Date: Fri, 19 Apr 2019 09:55:02 +0000
Resent-Message-ID:
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 31676
X-GNU-PR-Package: emacs
Original-Received: via spool by 31676-submit@debbugs.gnu.org id=B31676.15556676921476
(code B ref 31676); Fri, 19 Apr 2019 09:55:02 +0000
Original-Received: (at 31676) by debbugs.gnu.org; 19 Apr 2019 09:54:52 +0000
Original-Received: from localhost ([127.0.0.1]:43470 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from )
id 1hHQEO-0000Nk-Bx
for submit@debbugs.gnu.org; Fri, 19 Apr 2019 05:54:52 -0400
Original-Received: from mail-oi1-f180.google.com ([209.85.167.180]:42663)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from ) id 1hHQEM-0000NV-Hy
for 31676@debbugs.gnu.org; Fri, 19 Apr 2019 05:54:51 -0400
Original-Received: by mail-oi1-f180.google.com with SMTP id w139so3674996oie.9
for <31676@debbugs.gnu.org>; Fri, 19 Apr 2019 02:54:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=mime-version:references:in-reply-to:from:date:message-id:subject:to
:cc; bh=aeUA8axUsv+IgONxWmqTlije063Gmeixwduur33iyhk=;
b=fqDzAdlsSb4oTrAIPbojXjz3VCGzqVAZdIhBLLj/4n+8Vfp0cQVfTQ0sFJIejlBYk2
d/UvA4vBvH5axUJFZIxlDsMGvQNM5hZkanpgA6WbwtA6yRuckwjwe4ngKfgifA6K1JHx
KfZfUA2+bBKOkTMSz4zOy5VDq/Avwe7t8m3hQ6DtHX4cSlpa12iJIriIS5kisCTszRmS
OyEnBcwfcnSG5DCzYXTAN4h540xIFeWpkiQIvUSL6X1encRZ+8cOJwEDwlHf6+i6AOEf
Vz/MikDpXplNbK1wOQbexV8wKZMwi7OGWeD+nY9GJ0PvfOYispQGxcrm9dqxeU1wTF+A
USxw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=aeUA8axUsv+IgONxWmqTlije063Gmeixwduur33iyhk=;
b=sTx6JNlbgqWp0yX7uQqpHeb7r9145IBydWsClkvGFBwN/BeIyGZ30sIhv3s/sffHJu
J0uMhwO13llll4AmSNVcCfgAgLk8xk/+CGI/tAwAB8aOAPYslcxokpOj+xp/L3DaWEms
SLw4Y42unsvNOY/H/xLMUBdOFR5LReoHLLIPPnZV3dNn9GzDmS2HNyaJh/91y9mxAPNz
PFe0JLo50rgs3JOx5gg57bfNBSqqVyYeyt4cK5n0Yyb3Ht607oZlyqAGylaxkxQvai49
2dOTLQfRnfvDfM+bG+OVBLYwRVxT0uagOslvG9thmggtkKvjYk6nTyuNgKhLj4JA6ini
r1CA==
X-Gm-Message-State: APjAAAXjtLnaxcB0crDRLIynUBzxyW1+/hWyXy1MJxwX8ye5gbgf4xZz
miGNWzuGuTB50jLS8ImMFmb55ZY8qazNXbkVTOk=
X-Google-Smtp-Source: APXvYqzxBj5s3h9d3NK+oTQGH5tUWleMN3fv8modq819Ng/WMh4IM7zYkS83GBD6+aOwd1o1vSEBaE/pasY0E0j8KhM=
X-Received: by 2002:aca:47d7:: with SMTP id u206mr1468549oia.9.1555667683777;
Fri, 19 Apr 2019 02:54:43 -0700 (PDT)
In-Reply-To: <83k1r7sw7m.fsf@gnu.org>
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 209.51.188.43
X-BeenThere: bug-gnu-emacs@gnu.org
List-Id: "Bug reports for GNU Emacs,
the Swiss army knife of text editors"
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org
Original-Sender: "bug-gnu-emacs"
Xref: news.gmane.org gmane.emacs.bugs:157827
Archived-At:
Am Sa., 9. Juni 2018 um 19:31 Uhr schrieb Eli Zaretskii :
>
> > From: Philipp Stephani
> > Date: Sat, 9 Jun 2018 19:12:30 +0200
> > Cc: larsi@gnus.org, 31676@debbugs.gnu.org
> >
> > Sounds okay, but can you tell why you implemented
> > lread--unescaped-character-literals in C? If that's because you need
> > to call it from load_warn_unescaped_character_literals, then C
> > functions can call Lisp functions with no problems, we have several
> > examples of that in the sources. AFAICT, the C implementation is just
> > a "transliteration" of straightforward Lisp code, so it reads strange.
> >
> > The function uses an uninterned variable, so it has to be in C. I think that's slightly better than interning the
> > variable and having some Lisp function access it (the latter would have one additional internal symbol).
>
> Why does it need an uninterned variable?
It doesn't need to be uninterned, but it's cleaner that way because no
other code can access the variable.
> And if it does, why cannot
> it create a symbol that is not in obarray?
That's what the patch does.