From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#44631: 28.0.50; Byte compilation fails if destination file is a mount point Date: Sun, 13 Dec 2020 17:41:55 +0100 Message-ID: References: <87ima8ylfv.fsf@gnus.org> <87y2irb7pj.fsf@gnus.org> <87im956g4a.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14124"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44631-done@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 13 17:43:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1koUSk-0003aQ-Mc for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Dec 2020 17:43:10 +0100 Original-Received: from localhost ([::1]:39054 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1koUSj-0000HV-PW for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Dec 2020 11:43:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47958) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1koUSc-0000H1-0W for bug-gnu-emacs@gnu.org; Sun, 13 Dec 2020 11:43:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38414) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1koUSb-0006w3-OO for bug-gnu-emacs@gnu.org; Sun, 13 Dec 2020 11:43:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1koUSb-0000Sq-Md for bug-gnu-emacs@gnu.org; Sun, 13 Dec 2020 11:43:01 -0500 Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Dec 2020 16:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 44631 X-GNU-PR-Package: emacs Mail-Followup-To: 44631@debbugs.gnu.org, p.stephani2@gmail.com, p.stephani2@gmail.com Original-Received: via spool by 44631-done@debbugs.gnu.org id=D44631.16078777341724 (code D ref 44631); Sun, 13 Dec 2020 16:43:01 +0000 Original-Received: (at 44631-done) by debbugs.gnu.org; 13 Dec 2020 16:42:14 +0000 Original-Received: from localhost ([127.0.0.1]:49958 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koURq-0000Rk-9m for submit@debbugs.gnu.org; Sun, 13 Dec 2020 11:42:14 -0500 Original-Received: from mail-oi1-f180.google.com ([209.85.167.180]:36452) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koURo-0000RX-Oh for 44631-done@debbugs.gnu.org; Sun, 13 Dec 2020 11:42:13 -0500 Original-Received: by mail-oi1-f180.google.com with SMTP id 9so9288693oiq.3 for <44631-done@debbugs.gnu.org>; Sun, 13 Dec 2020 08:42:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ggc/sc6KPwvPBw+tHmHGFFqyJxaHlDnwiPTEXLU0sco=; b=lULfFaLDJ0GFFwIZmU8kqPyRMT+9nlUgQYpQVoG8kRH0ITNQ8IaQjHp5LWPwV6bHsw 5t6IoDQHTuGjlnj0DSihdqWI5CXVez3Li6PurY2gCmNY2W5jHDKyP0CMG71umLnBIdWP OnR/DMzTwQWuH4YfgT9xEcJSt81UTZzG3KK92pWyVCoi8cxzpLGZL9SbY1AW+TAvzQIS sBqN1GH1UA6T7k68vg8Qtwwhy+siiFzo7S/k5lnNWOLbK1lg6bedjSX4oFqCkOsbcLsZ msk6gIEBob3aRj6LAFa0KK02/CYTfN7Hcbeo+Gu40mhShj9UrQALODNIsvCsdO5vNc8+ tkTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ggc/sc6KPwvPBw+tHmHGFFqyJxaHlDnwiPTEXLU0sco=; b=E/gfCrVS/iIVtrNYzUDxxO5CmjvJp9XKFpu44zM4LOFcgEH4jBvl0r0tbwuNWyFTtm 0cMHQ70Kw1IxyO69+QE6z4XQvAsPQJ618E1KJ6f2upR2DNm2GeyYws6vAsjdjVZrS2xF zQORMW6YYWY80FoSV7por/IBaTY/euDigvGnPMrR8JENrm15l4C0xDJJaPhj4JEsvqpf F22+luO2FCuuguxRHKHQHZc5U0u6BOmzcnOmLjFNHIACPF/Y29wYBXuqCC+MfULpeCYi UObxHIJmcCtVukb2LQcN0GmZNxTaQPpg/jizf9uiuhKLIRu5u9NG5froiCfSc88yWY6V SnpA== X-Gm-Message-State: AOAM531DVwNlkjc9L5djri7e50ymQabvNA7Ruq8b1xC9HTV27QSl3eBi PuWSbhs+pN885Iy1MuY0YWzEyIHiJa6Wbxapg8Y= X-Google-Smtp-Source: ABdhPJxgHVkc0zlRREYJUHySTDeU7VZ+ztJgyiwEBKjRAMqZhq9nPz5HB3P/hyLoyOJwewToJ5h0d4rOFGDgOY8Lf2Y= X-Received: by 2002:a54:4881:: with SMTP id r1mr15416252oic.9.1607877726942; Sun, 13 Dec 2020 08:42:06 -0800 (PST) In-Reply-To: <87im956g4a.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195970 Archived-At: Am So., 13. Dez. 2020 um 13:32 Uhr schrieb Lars Ingebrigtsen : > > Philipp Stephani writes: > > > I guess it also depends on what the semantics are that > > byte-compile-file guarantees. If it attempts to guarantee atomicity, > > then only a intra-filesystem rename (or similar alternatives such as > > O_TMPFILE + linkat) are acceptable, and technically, not even the > > current fallback on EXDEV (which makes rename-file nonatomic) is OK. > > If atomic writes are best-effort, then we could always fall back to > > copy-file + delete-file on any file-error. > > It's definitely best-effort, so altering byte-compile-file to try > copy-file + delete-file sounds like the best solution to me. I've now pushed a slightly different fix to master (commit fe50a8b9ba79b4ac14a3a352d8bf84eaee4f2122).