From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: Old-style backquotes Date: Sat, 09 Dec 2017 21:05:22 +0000 Message-ID: References: <46860d72-9c7e-2c80-5fe3-e17f5ccd6e2d@cs.ucla.edu> <83h8vg1dhy.fsf@gnu.org> <83376ttyji.fsf@gnu.org> <831smdtycz.fsf@gnu.org> <83zi91sigu.fsf@gnu.org> <20171209204831.GC15719@ACM> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a113a870a79ba7e055feea9fe" X-Trace: blaine.gmane.org 1512853544 30370 195.159.176.226 (9 Dec 2017 21:05:44 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 9 Dec 2017 21:05:44 +0000 (UTC) Cc: Eli Zaretskii , eggert@cs.ucla.edu, emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 09 22:05:39 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eNmJW-0007eM-Dy for ged-emacs-devel@m.gmane.org; Sat, 09 Dec 2017 22:05:38 +0100 Original-Received: from localhost ([::1]:42562 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eNmJd-0003QA-OA for ged-emacs-devel@m.gmane.org; Sat, 09 Dec 2017 16:05:45 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43855) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eNmJW-0003Q2-32 for emacs-devel@gnu.org; Sat, 09 Dec 2017 16:05:39 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eNmJU-0002jz-W0 for emacs-devel@gnu.org; Sat, 09 Dec 2017 16:05:38 -0500 Original-Received: from mail-qt0-x231.google.com ([2607:f8b0:400d:c0d::231]:38950) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eNmJS-0002iX-E5; Sat, 09 Dec 2017 16:05:34 -0500 Original-Received: by mail-qt0-x231.google.com with SMTP id k19so30807656qtj.6; Sat, 09 Dec 2017 13:05:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=r3OMR9evb1GgtbLiqf9iS4mCRqs3s0rLl84VIXY9GY0=; b=gLi+Mb9lUN4DR5N5QbPNQt5lk+rUyROfJpmMxNB+bPKjkKmBmo3dX1Se8YEIdvRGzg diS5nV2pFVQhnhl37iuiYUXWefeVPwWF5nTgz/U9DPVvMMV1xuzTT6YojIQNH25/GhRb 9laQCxs4OtcXYed2LEjCOs5fPQdamNXRO1v2KRRsAWGi+gF4LctLRcmwYEPVq0TaG6e9 SuNCojQ8isNEa7qgNiPPUl+CmR+0jOMFtMshSapKWYuJ9R5+btVdjJEc478Kg0cyQWt9 nzzkcv++k4i5+35JbyyYeLn6unEghW41JmRGgPUP8tUtMEufn63gJZgg1sH8oQIdMQsa WJwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=r3OMR9evb1GgtbLiqf9iS4mCRqs3s0rLl84VIXY9GY0=; b=taTyvJ/I4NWpH77EdaXXakbxch7mxX8V3Lu6W88MkrSTX9nI/NIzCBxoFP7I4LW8h8 HBS9g4TepBFRH07QhVWtpxCki9lIGNojIG7UenP3V+1FVOtSBu0VNJ0tlVH3HlCUJG4s BTnqUAoqV0OY1UApserI3R9MyIQPOgEc4KtcHxt11yMb5e8UoC9TjMFe4sVgjLBcuKrm wkWdSiLDARo/XGBNpqI+Y3Uefz2JWkhkO9VOrce2S7y64gVitV0Oz3uNrhfJpjgXO9Wq xBfZTlqIBtK2fnfyreZoS1+4puO+Wet905n1XEjkRv6wPpSX44HQvFPMlFZSJ2JgwBV7 dD0g== X-Gm-Message-State: AKGB3mLleZMaTxdfmSwjBPDKlbR/zESinmEobr1JDuo+fM7C1qP2WrwA PaFrBPaTiZHQEba+y8lXi9TIyVjXsEpxN6tS3oQ= X-Google-Smtp-Source: AGs4zMbBSV5WSvZrUsI7z20MWbFzMx+5HgH3iGFtLAPpQ87IQjWk2vixuc9oFTYwt2l+02LMMeQpY3XrmLus2ODQNWE= X-Received: by 10.200.35.28 with SMTP id a28mr22700675qta.51.1512853533733; Sat, 09 Dec 2017 13:05:33 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:220833 Archived-At: --001a113a870a79ba7e055feea9fe Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Philipp Stephani schrieb am Sa., 9. Dez. 2017 um 21:58 Uhr: > Alan Mackenzie schrieb am Sa., 9. Dez. 2017 um 21:55 Uhr: > >> Hello, Philipp. >> >> On Sat, Dec 09, 2017 at 20:44:35 +0000, Philipp Stephani wrote: >> > Philipp Stephani schrieb am So., 8. Okt. 2017 >> um >> > 18:59 Uhr: >> >> > > Eli Zaretskii schrieb am So., 8. Okt. 2017 um 18:38 >> Uhr: >> >> > >> > From: Philipp Stephani >> > >> > Date: Sun, 08 Oct 2017 16:25:44 +0000 >> > >> > Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org >> >> > >> > Here's a new patch that also fixes the byte compiler tests. >> >> > >> Thanks, LGTM, but please mention the NEWS change in the log message= . >> >> > >> Also, the log message should quote 'like this', not =E2=80=98like t= his=E2=80=99. >> >> >> > > Fixed and pushed as 9613690f6e to master. >> >> >> > I've now fixed the Bovine issue and re-pushed this commit as 8b8197235= f >> to >> > master. >> >> Just as a matter of interest, I think there are still some old style >> backquotes in advice.el. In master: >> >> find . -name '*.el' | xargs grep -n '(` ' >> >> produces: >> >> ./emacs-lisp/advice.el:1517:;; (` (list (, x)))) >> ./emacs-lisp/advice.el:1550:;; (` (progn (print (, x)) >> >> . Do these need converting? >> >> > Thanks, compiling didn't catch those because they are in comments. Yes, > they should definitely be fixed. Will send a follow-up patch in a second. > Fixed in commit ac6ea59830. --001a113a870a79ba7e055feea9fe Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Philip= p Stephani <p.stephani2@gmail.c= om> schrieb am Sa., 9. Dez. 2017 um 21:58=C2=A0Uhr:
Alan Mackenzie <acm@muc.de> schrieb am Sa., 9. Dez. 2017 um 21:55=C2=A0Uhr:
Hello, Philipp.

On Sat, Dec 09, 2017 at 20:44:35 +0000, Philipp Stephani wrote:
> Philipp Stephani <p.stephani2@gmail.com> schrieb am So., 8. Okt. 2017 um > 18:59 Uhr:

> > Eli Zaretskii <eliz@gnu.org> schrieb am So., 8. Okt. 2017 um 18:38 Uhr:

> >> > From: Philipp Stephani <p.stephani2@gmail.com>
> >> > Date: Sun, 08 Oct 2017 16:25:44 +0000
> >> > Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org

> >> > Here's a new patch that also fixes the byte compiler= tests.

> >> Thanks, LGTM, but please mention the NEWS change in the log m= essage.

> >> Also, the log message should quote 'like this', not = =E2=80=98like this=E2=80=99.


> > Fixed and pushed as 9613690f6e to master.


> I've now fixed the Bovine issue and re-pushed this commit as 8b819= 7235f to
> master.

Just as a matter of interest, I think there are still some old style
backquotes in advice.el.=C2=A0 In master:

=C2=A0 =C2=A0 find . -name '*.el' | xargs grep -n '(` '

produces:

=C2=A0 =C2=A0 ./emacs-lisp/advice.el:1517:;;=C2=A0 =C2=A0(` (list (, x))))<= br> =C2=A0 =C2=A0 ./emacs-lisp/advice.el:1550:;;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0(` (progn (print (, x))

.=C2=A0 Do these need converting?


Thanks, compiling didn't catch those because they are= in comments. Yes, they should definitely be fixed. Will send a follow-up p= atch in a second.=C2=A0

F= ixed in commit ac6ea59830.=C2=A0
--001a113a870a79ba7e055feea9fe--