Re: Old-style backquotes

[Philipp Stephani <p.stephani2@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1397 bytes --]

Alan Mackenzie <acm@muc.de> schrieb am Sa., 9. Dez. 2017 um 21:55 Uhr:

> Hello, Philipp.
>
> On Sat, Dec 09, 2017 at 20:44:35 +0000, Philipp Stephani wrote:
> > Philipp Stephani <p.stephani2@gmail.com> schrieb am So., 8. Okt. 2017 um
> > 18:59 Uhr:
>
> > > Eli Zaretskii <eliz@gnu.org> schrieb am So., 8. Okt. 2017 um 18:38
> Uhr:
>
> > >> > From: Philipp Stephani <p.stephani2@gmail.com>
> > >> > Date: Sun, 08 Oct 2017 16:25:44 +0000
> > >> > Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org
>
> > >> > Here's a new patch that also fixes the byte compiler tests.
>
> > >> Thanks, LGTM, but please mention the NEWS change in the log message.
>
> > >> Also, the log message should quote 'like this', not ‘like this’.
>
>
> > > Fixed and pushed as 9613690f6e to master.
>
>
> > I've now fixed the Bovine issue and re-pushed this commit as 8b8197235f
> to
> > master.
>
> Just as a matter of interest, I think there are still some old style
> backquotes in advice.el.  In master:
>
>     find . -name '*.el' | xargs grep -n '(` '
>
> produces:
>
>     ./emacs-lisp/advice.el:1517:;;   (` (list (, x))))
>     ./emacs-lisp/advice.el:1550:;;         (` (progn (print (, x))
>
> .  Do these need converting?
>
>
Thanks, compiling didn't catch those because they are in comments. Yes,
they should definitely be fixed. Will send a follow-up patch in a second.

[-- Attachment #2: Type: text/html, Size: 2178 bytes --]