From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames Date: Tue, 30 Jan 2018 19:22:34 +0000 Message-ID: References: <87shaun9ix.fsf@users.sourceforge.net> <87po5ymqed.fsf@users.sourceforge.net> <874lnafeun.fsf@gmx.de> <87mv12m3q6.fsf@users.sourceforge.net> <877es528vp.fsf@gmx.de> <87h8r9mlxx.fsf@users.sourceforge.net> <871sichok1.fsf@gmx.de> <87372qz395.fsf@gmx.de> <87shaqkp2q.fsf@users.sourceforge.net> <83mv0vh32y.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="f4f5e80762f08db6930564034910" X-Trace: blaine.gmane.org 1517340339 8736 195.159.176.226 (30 Jan 2018 19:25:39 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 30 Jan 2018 19:25:39 +0000 (UTC) Cc: 30243@debbugs.gnu.org, michael.albinus@gmx.de, Noam Postavsky To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 30 20:25:34 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egbXA-0001lm-09 for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Jan 2018 20:25:32 +0100 Original-Received: from localhost ([::1]:57464 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1egbZA-00047j-TO for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Jan 2018 14:27:36 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:60982) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1egbY6-0003yJ-1y for bug-gnu-emacs@gnu.org; Tue, 30 Jan 2018 14:27:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1egbUl-0001TY-R7 for bug-gnu-emacs@gnu.org; Tue, 30 Jan 2018 14:26:29 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41929) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1egbUl-0001Sc-9D for bug-gnu-emacs@gnu.org; Tue, 30 Jan 2018 14:23:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1egbUj-0003QC-Ou for bug-gnu-emacs@gnu.org; Tue, 30 Jan 2018 14:23:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Jan 2018 19:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30243 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30243-submit@debbugs.gnu.org id=B30243.151734017413135 (code B ref 30243); Tue, 30 Jan 2018 19:23:01 +0000 Original-Received: (at 30243) by debbugs.gnu.org; 30 Jan 2018 19:22:54 +0000 Original-Received: from localhost ([127.0.0.1]:49826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egbUa-0003Pl-Qe for submit@debbugs.gnu.org; Tue, 30 Jan 2018 14:22:54 -0500 Original-Received: from mail-lf0-f54.google.com ([209.85.215.54]:40926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egbUZ-0003PY-CU for 30243@debbugs.gnu.org; Tue, 30 Jan 2018 14:22:51 -0500 Original-Received: by mail-lf0-f54.google.com with SMTP id h92so17035463lfi.7 for <30243@debbugs.gnu.org>; Tue, 30 Jan 2018 11:22:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cnkmcXfUbhSsm3Ioxa5WDYQ0MptaJMOE6ZKEDZgZMjc=; b=idD8DpD6An7w40grlVjqR9oAGQ7bDkk4NKeJDhWKJAtLUdImlAsqy/iDqPCb/6eMLK bgW+yMflSCaSHacZ9E21EMsQqStn7CHSi32lvNJGYMp1JJQYrBpgA9r5Q6h8MqSVWyyy AOpIdGRQ2a7mcQZvkkgb2EgzHmauDhvR/GS6IloA+2WVKvQMyk1/zNtvGQXOSG9j7nVQ /Q/qP4e3rbJebwL7io9ds4w30ILwpqAl4Q4cK/gw/6PSBnhwDyR74u9TWkSM6jXtnzMX xnAfxg2+FVXpRkyuXFfu3GBd78oPIAn7graiAYLsqcNTZwWDP+u/8ZNQD/r7mlPwCixP xocQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cnkmcXfUbhSsm3Ioxa5WDYQ0MptaJMOE6ZKEDZgZMjc=; b=mDNfLt2jCWIfjUiDagpK8416Zgxmoqxl0la87uKrXTqfUjqXLcgi4VcA8qOKUI2gmr MxdUrzgDdQYpMiAF2XBr0/2dhu/DDaJb4rzozBzaQtP5MhuQLmyLNxYWUTSaM5VUluup UMRazyhLhyJDXeLkII8PiVCQI8I9n+JMUc+PnRNMO2GkSOWOtWhCQ5jT92XdvWeqNv+r AVx483Ve+QHa8uNbBB2ZG/TPUS8dx2ERpJMNoxcX16aBuMKONlySYKwafpJgVKv1lzlr 4Ur7wOCIe7mLV/TWil6XXD5bjIvvRnLbyklrdUAK9jBhvNHM+UDzFVbLaoR6kA9wC8Qc zuEA== X-Gm-Message-State: AKwxytfSYXlsslJQkSWOWYJi+vJtvRtwEkk4NOey1wz3MrtEzOQpLd7I 2+mf9okGwYh9gDlGHpsXb0/9Bp3l66qVvM/l+BM= X-Google-Smtp-Source: AH8x225Wwg5rLzRuPDoo6MNVY0CnzZf3u49IuKJulcXkjkDgGVQaBSgqrCxiaZfwcDeCAetabUaeFQ+QlpE2GT4RNos= X-Received: by 10.46.118.18 with SMTP id r18mr16276387ljc.11.1517340165255; Tue, 30 Jan 2018 11:22:45 -0800 (PST) In-Reply-To: <83mv0vh32y.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142711 Archived-At: --f4f5e80762f08db6930564034910 Content-Type: text/plain; charset="UTF-8" Eli Zaretskii schrieb am Di., 30. Jan. 2018 um 14:46 Uhr: > > From: Noam Postavsky > > Date: Sun, 28 Jan 2018 09:58:21 -0500 > > Cc: 30243@debbugs.gnu.org, Philipp Stephani > > > > > The branch scratch/nonspecial-handlers is based on Emacs 26.0.91, do > you > > > plan to merge it there? > > > > Yeah, I agree with Phillip that breaking "/:" files for the release > > would be quite a severe regression. > > > > > I feel a little bit uncomfortable with this, because my fix in > > > file-notify-add-watch didn't get heavy testing. > > > > However, if you think the file-notify fix might possibly affect other > > things, I think leaving that part out for 26.1 would be acceptable. > > > > Now that the code is ready, perhaps Eli has something to say on where it > > should go? > > I think to make up my mind I'd need a few words about each part of the > changes (with the exception of the test suite changes): why is each of > them needed, and what does it do to fix which part of the original > problem. > > I also wonder how come we've succeeded to break quoted file names so > fundamentally -- what change did that, and why did we make it on the > release branch? > > If my git bisect is correct, it was commit a1bbc490155b61a634a6d0b165000ce35b93aa35 to fix Bug#29579. So by fixing one bug we introduced another one :( --f4f5e80762f08db6930564034910 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Eli Za= retskii <eliz@gnu.org> schrieb am= Di., 30. Jan. 2018 um 14:46=C2=A0Uhr:
> From: Noam Postavsky <npostavs@users.sourceforge.net>
> Date: Sun, 28 Jan 2018 09:58:21 -0500
> Cc: 30243@d= ebbugs.gnu.org, Philipp Stephani <p.stephani2@gmail.com>
>
> > The branch scratch/nonspecial-handlers is based on Emacs 26.0.91,= do you
> > plan to merge it there?
>
> Yeah, I agree with Phillip that breaking "/:" files for the = release
> would be quite a severe regression.
>
> > I feel a little bit uncomfortable with this, because my fix in > > file-notify-add-watch didn't get heavy testing.
>
> However, if you think the file-notify fix might possibly affect other<= br> > things, I think leaving that part out for 26.1 would be acceptable. >
> Now that the code is ready, perhaps Eli has something to say on where = it
> should go?

I think to make up my mind I'd need a few words about each part of the<= br> changes (with the exception of the test suite changes): why is each of
them needed, and what does it do to fix which part of the original
problem.

I also wonder how come we've succeeded to break quoted file names so fundamentally -- what change did that, and why did we make it on the
release branch?


If my git bisect is correct, it was co= mmit=C2=A0a1bbc490155b61a634a6d0b165000ce35b93aa35 to fix=C2=A0Bug#29579. S= o by fixing one bug we introduced another one :(
--f4f5e80762f08db6930564034910--