From mboxrd@z Thu Jan 1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Philipp Stephani
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] Ignore pending_signals when checking for quits.
Date: Sun, 10 Feb 2019 20:46:22 +0100
Message-ID:
References: <20190102212218.74902-1-phst@google.com> <83sgy93kkd.fsf@gnu.org>
<834l9bmnyc.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
logging-data="10540"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: Philipp Stephani , Emacs developers
To: Eli Zaretskii
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 10 20:47:04 2019
Return-path:
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
(Exim 4.89)
(envelope-from )
id 1gsv4A-0002aF-SH
for ged-emacs-devel@m.gmane.org; Sun, 10 Feb 2019 20:47:02 +0100
Original-Received: from localhost ([127.0.0.1]:34787 helo=lists.gnu.org)
by lists.gnu.org with esmtp (Exim 4.71)
(envelope-from )
id 1gsv49-00087g-V4
for ged-emacs-devel@m.gmane.org; Sun, 10 Feb 2019 14:47:01 -0500
Original-Received: from eggs.gnu.org ([209.51.188.92]:38650)
by lists.gnu.org with esmtp (Exim 4.71)
(envelope-from ) id 1gsv43-00087Z-GN
for emacs-devel@gnu.org; Sun, 10 Feb 2019 14:46:56 -0500
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from ) id 1gsv42-0003XU-Kz
for emacs-devel@gnu.org; Sun, 10 Feb 2019 14:46:55 -0500
Original-Received: from mail-ot1-x342.google.com ([2607:f8b0:4864:20::342]:41073)
by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
(Exim 4.71) (envelope-from )
id 1gsv3r-0003RE-P2; Sun, 10 Feb 2019 14:46:46 -0500
Original-Received: by mail-ot1-x342.google.com with SMTP id u16so14152231otk.8;
Sun, 10 Feb 2019 11:46:35 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=mime-version:references:in-reply-to:from:date:message-id:subject:to
:cc; bh=Kv2tNMGo/H3CFBrs9Ej2J2GJA0tDQOtDzqXo9H29xOA=;
b=lFM05zhPLb5hYqYVOmsCDaGipaBneFq8saC0X9FYjDbI8raXWCGf/J2qHhBe/+7cYd
bi6dAqYn5o8FYAMMlK8dBZt1ba/NuT4Fv7MPm08fX0LOQEfiucXjDJyRhU9nFZEeQdyf
lpMNXorf8hCCdTyHyFTdHuiGymZ9SjErJIfFGuIIxlpZnWLSR6f5NXB9HEm9fbQgsOeA
LUbTWyKBc+GDw8gPXgI8mNO/oyyvHOVUEsl9U0jb+1OA2q48P8P1kwuSy/OZUZMCky2h
NzrKeb7vIz/u8k8eZOzgtpnzLaOpHZMV5RcipQv4UcoYmSY8bdtHUTcwEo6eq5XU0mPP
GUig==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=Kv2tNMGo/H3CFBrs9Ej2J2GJA0tDQOtDzqXo9H29xOA=;
b=MIu5OViDOUaSr1oE0GWkV8Uf1/pf52Ad1YnqXPbIjrXZDkbshVq+ZZ5nfX4nSPdFVj
7TLWdOsPDyM/O0GZfX+mFzfU04wy9IHFHKyvztBN4VwPEm+tgpPaxrSwUZcSWHkY8E0b
mq+AKlrwOnx80aAemaM0tc8QA3gjvQ+Y7INvU/YQHRB+QijgsSZZG5J0JYnyOeyLdPlm
47NR3QUkllnhDmVVsk2HpZRJnulA9xbBKsIL321G0cPqzeXQe+lWsP1lfLPSRMW6z+MN
27/cE0eTvpgpRK5T5ltq1/2Z+YdQBsZaqCtSHcvjLK0of4fOucCP+5xL3NqzYkBIfbWS
8NBg==
X-Gm-Message-State: AHQUAuafiIgzyYvwwJAQSr0cEQLTVjMiGJr1nV21uyfpxJ4HkQJ1ESfi
GqRXRe79r+vpH7C+bk6qaAJVA+f7i3tTF66EIXvYCQ==
X-Google-Smtp-Source: AHgI3IbDTmUniqMb7L0M7PnkfJs9jAIT5KDbxFf2abbLxmOc3/dwcp3tApk2gPPC6aKqkKTz6lvKTIRTCxMond3cZ+Y=
X-Received: by 2002:a9d:734e:: with SMTP id l14mr23012969otk.270.1549827994139;
Sun, 10 Feb 2019 11:46:34 -0800 (PST)
In-Reply-To: <834l9bmnyc.fsf@gnu.org>
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
recognized.
X-Received-From: 2607:f8b0:4864:20::342
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions."
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel"
Xref: news.gmane.org gmane.emacs.devel:233203
Archived-At:
Am So., 10. Feb. 2019 um 20:41 Uhr schrieb Eli Zaretskii :
>
> > From: Philipp Stephani
> > Date: Sun, 10 Feb 2019 19:49:39 +0100
> > Cc: Emacs developers , Philipp Stephani
> >
> > > Bother. I see your point regarding the return value when just
> > > pending_signals is set, but disregarding pending_signals doesn't sound
> > > TRT to me, either. It means various Emacs features based on input
> > > detection won't work while the module code runs, even if the module
> > > tries to be nice and does call module_should_quit. For example,
> > > while-no-input and atimers won't work, and Emacs will generally be
> > > much less responsive to user input.
> > >
> > > So maybe we should indeed return true only if QUITP says so, but we
> > > should also call process_pending_signals from module_should_quit, when
> > > pending_signals is non-zero?
> >
> > Wouldn't that mean that Emacs could do something (e.g. process
> > events)? That wouldn't match the naming and intention of should_quit:
> > By its name, it should only query information and not change any
> > state.
>
> If the only problem is the name, we could change the name. Or we
> could introduce a new function. But let's first agree about the
> substance: a well-behaving module should from time to time call
> process_pending_signals. Agreed?
Yes, absolutely. We can't change the name (this would break backwards
compatibility), but introducing a new function would be fine.
For should_quit itself, I still think we should make the change in
this patch. The current code is clearly buggy: it promises to quit but
doesn't in most cases.