From mboxrd@z Thu Jan 1 00:00:00 1970
Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail
From: Philipp Stephani
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] Allow inhibiting 'auto-save-visited-mode' on a per-buffer
basis.
Date: Sat, 11 Apr 2020 18:57:20 +0200
Message-ID:
References: <20200401175736.203124-1-phst@google.com> <83wo6yxb0s.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202";
logging-data="80948"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: Philipp Stephani , Eli Zaretskii ,
Emacs developers
To: Stefan Monnier
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 11 18:58:20 2020
Return-path:
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.92)
(envelope-from )
id 1jNJSV-000Kyx-L6
for ged-emacs-devel@m.gmane-mx.org; Sat, 11 Apr 2020 18:58:19 +0200
Original-Received: from localhost ([::1]:53710 helo=lists1p.gnu.org)
by lists.gnu.org with esmtp (Exim 4.90_1)
(envelope-from )
id 1jNJSU-0000KX-Ku
for ged-emacs-devel@m.gmane-mx.org; Sat, 11 Apr 2020 12:58:18 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53968)
by lists.gnu.org with esmtp (Exim 4.90_1)
(envelope-from ) id 1jNJRr-0008Kz-Gg
for emacs-devel@gnu.org; Sat, 11 Apr 2020 12:57:40 -0400
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from ) id 1jNJRq-0000fi-FF
for emacs-devel@gnu.org; Sat, 11 Apr 2020 12:57:39 -0400
Original-Received: from mail-ot1-x341.google.com ([2607:f8b0:4864:20::341]:39907)
by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
(Exim 4.71) (envelope-from )
id 1jNJRl-0000eX-50; Sat, 11 Apr 2020 12:57:33 -0400
Original-Received: by mail-ot1-x341.google.com with SMTP id x11so4871692otp.6;
Sat, 11 Apr 2020 09:57:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=mime-version:references:in-reply-to:from:date:message-id:subject:to
:cc; bh=FOFC7rTV0eZHAAghJOvJvtoxhto3L0Tgu6WyK8sGjsg=;
b=Ng5I/A/uEQK5bSf2A1p/3YPTgO9CZlCNTw1MsUBx0Cp7gERZGpV9hA6BJQkDYWvOyI
WltZF20+cpTbUNXEw8B2sqkHLOivTTYfsvv8aaQg2p50JKDCHbzleiLycIix8nbrl5BN
gUnWpApLP1TAan5+5k1WQ6KuRZKFqnc/cn+JH2ki1RDMj6hDYon7e1iXY+vfhPe7Mu4t
cAOHL5/ax8VHp4V1kzobeprCDEZ7EFBiLGklbi6MjNeXZUqogJtXZ+8g1+n7twzF3cgQ
osgmvYs3boFzaaPB1wr3kkGIQ28EyWLiHXK7tPJOPMM1Xh/9p4jzaCL9xqbCDHuKOpyg
PvSA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=FOFC7rTV0eZHAAghJOvJvtoxhto3L0Tgu6WyK8sGjsg=;
b=VE2N9Qnw1ubziUliw1mtz9qC40W4lQjw9PSWT6L9bzJwtZbo4OuxYjCzmg+TkLvtNa
xiaChx2xeD5XbxJ6rN9qNP8afhHiwBoTg4HvEvClO++oTui8OjlnD/edYfgvB2rV6c7b
GoTdN8CQHZXrzCCp32E8tTUzbl04691owOjEXtfO8SfAwk+YeEkZcyk7qJNZVA7JQIDb
sPCrfLw26w7ne3PDesJNySoovdt9m+CNBEW49FgjEhQZPmAlINvAzBBJGQPRdoj3ITqS
hqxdP4pcIASSFmvlBh63tx53nk6mUgOMMLRl0a2jIp6kU0Ti3sSYuRELfwAr0i6AmVtI
dV8g==
X-Gm-Message-State: AGi0PuYWSTBJBAqiYzcSc9mqL1qdkkK4JqZUOJrc9J2swu5MUINeoarN
Kh/YWJk9bqIFuQANukabfBDTeHBfV1OeZhvs2Mk=
X-Google-Smtp-Source: APiQypJQIWFE2hT/bacOcP4zm5W/Q3x71mlv5mpkqldehjnw1cEraMD+dxTg2r4mtKJi4Pbo8knpKNuB8TUSgSp3vq0=
X-Received: by 2002:a9d:2948:: with SMTP id d66mr6226920otb.174.1586624252057;
Sat, 11 Apr 2020 09:57:32 -0700 (PDT)
In-Reply-To:
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
recognized.
X-Received-From: 2607:f8b0:4864:20::341
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions."
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
Xref: news.gmane.io gmane.emacs.devel:246840
Archived-At:
Am Mi., 8. Apr. 2020 um 16:58 Uhr schrieb Stefan Monnier
:
>
> > How strongly do people feel about having a minor mode for this? If not
> > too strongly, I'd go ahead with my original proposal, which is simpler
> > implementation-wise.
>
> I don't think you can do much simpler than the patch I sent and it lets
> users inhibit the mode in those mode where they don't want it with:
>
> (add-hook 'foo-mode-hook
> (lambda () (setq-local auto-save-visited-mode nil)))
>
> and it's "compatible" with a future addition of an actual minor mode.
> As mentioned, having such "redundant checks" is common practice for
> minor modes.
>
Didn't we already discuss this above? It's against our own
recommendations for minor modes, so we shouldn't put it into the Emacs
codebase itself.
Unless I hear strong objections, I'll push my original approach in a few days.