From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#34655: 26.1.92; Segfault in module with --module-assertions Date: Thu, 21 Mar 2019 17:11:41 +0100 Message-ID: References: <874l8r1t3a.fsf@tcd.ie> <8336oamu3y.fsf@gnu.org> <87h8c1cv6l.fsf@tcd.ie> <83lg1dwhse.fsf@gnu.org> <87va0h12js.fsf@tcd.ie> <835zsgw3ui.fsf@gnu.org> <87ef7486h0.fsf@tcd.ie> <83r2b4ul1c.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="37891"; mail-complaints-to="usenet@blaine.gmane.org" Cc: "Basil L. Contovounesios" , 34655@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 21 17:27:19 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h70XH-0009kD-3s for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Mar 2019 17:27:19 +0100 Original-Received: from localhost ([127.0.0.1]:41624 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h70XG-0005XD-30 for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Mar 2019 12:27:18 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41229) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h70Uo-0003WP-OA for bug-gnu-emacs@gnu.org; Thu, 21 Mar 2019 12:24:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h70IW-0007HC-7A for bug-gnu-emacs@gnu.org; Thu, 21 Mar 2019 12:12:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39885) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h70IU-0007Eb-AJ for bug-gnu-emacs@gnu.org; Thu, 21 Mar 2019 12:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h70IU-0000EQ-0q for bug-gnu-emacs@gnu.org; Thu, 21 Mar 2019 12:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Mar 2019 16:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34655 X-GNU-PR-Package: emacs Original-Received: via spool by 34655-submit@debbugs.gnu.org id=B34655.1553184721883 (code B ref 34655); Thu, 21 Mar 2019 16:12:01 +0000 Original-Received: (at 34655) by debbugs.gnu.org; 21 Mar 2019 16:12:01 +0000 Original-Received: from localhost ([127.0.0.1]:53429 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h70IS-0000EB-Ig for submit@debbugs.gnu.org; Thu, 21 Mar 2019 12:12:00 -0400 Original-Received: from mail-oi1-f182.google.com ([209.85.167.182]:35043) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h70IR-0000Dz-FD for 34655@debbugs.gnu.org; Thu, 21 Mar 2019 12:11:59 -0400 Original-Received: by mail-oi1-f182.google.com with SMTP id j132so5085457oib.2 for <34655@debbugs.gnu.org>; Thu, 21 Mar 2019 09:11:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=1AWlZmfqcS+Zl+6AIvRddL5CZP2ZXjFYh0n7zCMs8T0=; b=JRND/BRcVK37amC8RKXaQ+kTANI2NUcL8hcgWQ53hI2yEVEExbfaxBcy6fZqPqgYie o97GRU7dmPcw8+8ESczRlc02hJgBS4GhIbTp+aRrD9iOt6h7s7Ps8ZKk7SN7Pe224yrt aujtxGYK5GQWq3yxgZRAIkLiWE33QY5dQRon5Yzio3lXITVJoaD02lH56erBLTLOTwm2 hZNeklU/L5SnhOWOGRo3BTRFKNlUUuRE5/wzXRnaDdavthinvFC26Q+2EWAORTKX4Tsy SVqbVlzQ4r0cWWBySgY+piIDcFcJkLtCMHqEsJLsVw+aYrD/gNY9Hw4fryzJGSH/AHBd Jy3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=1AWlZmfqcS+Zl+6AIvRddL5CZP2ZXjFYh0n7zCMs8T0=; b=JHMqbPAye8De7jrnu3gpzYXZOiZ/RR3oWAr3uHxIe6gdxJwsd9mNydUQ8V+jn6HE9g p+JtjjPfONlQy7omgPbH8TfCRJugufNSBlnU8FdjBsBYTlDcSQRK2svjxSDSyphoV/Ca VORUmwi7ekb99JWMJX9yL5EtQO1BzOTm4d6Xae3ZuFRYqxsi2EUmCBTWlaTnf1Ee31tO DXloC0gRyy8/0f0nu1/h3U+HhxCJdNHyXbX3nj6Z27mg45huqMYVkj774GY2Z7HXuDdW 9ugDFfWWKtiprULJOIc/2wq44gPkmRt3gb2LwYbTX8XYrK1TuB1KJvRDc3KCwoOKLs/o V2kA== X-Gm-Message-State: APjAAAWZFYrm0i/psfR304O0WU6NnQaHlSMRthxRlvYnUy3Msn/Cp5zA joi30UkDD9XEyxOb0fI/J/mlA1gNZplhM4mtSHM= X-Google-Smtp-Source: APXvYqyrTBlQJOmA9ePo3PO9p8hJiW3FFATpSmzIPc41H5rgih3XAKGmiiVh66YDNcKnAws1U1DQ/qZbdnTled34XFg= X-Received: by 2002:aca:310a:: with SMTP id x10mr4604oix.161.1553184712048; Thu, 21 Mar 2019 09:11:52 -0700 (PDT) In-Reply-To: <83r2b4ul1c.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156570 Archived-At: Am Mo., 18. M=C3=A4rz 2019 um 18:53 Uhr schrieb Eli Zaretskii : > > > From: "Basil L. Contovounesios" > > Cc: <34655@debbugs.gnu.org>, > > Date: Mon, 18 Mar 2019 16:58:35 +0000 > > > > Eli Zaretskii writes: > > > > > The patch to fix this is below; it simply marks these copied values b= y > > > hand, thus preventing them from being GCed. It ran successfully with > > > even 50,000 iterations. > > > > I can confirm that your patch fixes the issue. > > Great, thanks for testing. > > > I am very grateful not only for your looking into this, but also for > > taking the time to explain the whole process; it has been enlightening > > and would have taken me a lot of time to figure out alone. > > You are welcome. > > I will wait for a few days to give Philipp and others a chance to > comment, and push then if no one comes up with objections. I haven't checked everything in detail, but my impression is that this is rather another instance of bug#31238. Fixing this only when module assertions are enabled will probably not fix anything, but rather mask issues. Reverting commit 3eb93c07f7a60ac9ce8a16f10c3afd5a3a31243a is still the right approach here. Can you please hold off a bit? I've almost completed the revert, but haven't pushed it yet. Once that's in we can check whether it also fixes this issue. Thanks!