From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Accept plists when serializing and parsing JSON Date: Sat, 2 Jun 2018 18:46:35 +0200 Message-ID: References: <87sh6awls5.fsf@gmail.com> <83o9gug811.fsf@gnu.org> <87d0xaozl1.fsf@gmail.com> <83sh65ef6w.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000005bfebb056dab72e4" X-Trace: blaine.gmane.org 1527957897 11772 195.159.176.226 (2 Jun 2018 16:44:57 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 2 Jun 2018 16:44:57 +0000 (UTC) Cc: joaotavora@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 02 18:44:53 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fP9e6-0002sZ-H5 for ged-emacs-devel@m.gmane.org; Sat, 02 Jun 2018 18:44:50 +0200 Original-Received: from localhost ([::1]:60420 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fP9gD-0008CD-Mv for ged-emacs-devel@m.gmane.org; Sat, 02 Jun 2018 12:47:01 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33779) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fP9g4-0008C8-Ak for emacs-devel@gnu.org; Sat, 02 Jun 2018 12:46:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fP9g3-0006AJ-EF for emacs-devel@gnu.org; Sat, 02 Jun 2018 12:46:52 -0400 Original-Received: from mail-ot0-x242.google.com ([2607:f8b0:4003:c0f::242]:44120) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fP9g2-00066J-1H; Sat, 02 Jun 2018 12:46:50 -0400 Original-Received: by mail-ot0-x242.google.com with SMTP id w13-v6so5393717ote.11; Sat, 02 Jun 2018 09:46:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cH0M+dDN2EioHSr2jLSTpcRICYgcpj6PjxJOmQTRJiM=; b=jkTwe1JxvcN3wzB6yJmIBDH3wWEJlc67oRmsOFWFMtBsz+Qrk66oExCJPliIsyvmp2 bAg8hMg4Oo8/wOkkpOEF4B3ZwMAnFqAVHmuDOF3tu22lmE2F1vxgGj/Hg/FPX0ugTmcA ELkv6l+V4LeK86btkJf7TKKUX3Xpo706EcmxQU5SePii9xrgWY9jmHhe91b3M0ks0Ptk zaWpzbHmplF5i/OGTRgWL3Rz1MY/L7pFlmILVbsXF9xl49o3M6eCfmubyNDsKcvEYvhM PI/MZpjsPr/a3h9vepICCl7jp3Wwc9M63kDqxlF4nCuDQvecZ3789BUaSdBHBjujaJkf mahA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cH0M+dDN2EioHSr2jLSTpcRICYgcpj6PjxJOmQTRJiM=; b=oqAD6EobYs80+agFOZs7R/cfZuijOv9k76HqCYJEFBKRudW55sc2fhSU0pVfLMXfbf cCueJezM12ReUXJVPyNvuRJBv2o6l1vyDNarLSb/kC7Wqs7M3zaY4h2oYy2tPc97QLe2 sPajPDGrWtCUjHaURhTxLXaCdg7Fp0j9GHTdN157+ehh0Xuw1sfloGXx8yJiNOscqrQ5 0UTowlD0utgFCksyTdwxESeVo2RBK7GxfM80IGCaC69bDa2gF90BLqRMN9DVhgqoXrrS 4m2dCtMwE4ZeV0+5ePE05cynTc+BlE7nlFYkqjtlGWBcjEBGBopcsBiH3tNXvznqNnpC 6ZFw== X-Gm-Message-State: ALKqPwcEoSL7feM2M5vgZq1RW9rGB6Cu2Df9qyLSmYndZ7CoUmeI7r37 n0hQvdHDxOd4JM7nWmLxM6OboWRQ+s2jtWWqjFcc2A== X-Google-Smtp-Source: ADUXVKLI6qKI1c1SbmWTj1+1UEjcTnwECFaW8vKZmfFP3006OIORjyvZiyXddeFe0m0M+eYk4o+LYnrREYIguqqoanA= X-Received: by 2002:a9d:2e68:: with SMTP id c37-v6mr9710501otd.276.1527958009018; Sat, 02 Jun 2018 09:46:49 -0700 (PDT) In-Reply-To: <83sh65ef6w.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c0f::242 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:225925 Archived-At: --0000000000005bfebb056dab72e4 Content-Type: text/plain; charset="UTF-8" Eli Zaretskii schrieb am Sa., 2. Juni 2018 um 11:00 Uhr: > > From: Philipp Stephani > > Date: Sat, 2 Jun 2018 10:24:20 +0200 > > Cc: Eli Zaretskii , emacs-devel@gnu.org > > > > +see. The returned object will be a vector, hashtable, alist, or > > +plist. Its elements will be `:null', `:false', t, numbers, strings, > > > > Nit: you're using Oxford commas inconsistently. I'm fine either way, but > please stay consistent. > > I see nothing inconsistent here, FWIW. Maybe I, too, need to be > educated. > >From the beginning of the patch: + Lisp hashtables, alists or plists (i.e. no Oxford comma) Then later: +see. The returned object will be a vector, hashtable, alist, or +plist. Its elements will be `:null', `:false', t, numbers, strings, (i.e. Oxford comma) There are some other inconsistencies. This is obviously extremely minor. --0000000000005bfebb056dab72e4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Eli Za= retskii <eliz@gnu.org> schrieb am= Sa., 2. Juni 2018 um 11:00=C2=A0Uhr:
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Sat, 2 Jun 2018 10:24:20 +0200
> Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
>
> +see.=C2=A0 The returned object will be a vector, hashtable, alist, or=
> +plist.=C2=A0 Its elements will be `:null', `:false', t, numbe= rs, strings,
>
> Nit: you're using Oxford commas inconsistently. I'm fine eithe= r way, but please stay consistent.

I see nothing inconsistent here, FWIW.=C2=A0 Maybe I, too, need to be
educated.

From the beginning of the pat= ch:

+ Lisp hashtables, alists or plists
=
(i.e. no Oxford comma)

Then later:<= /div>

+see.=C2=A0 The returned object will be a vec= tor, hashtable, alist, or
+plist.=C2=A0 Its elements will be `:nu= ll', `:false', t, numbers, strings,

= (i.e. Oxford comma)

There are some other inconsist= encies.

This is obviously extremely minor.
=C2=A0
--0000000000005bfebb056dab72e4--