From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#28258: 26.0.50; [PATCH] Let file-name-base succeed when buffer-file-name is nil Date: Sun, 24 Sep 2017 08:07:18 +0000 Message-ID: References: <87k21o8m8x.fsf@rose> <1188947996.68721.1504023031457@webmail.mailhostbox.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a113ca93aea468e0559eaeef3" X-Trace: blaine.gmane.org 1506240491 17383 195.159.176.226 (24 Sep 2017 08:08:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 24 Sep 2017 08:08:11 +0000 (UTC) Cc: Mohammed Sadiq To: Glenn Morris , 28258-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 24 10:08:07 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dw1xM-00048H-LA for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Sep 2017 10:08:04 +0200 Original-Received: from localhost ([::1]:37245 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dw1xU-0003U1-0y for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Sep 2017 04:08:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36173) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dw1xN-0003TX-NL for bug-gnu-emacs@gnu.org; Sun, 24 Sep 2017 04:08:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dw1xK-0004rU-Bd for bug-gnu-emacs@gnu.org; Sun, 24 Sep 2017 04:08:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46462) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dw1xK-0004rN-81 for bug-gnu-emacs@gnu.org; Sun, 24 Sep 2017 04:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dw1xK-0006qW-2E for bug-gnu-emacs@gnu.org; Sun, 24 Sep 2017 04:08:02 -0400 Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Sep 2017 08:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 28258 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 28258@debbugs.gnu.org, p.stephani2@gmail.com, sadiq@sadiqpk.org Original-Received: via spool by 28258-done@debbugs.gnu.org id=D28258.150624045626279 (code D ref 28258); Sun, 24 Sep 2017 08:08:01 +0000 Original-Received: (at 28258-done) by debbugs.gnu.org; 24 Sep 2017 08:07:36 +0000 Original-Received: from localhost ([127.0.0.1]:55141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dw1wu-0006pn-BV for submit@debbugs.gnu.org; Sun, 24 Sep 2017 04:07:36 -0400 Original-Received: from mail-oi0-f51.google.com ([209.85.218.51]:46304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dw1ws-0006pZ-Ny for 28258-done@debbugs.gnu.org; Sun, 24 Sep 2017 04:07:35 -0400 Original-Received: by mail-oi0-f51.google.com with SMTP id a74so3360912oib.3 for <28258-done@debbugs.gnu.org>; Sun, 24 Sep 2017 01:07:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qLgZQc6mp/75OxWmnkebCmp79MpdSb0HPSQmLdllkV0=; b=JAgjS5heG+DGkx9iT1HD9CxcBUQ9c3AVfR0rQ4OXjeFEyyOeQ+scTPmLxZMbll9Acq 0r5XyQgBYyx3CM4Eenj3bFYP6OD4SHBjblXNh4mDdQDT82Px/vvIvxmGBVXbeyg9YxYC 6VGEnAbrcgV63dj6xJ1efoUwz3G5HiCiQxnyAu9Q9o8lbNpNgNHlyFcz0pPldaRzlWDO b3vPG6q9UwT+ccqFmCHRtFGdfxfSPI3qa0iQO9raUzjjy4GQnIyJs/YJpak6x89TYGjp RBJWE9l1ylBMbBxBn4133kzc3Z0AZrrcwfG8KEbvJ9WcAvO7QFtHfxiW5qHrU+BITt0D DkPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qLgZQc6mp/75OxWmnkebCmp79MpdSb0HPSQmLdllkV0=; b=DsHVPFq+vHBHnmYtkuhS2rPBSXoGV0ivlbE21jgunGbnCweuGAt1PjOPk62zqcu4g3 QbiLmOxzMozBqzK+UuzhEbOsB4FcKfg6cBG5MQwJzRvvkHUnpksVXZaN1K+xNyFwtLZ6 YkLDlcVnADi4OzHbDljLKLBI7f9E0scMzhQvhTUIvpwtW++Xwe+8RkJg9IXB3qc5ULx2 73JQX+1Y9PnooqgwF/07G6F1r6WaiYoK3gllqKKAwYcbEOKX4FB9F6kx3/M7yoCitjjH PPQeD7RjRfNXMlmAl2c7g1lZk/1YT9r2yaFzTStSHpiRmsHirdDCxMDnBvMrNaYk0dfJ UTBA== X-Gm-Message-State: AHPjjUgdtVkhfNE1qJpw4J2dlM99yMVIuhovHEOzxOpA1lFbM8ywiHNs faWmMVNx3WdTIb8osQYVoVrYEpJ6pFctnmrsEkE= X-Google-Smtp-Source: AOwi7QDbkKZrKIqNh28Fy0lNyPxWpUeREZroabnzi9KhYzVxUqw9Im7AQNK9EGsJQZ7KiJQ229272ET5trx6im2U9+Q= X-Received: by 10.202.56.214 with SMTP id f205mr4020247oia.316.1506240449102; Sun, 24 Sep 2017 01:07:29 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137325 Archived-At: --001a113ca93aea468e0559eaeef3 Content-Type: text/plain; charset="UTF-8" Philipp Stephani schrieb am Di., 19. Sep. 2017 um 10:46 Uhr: > Philipp Stephani schrieb am Di., 19. Sep. 2017 um > 10:31 Uhr: > >> Glenn Morris schrieb am Di., 19. Sep. 2017 um 02:41 Uhr: >> >>> >>> > I do agree that the calling convention of `file-name-base' is odd. How >>> > about making the argument mandatory (initially only by changing the >>> > advertised calling convention and the docstring)? >>> >>> Sounds good to me. >>> >> >> OK, here's a patch. >> > > New version of the patch, with all callers and the manual fixed. > Pushed to master as 1eb4e5c3c8. --001a113ca93aea468e0559eaeef3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Philip= p Stephani <p.stephani2@gmail.c= om> schrieb am Di., 19. Sep. 2017 um 10:46=C2=A0Uhr:
Philipp Stephani <p.stephani2@gmail.com> schrieb am Di., 19. Sep. 2017= um 10:31=C2=A0Uhr:
Glenn Morris <rgm@gnu.org> schrieb am Di., 19= . Sep. 2017 um 02:41=C2=A0Uhr:

> I do agree that the calling convention of `file-name-base' is odd.= How
> about making the argument mandatory (initially only by changing the > advertised calling convention and the docstring)?

Sounds good to me.

OK, here's a patch.=C2=A0

New version of the patch, with all callers and the ma= nual fixed.=C2=A0

Pushed = to master as 1eb4e5c3c8.=C2=A0
--001a113ca93aea468e0559eaeef3--