From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 2/2] Add module functions to convert from and to big integers. Date: Wed, 13 Nov 2019 13:46:20 -0500 Message-ID: References: <20190423131742.65814-1-phst@google.com> <20190423131742.65814-2-phst@google.com> <102dc3dc-554c-a55e-ae7c-cc7357ee60f5@cs.ucla.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="236000"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Philipp Stephani , Paul Eggert , Emacs developers To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 13 19:48:44 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iUxh6-000zBo-7L for ged-emacs-devel@m.gmane.org; Wed, 13 Nov 2019 19:48:44 +0100 Original-Received: from localhost ([::1]:50088 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUxh4-0000TN-Re for ged-emacs-devel@m.gmane.org; Wed, 13 Nov 2019 13:48:42 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39514) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUxf3-0007Iz-Ib for emacs-devel@gnu.org; Wed, 13 Nov 2019 13:46:38 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iUxf2-0007pP-IH for emacs-devel@gnu.org; Wed, 13 Nov 2019 13:46:37 -0500 Original-Received: from mail-oi1-x241.google.com ([2607:f8b0:4864:20::241]:38014) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iUxf2-0007oh-9j for emacs-devel@gnu.org; Wed, 13 Nov 2019 13:46:36 -0500 Original-Received: by mail-oi1-x241.google.com with SMTP id a14so2760603oid.5 for ; Wed, 13 Nov 2019 10:46:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gg6EvbL5mqHPI3BjliGYgJqDApuuLXD939IzYqlZjrA=; b=W+rifGZ1ioiWWfYHEQqtuP9St7/rb4dGsxbKZoCnwD/yt5mQr2q0o0zMJSR5aed5pT tkldF4GgU0WHYrR/G/2uBbKmW8eVn/mYBKDRPSCqun1REZ3b8GqoaUfnarXAwNJo4g0D /Pu50ppq4jrvQgbQkSxUsKj1D5f/FGvYt9USei1dzaPI96OwWMxVdyToUPFbs12+RhvD 6W1Vyi5SJtj1xwVX7lq5sSyoo6HhN9Noan+6Mq2aRVzfzkDqVuO7gY+domffhurdH+0+ kbIV1zyphDdv9bKU/1hSprroVJuXPvQnPhVe6NNZ/XZqmeHOIDPbkhBmA2ikMTacb9gq G2PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gg6EvbL5mqHPI3BjliGYgJqDApuuLXD939IzYqlZjrA=; b=uQMj9fr7VP7IA1zxsEL9jZ7BFTDVLSKrsTmO6jsgRD9bnBirlGQXrcWL6g/XWd+KUf piytHUiUoHiTKWXc9Fjr/dNV+UrOddW73l1ZpBa5RhD+L23o5kKwnmKN5UvSB+DLwztw fN1Rgc1KVrJjgDbOPEIdEpo6ou9mgMV16f4mT5b3BnoujlPEuyTEtlFCGQrRoI8OtOld ZOvg9whjzUaVHtsU4PH6IHlaeeLEg6aW9YuK2pc1MkK4s6P1tYVwgpjHNzb41Qxt7OFu kgw4z+LnAPFt3LWp50rr1NbOaVAm420045rwGLmCChFIQ8G/sbC/UH8/bq/NgpP7VTNs YBCw== X-Gm-Message-State: APjAAAX5WmJaXs24VJdVLRl2fHslGIaM3IFeGzccE0o4opFEY2XuNZMP GE/ij3YUoMp4fBC6A1eo52v8wKsOP9zq5E68o3c= X-Google-Smtp-Source: APXvYqw7RPs3gkFLdrYhpvLi9bkW6PQf+WSB+J6tjUtuhb7Pt+6ZEvoPMkmI15kHahWn62MuNYUd9pF+Loo1+dvOYIc= X-Received: by 2002:aca:c64c:: with SMTP id w73mr22102oif.161.1573670791468; Wed, 13 Nov 2019 10:46:31 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::241 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:242126 Archived-At: Am So., 3. Nov. 2019 um 14:38 Uhr schrieb Stefan Monnier : > > > Overall I now think the original approach (without mpz_t) is quite > > superior, and unless I hear convincing counterarguments, I'll send a > > patch to revert to that. > > FWIW, I agree. The main argument for me is the fact that it exposes an > internal implementation detail whereas the module interface makes a lot > of effort to hide all implementation details (even the representation > of Lisp_Object!). > SG, I'll send the patch once I find the time to do so ;-) Since this a breaking change, I'd request not releasing any pretests until the patch is in.