From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: What's the line length limit in the Emacs codebase? Date: Sat, 26 Dec 2020 12:02:09 +0100 Message-ID: References: <83wnx8pm0e.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20724"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Emacs developers To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Dec 26 12:03:22 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kt7M2-0005KY-Cg for ged-emacs-devel@m.gmane-mx.org; Sat, 26 Dec 2020 12:03:22 +0100 Original-Received: from localhost ([::1]:46840 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kt7M1-0002vK-EB for ged-emacs-devel@m.gmane-mx.org; Sat, 26 Dec 2020 06:03:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56480) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kt7LA-0002VU-84 for emacs-devel@gnu.org; Sat, 26 Dec 2020 06:02:28 -0500 Original-Received: from mail-ot1-x330.google.com ([2607:f8b0:4864:20::330]:42770) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kt7L4-00069R-VD; Sat, 26 Dec 2020 06:02:27 -0500 Original-Received: by mail-ot1-x330.google.com with SMTP id 11so5327134oty.9; Sat, 26 Dec 2020 03:02:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WVmIfFO4GUN1Y2Xlc1BWs/EVI65Wq5Iada0zeb9rJSs=; b=cuFfZSpQKt+CPFeLhWim7W9L3RHtOcMbQSgmr8y+V2LCapBKshcRVDOXanWZSEayFz VjPIKnNmpwskiE129lV02HrhLLLGKo6SZySjkg/jfvnCxChFolyk8ICdOhGo7yGEChFj F4iFUnU1yEosmrILEVRN+nOg2LesSyRTsfNUsHLuNG15TpZvuaGxv9TJRMH22yCW45Ls 1Ol7T8BWzOGvHAEKD9x8/bLboeCKtfgBMh9afwl+t5r2Qkyfc2OInXM1TbA5JBfLayjb PTl448+jJ9MtuwIq8e83d0yL2GxpBmLBMonJFY0YxPvKkNmyf5V46ma3hUJ9nVnCc+Xk 0gUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WVmIfFO4GUN1Y2Xlc1BWs/EVI65Wq5Iada0zeb9rJSs=; b=Ae3khI0X04fAoBjcKWdzWuksyh+tfjMxsgawrqLu+0r/LsOfs1db7Ve4WoIGUdMsB9 32r4724oPNm3KB5iFGQBKy1+7ysx5ttKjR/Z916KrV+q7/YMKx1ZRADIMp6gNWQ7lv54 /GZZkokU3eQuYfsAyykqqpk1a0yFx8p8C3mSjhrNj6ydjF7+KJcCBwNXs+Nl5N+XP1Tc WAbZ+DbE+TVmm9adjiWwfscJZl3XfTxgnj35zdT+iA1MuPjqQ7e7PvwM+TDkka6HBPOt MxX/mr3Xe+V2LP4VV5G2g4jCRma1RCmZWZfmM8v8boIc+DWqU2/KzSPS4y1wdRF50BKT 6PCQ== X-Gm-Message-State: AOAM530MKbur3WV/nST/Gp9XWPgSsYE2YVLssnWJbxdr/0frFZUOT3UL ggF0yE7YoSWSjXs7n7UcXXIGAgi/usuJIUOa95UQisEA6S8= X-Google-Smtp-Source: ABdhPJynBs8FiIt0TkA+m1LAuftU5s+iwKzHzRr/cvi5B2UzCzDmFrwfDk6CERTUcGvt7FyheZnOVhB4qa25sz9Podw= X-Received: by 2002:a9d:269:: with SMTP id 96mr27441800otb.174.1608980540646; Sat, 26 Dec 2020 03:02:20 -0800 (PST) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::330; envelope-from=p.stephani2@gmail.com; helo=mail-ot1-x330.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:261831 Archived-At: Am Fr., 25. Dez. 2020 um 18:43 Uhr schrieb Stefan Monnier : > > > This seems overly complicated, and people are unlikely to follow > > complicated rules. > > I don't think there is a need for a simplistic rule that is > strictly enforced. Where have you seen such a need? Nowhere, it's more of a question. I don't intend to introduce a strictly enforced rule, but just having a statement saying "stay within 70 columns until there are good reasons (mostly long URLs) otherwise" would provide some guidance to people editing the codebase. > > IOW, I'm not sure what problem you're trying to solve. Line length is a typical bikeshedding problem that's best solved by picking a number and then sticking to it. > > AFAIK we already enforce the complicated rule discretely by setting > `fill-column` to 70 in `.dir-locals.el` and by re-wrapping or > complaining about lines that pass the 80-column limit. > We could then change the complaining/re-wrapping to start at 71 columns and would achieve the same effect. I don't think we need to change too much here, maybe nothing at all: let's just use the 70-column limit more consistently from now on in new/changed code.