From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: Reporting Lisp errors in dynamic modules Date: Fri, 27 Nov 2015 18:40:39 +0000 Message-ID: References: <83egfbsnu2.fsf@gnu.org> <83zixzqr32.fsf@gnu.org> <83vb8nqpmf.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a114b07d4bf0eeb05258a0769 X-Trace: ger.gmane.org 1448649669 13417 80.91.229.3 (27 Nov 2015 18:41:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 27 Nov 2015 18:41:09 +0000 (UTC) Cc: aurelien.aptel+emacs@gmail.com, tzz@lifelogs.com, dancol@dancol.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 27 19:41:02 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a2Nwz-0002z9-CF for ged-emacs-devel@m.gmane.org; Fri, 27 Nov 2015 19:40:53 +0100 Original-Received: from localhost ([::1]:58149 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2Nx2-0006mr-5V for ged-emacs-devel@m.gmane.org; Fri, 27 Nov 2015 13:40:56 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36092) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2Nwy-0006ml-JU for emacs-devel@gnu.org; Fri, 27 Nov 2015 13:40:53 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a2Nwx-0005EA-QF for emacs-devel@gnu.org; Fri, 27 Nov 2015 13:40:52 -0500 Original-Received: from mail-wm0-x229.google.com ([2a00:1450:400c:c09::229]:35590) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2Nww-0005Cx-4J; Fri, 27 Nov 2015 13:40:50 -0500 Original-Received: by wmuu63 with SMTP id u63so64693495wmu.0; Fri, 27 Nov 2015 10:40:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-type; bh=xUBi6Ujyiuo4WNmJhgFUyyb9AaGNWFP/8HtohCUsaAY=; b=Y3Z/WcHoSBEkG4oPZASki2AZJYVc5LjOMd3aodZne7LbqUBvFc0s9zC3sfP6abNxcg MeT0+dQ19IyXP2YMLRPCacwjpWwx2KL6xAWBinxtoDEbuKSaU0Q8MD6yd7EO5LqL0WyK Lm4ZIau1BsXhVra73jWhwLpnV0yQgb4Hyu8RJCgMT5Oh8751i8PhJF3G+V4fryow86uw oqIbLmEbMMLceNAqDPYXtcTZyEwqkofbjOhiNOBmc1uGxyQZERD5iyQ6g5wpzwdY+Hfz GzP9wSMlvHRTk8mVtUcVYFCNIxtuwPK+AdkzU7x0uAYpcqFMNnYp/tEzR/5UyaQstCYm UcbQ== X-Received: by 10.28.187.4 with SMTP id l4mr12249790wmf.33.1448649649215; Fri, 27 Nov 2015 10:40:49 -0800 (PST) In-Reply-To: <83vb8nqpmf.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c09::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:195407 Archived-At: --001a114b07d4bf0eeb05258a0769 Content-Type: multipart/alternative; boundary=001a114b07d4bf0ee505258a0767 --001a114b07d4bf0ee505258a0767 Content-Type: text/plain; charset=UTF-8 OK, here's a quick (untested, sorry) patch. Eli Zaretskii schrieb am Fr., 27. Nov. 2015 um 19:11 Uhr: > > From: Philipp Stephani > > Date: Fri, 27 Nov 2015 18:01:54 +0000 > > Cc: emacs-devel@gnu.org, aurelien.aptel+emacs@gmail.com, > tzz@lifelogs.com, > > dancol@dancol.org > > > > We could rename the function to "internal-module-call" to make it even > less > > likely to clash. > > Yes, I think renaming it, even to internal--module-call, is a must. > --001a114b07d4bf0ee505258a0767 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
OK, here's a quick (untested, sorry) patch.

Eli Zaretskii <eliz@gnu.org> schrieb am Fr., 27. Nov. 2015 um 19:11= =C2=A0Uhr:
> From: Philipp Steph= ani <p.stepha= ni2@gmail.com>
> Date: Fri, 27 Nov 2015 18:01:54 +0000
> Cc: emacs-dev= el@gnu.org, aurelien.aptel+emacs@gmail.com, tzz@lifelogs.com,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0dancol@dancol.org
>
> We could rename the function to "internal-module-call" to ma= ke it even less
> likely to clash.

Yes, I think renaming it, even to internal--module-call, is a must.
--001a114b07d4bf0ee505258a0767-- --001a114b07d4bf0eeb05258a0769 Content-Type: application/octet-stream; name="0001-Intern-module-call-but-rename-it.patch" Content-Disposition: attachment; filename="0001-Intern-module-call-but-rename-it.patch" Content-Transfer-Encoding: base64 Content-ID: <1514a3f37fc5c82af2b1> X-Attachment-Id: 1514a3f37fc5c82af2b1 RnJvbSAxNjkxNTk0MGU4MThiMmYxZGZjMGQ4YWE0ZjI5OTkwMWFhMGNmMzdlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwIFN0ZXBoYW5pIDxwaHN0QGdvb2dsZS5jb20+CkRh dGU6IEZyaSwgMjcgTm92IDIwMTUgMTk6Mzk6MjkgKzAxMDAKU3ViamVjdDogW1BBVENIXSBJbnRl cm4gYG1vZHVsZS1jYWxsJywgYnV0IHJlbmFtZSBpdC4KCi0tLQogc3JjL2VtYWNzLW1vZHVsZS5j IHwgMzYgKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdl ZCwgMTcgaW5zZXJ0aW9ucygrKSwgMTkgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2Vt YWNzLW1vZHVsZS5jIGIvc3JjL2VtYWNzLW1vZHVsZS5jCmluZGV4IGM3NWRkZWIuLjhhMGIwMmMg MTAwNjQ0Ci0tLSBhL3NyYy9lbWFjcy1tb2R1bGUuYworKysgYi9zcmMvZW1hY3MtbW9kdWxlLmMK QEAgLTIyMSw4ICsyMjEsOCBAQCBzdGF0aWMgdm9pZCBtb2R1bGVfd3JvbmdfdHlwZSAoZW1hY3Nf ZW52ICosIExpc3BfT2JqZWN0LCBMaXNwX09iamVjdCk7CiAvKiBBIGZ1bmN0aW9uIGVudmlyb25t ZW50IGlzIGFuIGF1eGlsaWFyeSBzdHJ1Y3R1cmUgdXNlZCBieQogICAgYG1vZHVsZV9tYWtlX2Z1 bmN0aW9uJyB0byBzdG9yZSBpbmZvcm1hdGlvbiBhYm91dCBhIG1vZHVsZQogICAgZnVuY3Rpb24u ICBJdCBpcyBzdG9yZWQgaW4gYSBzYXZlIHBvaW50ZXIgYW5kIHJldHJpZXZlZCBieQotICAgYG1v ZHVsZS1jYWxsJy4gIEl0cyBtZW1iZXJzIGNvcnJlc3BvbmQgdG8gdGhlIGFyZ3VtZW50cyBnaXZl biB0bwotICAgYG1vZHVsZV9tYWtlX2Z1bmN0aW9uJy4gICovCisgICBgaW50ZXJuYWwtLW1vZHVs ZS1jYWxsJy4gIEl0cyBtZW1iZXJzIGNvcnJlc3BvbmQgdG8gdGhlIGFyZ3VtZW50cworICAgZ2l2 ZW4gdG8gYG1vZHVsZV9tYWtlX2Z1bmN0aW9uJy4gICovCiAKIHN0cnVjdCBtb2R1bGVfZnVuX2Vu dgogewpAQCAtMjMxLDExICsyMzEsNiBAQCBzdHJ1Y3QgbW9kdWxlX2Z1bl9lbnYKICAgdm9pZCAq ZGF0YTsKIH07CiAKLS8qIFRoZSBmdW5jdGlvbiBkZWZpbml0aW9uIG9mIGBtb2R1bGUtY2FsbCcu ICBgbW9kdWxlLWNhbGwnIGlzCi0gICB1bmludGVybmVkIGJlY2F1c2UgdXNlciBjb2RlIGNvdWxk bid0IG1lYW5pbmdmdWxseSB1c2UgaXQsIHNvIGtlZXAKLSAgIGl0cyBkZWZpbml0aW9uIGFyb3Vu ZCBzb21ld2hlcmUgZWxzZS4gICovCi1zdGF0aWMgTGlzcF9PYmplY3QgbW9kdWxlX2NhbGxfZnVu YzsKLQogDAogLyogSW1wbGVtZW50YXRpb24gb2YgcnVudGltZSBhbmQgZW52aXJvbm1lbnQgZnVu Y3Rpb25zLgogCkBAIC0zOTEsMTIgKzM4NiwxMiBAQCBtb2R1bGVfbm9uX2xvY2FsX2V4aXRfdGhy b3cgKGVtYWNzX2VudiAqZW52LCBlbWFjc192YWx1ZSB0YWcsIGVtYWNzX3ZhbHVlIHZhbHVlKQog CQkJCSAgIHZhbHVlX3RvX2xpc3AgKHZhbHVlKSk7CiB9CiAKLS8qIEEgbW9kdWxlIGZ1bmN0aW9u IGlzIGxhbWJkYSBmdW5jdGlvbiB0aGF0IGNhbGxzIGBtb2R1bGUtY2FsbCcsCi0gICBwYXNzaW5n IHRoZSBmdW5jdGlvbiBwb2ludGVyIG9mIHRoZSBtb2R1bGUgZnVuY3Rpb24gYWxvbmcgd2l0aCB0 aGUKLSAgIG1vZHVsZSBlbWFjc19lbnYgcG9pbnRlciBhcyBhcmd1bWVudHMuCisvKiBBIG1vZHVs ZSBmdW5jdGlvbiBpcyBsYW1iZGEgZnVuY3Rpb24gdGhhdCBjYWxscworICAgYGludGVybmFsLS1t b2R1bGUtY2FsbCcsIHBhc3NpbmcgdGhlIGZ1bmN0aW9uIHBvaW50ZXIgb2YgdGhlIG1vZHVsZQor ICAgZnVuY3Rpb24gYWxvbmcgd2l0aCB0aGUgbW9kdWxlIGVtYWNzX2VudiBwb2ludGVyIGFzIGFy Z3VtZW50cy4KIAogCShmdW5jdGlvbiAobGFtYmRhICgmcmVzdCBhcmdsaXN0KQotCQkgICAgKG1v ZHVsZS1jYWxsIGVudm9iaiBhcmdsaXN0KSkpICAqLworCQkgICAgKGludGVybmFsLS1tb2R1bGUt Y2FsbCBlbnZvYmogYXJnbGlzdCkpKSAgKi8KIAogc3RhdGljIGVtYWNzX3ZhbHVlCiBtb2R1bGVf bWFrZV9mdW5jdGlvbiAoZW1hY3NfZW52ICplbnYsIHB0cmRpZmZfdCBtaW5fYXJpdHksIHB0cmRp ZmZfdCBtYXhfYXJpdHksCkBAIC00MzAsNyArNDI1LDcgQEAgbW9kdWxlX21ha2VfZnVuY3Rpb24g KGVtYWNzX2VudiAqZW52LCBwdHJkaWZmX3QgbWluX2FyaXR5LCBwdHJkaWZmX3QgbWF4X2FyaXR5 LAogICBMaXNwX09iamVjdCByZXQgPSBsaXN0NCAoUWxhbWJkYSwKICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGxpc3QyIChRYW5kX3Jlc3QsIFFhcmdzKSwKICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGRvYywKLSAgICAgICAgICAgICAgICAgICAgICAgICAgIGxpc3QzIChtb2R1bGVfY2Fs bF9mdW5jLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgbGlzdDMgKFFpbnRlcm5hbF9tb2R1 bGVfY2FsbCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBlbnZvYmosCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUWFyZ3MpKTsKIApAQCAtNzg1LDEyICs3ODAs MTYgQEAgREVGVU4gKCJtb2R1bGUtbG9hZCIsIEZtb2R1bGVfbG9hZCwgU21vZHVsZV9sb2FkLCAx LCAxLCAwLAogICByZXR1cm4gUXQ7CiB9CiAKLURFRlVOICgibW9kdWxlLWNhbGwiLCBGbW9kdWxl X2NhbGwsIFNtb2R1bGVfY2FsbCwgMiwgMiwgMCwKK0RFRlVOICgiaW50ZXJuYWwtLW1vZHVsZS1j YWxsIiwgRmludGVybmFsX21vZHVsZV9jYWxsLCBTaW50ZXJuYWxfbW9kdWxlX2NhbGwsIDIsIDIs IDAsCiAgICAgICAgZG9jOiAvKiBJbnRlcm5hbCBmdW5jdGlvbiB0byBjYWxsIGEgbW9kdWxlIGZ1 bmN0aW9uLgogRU5WT0JKIGlzIGEgc2F2ZSBwb2ludGVyIHRvIGEgbW9kdWxlX2Z1bl9lbnYgc3Ry dWN0dXJlLgogQVJHTElTVCBpcyBhIGxpc3Qgb2YgYXJndW1lbnRzIHBhc3NlZCB0byBTVUJSUFRS LiAgKi8pCiAgIChMaXNwX09iamVjdCBlbnZvYmosIExpc3BfT2JqZWN0IGFyZ2xpc3QpCiB7Cisg IENIRUNLX1RZUEUgKFNBVkVfVkFMVUVQIChlbnZvYmopLCBRc2F2ZV92YWx1ZV9wLCBlbnZvYmop OworICBzdHJ1Y3QgTGlzcF9TYXZlX1ZhbHVlICpzYXZlX3ZhbHVlID0gWFNBVkVfVkFMVUUgKGVu dm9iaik7CisgIENIRUNLX1RZUEUgKHNhdmVfdHlwZSAoc2F2ZV92YWx1ZSwgMCkgPT0gU0FWRV9Q T0lOVEVSLCBRc2F2ZV9wb2ludGVyX3AsIGVudm9iaik7CisgIENIRUNLX0NPTlMgKGFyZ2xpc3Qp OwogICBzdHJ1Y3QgbW9kdWxlX2Z1bl9lbnYgKmVudnB0ciA9IFhTQVZFX1BPSU5URVIgKGVudm9i aiwgMCk7CiAgIEVNQUNTX0lOVCBsZW4gPSBYRkFTVElOVCAoRmxlbmd0aCAoYXJnbGlzdCkpOwog ICBlYXNzdW1lICgwIDw9IGVudnB0ci0+bWluX2FyaXR5KTsKQEAgLTExNTgsMTQgKzExNTcsMTMg QEAgc3ltc19vZl9tb2R1bGUgKHZvaWQpCiAgICAgIGNvZGUgb3IgbW9kdWxlcyBzaG91bGQgbm90 IGFjY2VzcyBpdC4gICovCiAgIEZ1bmludGVybiAoUW1vZHVsZV9yZWZzX2hhc2gsIFFuaWwpOwog CisgIERFRlNZTSAoUXNhdmVfdmFsdWVfcCwgInNhdmUtdmFsdWUtcCIpOworICBERUZTWU0gKFFz YXZlX3BvaW50ZXJfcCwgInNhdmUtcG9pbnRlci1wIik7CisKICAgZGVmc3ViciAoJlNtb2R1bGVf bG9hZCk7CiAKLSAgLyogRG9uJ3QgY2FsbCBkZWZzdWJyIG9uIGBtb2R1bGUtY2FsbCcgYmVjYXVz ZSB0aGF0IHdvdWxkIGludGVybiBpdCwKLSAgICAgYnV0IGBtb2R1bGUtY2FsbCcgaXMgYW4gaW50 ZXJuYWwgZnVuY3Rpb24gdGhhdCB1c2VycyBjYW5ub3QKLSAgICAgbWVhbmluZ2Z1bGx5IHVzZS4g IEluc3RlYWQsIGFzc2lnbiBpdHMgZGVmaW5pdGlvbiB0byBhIHByaXZhdGUKLSAgICAgdmFyaWFi bGUuICAqLwotICBYU0VUUFZFQ1RZUEUgKCZTbW9kdWxlX2NhbGwsIFBWRUNfU1VCUik7Ci0gIFhT RVRTVUJSIChtb2R1bGVfY2FsbF9mdW5jLCAmU21vZHVsZV9jYWxsKTsKKyAgREVGU1lNIChRaW50 ZXJuYWxfbW9kdWxlX2NhbGwsICJpbnRlcm5hbC0tbW9kdWxlLWNhbGwiKTsKKyAgZGVmc3ViciAo JlNpbnRlcm5hbF9tb2R1bGVfY2FsbCk7CiB9CiAKIC8qIFVubGlrZSBzeW1zX29mX21vZHVsZSwg dGhpcyBpbml0aWFsaXplciBpcyBjYWxsZWQgZXZlbiBmcm9tIGFuCi0tIAoyLjYuMwoK --001a114b07d4bf0eeb05258a0769--