From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: master b99ec5d 3/3: Work around __has_attribute bug in clang 3.4 Date: Sat, 23 Jan 2021 21:26:13 +0100 Message-ID: References: <20210122200300.770.63187@vcs0.savannah.gnu.org> <20210122200304.8BBE820A10@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26839"; mail-complaints-to="usenet@ciao.gmane.io" Cc: =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= , Emacs developers , Glenn Morris To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 23 21:27:27 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l3PVG-0006pd-SO for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Jan 2021 21:27:26 +0100 Original-Received: from localhost ([::1]:49846 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3PVF-0003gX-Ro for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Jan 2021 15:27:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39354) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3PUK-0003GU-DV for emacs-devel@gnu.org; Sat, 23 Jan 2021 15:26:29 -0500 Original-Received: from mail-oi1-x230.google.com ([2607:f8b0:4864:20::230]:39389) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l3PUI-0001NB-BR; Sat, 23 Jan 2021 15:26:28 -0500 Original-Received: by mail-oi1-x230.google.com with SMTP id w124so10299381oia.6; Sat, 23 Jan 2021 12:26:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=tT88kug7MvEg4CvNDUZ6DwW56+uNYMl96KI8novpTO4=; b=GVklRaDOSN3gy2yWXKpumlmywyhZQBJxpvHfwLm4Ddna7UPG514jo0p/Pn8QmEJW0w 3iJBoEFPoHAxCuQ6uHafejmIsBUn2N4/sfnFD0NR2MNZ8qbfRVlpBMVDmlyUItx3BAcg WE/kg8kFrhbNR9GkIxmLk724zuWOQg4eqpW0A6AcGx16OPeiJzLliW+cTg7CHyJ6DpLn 0EKY3CPq0cna5cyybgAC0/eTGKsm2NplW15PMZ2Uir+SrYkJbBPaAh+MBaXTjP7ttvtH hiTfXQtgWH1uuBVScfTZc2mYiRtolMc/gvXSOn8baFUJ2CL7VptJAMdmkUJqzlIyKvre vLEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=tT88kug7MvEg4CvNDUZ6DwW56+uNYMl96KI8novpTO4=; b=lKGievjzJiGQOG1br2V6WviaJEC8aXJIAyCLTj/+0RYwSeYcC80dYYqVErwds5ZyB7 dNlCT75Cfb9041B9O59mSsrMrPpPKsfME1rx2xu0YFETZHCKqI+dnUMpob7KUmI/dTL9 fFXZ+rQRKDZTX/mHTyn6x+0Pl12nJU652veS1rRyW6G86lcXjfAQku4coT2w4e8mbe6c KkW6/y/RFm0IzXpvKh0pfuYEaODdL6sdXHOZPMdGeJcnm6B6oFy0HYTJhPT3dVyYG3dz xmye8PvU9zUZv1zp6wV8wSXTm7GlZP+sFanFlUQkULAiD+OiNTAxx3WumzMxfPrf6P/7 tvPg== X-Gm-Message-State: AOAM53324rZw78pstrqrdE3g/IONEgeU4o+gxySTqe8Vyoq+e/6R215i oT4Lt3wE4YotdzW4fTgU9kWfLjvzQXtLIjtJBS4= X-Google-Smtp-Source: ABdhPJzEhNLE0c/ZtDd4IOx6sP1vALzJVkLT7K2EuzpKaBF/KrZHvd7qYuM6ASaPf6sL77hUddySRn9GySoRVBAevTA= X-Received: by 2002:aca:38c1:: with SMTP id f184mr197456oia.158.1611433584578; Sat, 23 Jan 2021 12:26:24 -0800 (PST) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::230; envelope-from=p.stephani2@gmail.com; helo=mail-oi1-x230.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263318 Archived-At: Am Sa., 23. Jan. 2021 um 20:42 Uhr schrieb Paul Eggert = : > > On 1/23/21 2:11 AM, Mattias Engdeg=C3=A5rd wrote: > > 23 jan. 2021 kl. 01.46 skrev Paul Eggert : > > > >> Perhaps someone who can build on macOS directly can provide more info = about the problem. I had no problem building with clang 11.0 on Ubuntu but = Apple's clang is special. > > > > Apple's clang seems to come with a builtin > > > > #define __nonnull _Nonnull > > > > which clashes with the the one in lib/cdefs.h. Perhaps we should call i= t something else. > > Thanks for the diagnosis. Although calling it something else would > obviously work, it would require renaming __nonnull everywhere within > Gnulib (and eventually Glibc), and that would be entirely contrary to > the intent of the Apple macro - which was to encourage compatibility > with GNU code. As I understand things Apple's __nonnull keyword used to > mean something else but collided with GNU's __nonnull macro, so they > renamed the keyword and put in a backward-compatibility macro for old > Applish code, but we don't need that macro and can just use __nonnull > for our own use. > > I attempted to fix the problem by installing the attached patch into > Gnulib, and then merged Gnulib into Emacs master. Please give it a try, > as I don't use macOS and so did not check the patch directly. Thanks, it compiles fine for me now.