From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#42536: 28.0.50; Test vc-test-svn00-create-repo failing if snvadmin program not installed Date: Tue, 4 Aug 2020 18:29:12 +0200 Message-ID: References: <87zh7ao9ts.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3931"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 42536@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 04 18:30:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2zpP-0000rj-4T for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 Aug 2020 18:30:15 +0200 Original-Received: from localhost ([::1]:51040 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k2zpN-000651-Vy for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 Aug 2020 12:30:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50848) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k2zpD-00063w-3b for bug-gnu-emacs@gnu.org; Tue, 04 Aug 2020 12:30:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37455) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k2zpC-00013b-10 for bug-gnu-emacs@gnu.org; Tue, 04 Aug 2020 12:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k2zpB-0003Lc-UZ for bug-gnu-emacs@gnu.org; Tue, 04 Aug 2020 12:30:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Aug 2020 16:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42536 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 42536-submit@debbugs.gnu.org id=B42536.159655857112806 (code B ref 42536); Tue, 04 Aug 2020 16:30:01 +0000 Original-Received: (at 42536) by debbugs.gnu.org; 4 Aug 2020 16:29:31 +0000 Original-Received: from localhost ([127.0.0.1]:49001 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k2zoh-0003KT-D1 for submit@debbugs.gnu.org; Tue, 04 Aug 2020 12:29:31 -0400 Original-Received: from mail-oo1-f48.google.com ([209.85.161.48]:35040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k2zoe-0003KF-TV for 42536@debbugs.gnu.org; Tue, 04 Aug 2020 12:29:29 -0400 Original-Received: by mail-oo1-f48.google.com with SMTP id j19so2476259oor.2 for <42536@debbugs.gnu.org>; Tue, 04 Aug 2020 09:29:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PZEspT15ah3chanYRJBUPlwhnmSN0vpN6TTDNrHFmg8=; b=IN+TKJbuiQlfZcNPdwoMYXwDDACiFgDV8y2hKCEVj6+xUutMsrtLd3syEqU9g40Osn aW0ja/nosq7F9wJ3EQesOronmoL+kI6gnG6l95cGTNWjpnolM0BOhOobKItwgKfirnAu vO4jyuWn+sZNyX0oLRkYY3W1ioFH0REedWA2U+ze8DsaBY3ipU/8cYB5VH1fcOt1njGb ehmgTHmPhOnEWZERjDmBQ8hO2ZLyAQcWQMJE/Oa59AZY6KGzzYSnSHMZKkkN7sNjfKQU rPefkPAGh4gA0J9DJvxG9uz7Zg4PLNSsgGgqJshs0YFqks8H3oUuHp6mYtCE6zIY5ssp +m2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PZEspT15ah3chanYRJBUPlwhnmSN0vpN6TTDNrHFmg8=; b=RuBkgy7+r0/ZAnPRLcIkPeBOSSDYTAGWxBDWgPIipIJ+GypD7NVQ0k6xxK87BCV51C odHUBz7jnlMYRrVyOldogChga+FfUP2bo69jNXI80qsXggSHB+dvtZtw71ewJm98Nqxp 7HEapx85HVIvzPA4Ic59Mwk/8fNJLUQnwk5/AXungo/PCSBLV8zf6ZhtukqQkj0itze6 taGwQVr/EXhaOwjnCObTa8+5DPe+2ND6APIYKBIAqJ6Ew3pv24AV0CaMi6MqVwsVrGLc F+o5MbbutXY3BxBb5uyLR6HqpqE0r5/8zo3hB5tp8tZfpPrQOBZt+iEYRSn8tcOuSohA PnJA== X-Gm-Message-State: AOAM530C355av65dCDx+Beug6j4rmOYAk/yi4Fdb1C6MTHOaP4UQcPom gtmIYNUmHrff1mCJjSj50P4E69eSYXMku8D3Af0= X-Google-Smtp-Source: ABdhPJwm+fNswGX7/EUEjKOASqy51Q5fuwuk1QxZ6KddTdWZbxIlbogRTfy0IuGX8jjLolEL1XPqKIORziEmsv+Bj4I= X-Received: by 2002:a4a:3b0f:: with SMTP id s15mr5344014oos.71.1596558563112; Tue, 04 Aug 2020 09:29:23 -0700 (PDT) In-Reply-To: <87zh7ao9ts.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184036 Archived-At: Am Di., 4. Aug. 2020 um 14:49 Uhr schrieb Lars Ingebrigtsen : > > Philipp writes: > > > This is another follow-up to Bug#30700. In this case, it's probably > > unrelated to macOS, and the SVN tests should simply check whether SVN is > > actually installed. However, since the tests are autogenerated by a > > macro, this isn't entirely trivial: > > > > Test vc-test-svn00-create-repo backtrace: > > call-process("svnadmin" nil t nil "create" "SVN") > > Hm... I don't have svn on my Linux laptop either, and the svn tests are > just not done there. So why are they performed on an svn-less Macos > laptop? > > Aaah! > > larsi@space test % svn > svn: error: The subversion command line tools are no longer provided by Xcode. > > So > > (defun vc-test--svn-enabled () > (executable-find vc-svn-program)) > > evaluates to true, even if there's no useable svn on the system. Thank > you, Apple! > > I've now amended the test to check for svnadmin, too. > Thanks, confirmed.