bug#24372: 25.1.50; After losing focus, cursor is hidden when moving point

[Philipp Stephani <p.stephani2@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 343 bytes --]

Philipp Stephani <p.stephani2@gmail.com> schrieb am Sa., 1. Okt. 2016 um
18:11 Uhr:

> Indeed, the repeat argument of run-with-idle-timer is only checked for
> nil-ness and otherwise ignored. I'd suggest to pass something like :repeat
> or t to that argument so that readers are less confused.
>
>

I've attached another patch that does this.

[-- Attachment #1.2: Type: text/html, Size: 850 bytes --]

[-- Attachment #2: 0001-Use-a-simple-keyword-for-a-non-nil-argument.txt --]
[-- Type: text/plain, Size: 1645 bytes --]

From 08b386db1f4212ce90f726442fcf356885fb31ae Mon Sep 17 00:00:00 2001
From: Philipp Stephani <phst@google.com>
Date: Sat, 1 Oct 2016 20:13:53 +0200
Subject: [PATCH] Use a simple keyword for a non-nil argument

The second argument of `run-with-idle-timer' is Boolean, i.e. only nil
and non-nil values are distinguished.  Passing a number here is
confusing.  Pass a descriptive symbol instead.

* lisp/frame.el (blink-cursor-mode, blink-cursor-check): Use
:repeat symbol instead of number for second argument of
`run-with-idle-timer'
---
 lisp/frame.el | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/lisp/frame.el b/lisp/frame.el
index b13621a..d3b6353 100644
--- a/lisp/frame.el
+++ b/lisp/frame.el
@@ -2119,8 +2119,7 @@ blink-cursor-check
           ;; during command execution) if they set blink-cursor-delay
           ;; to a very small or even zero value.
           (run-with-idle-timer (max 0.2 blink-cursor-delay)
-                               blink-cursor-delay
-                               'blink-cursor-start))))
+                               :repeat #'blink-cursor-start))))
 
 (define-obsolete-variable-alias 'blink-cursor 'blink-cursor-mode "22.1")
 
@@ -2157,8 +2156,7 @@ blink-cursor-mode
           ;; during command execution) if they set blink-cursor-delay
           ;; to a very small or even zero value.
           (run-with-idle-timer (max 0.2 blink-cursor-delay)
-                               blink-cursor-delay
-                               #'blink-cursor-start))))
+                               :repeat #'blink-cursor-start))))
 
 \f
 ;; Frame maximization/fullscreen
-- 
2.10.0