From: Philipp Stephani <p.stephani2@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 24372@debbugs.gnu.org
Subject: bug#24372: 25.1.50; After losing focus, cursor is hidden when moving point
Date: Sat, 01 Oct 2016 18:16:30 +0000 [thread overview]
Message-ID: <CAArVCkRXwiGjuJU+J2hL0wfoFy-GHa3biPb6cxhwTVkfdpHx6Q@mail.gmail.com> (raw)
In-Reply-To: <CAArVCkQAdr=90UBCK=XYR3a954Lr4b7fcaoiky7ZuJeZe-qUXw@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 343 bytes --]
Philipp Stephani <p.stephani2@gmail.com> schrieb am Sa., 1. Okt. 2016 um
18:11 Uhr:
> Indeed, the repeat argument of run-with-idle-timer is only checked for
> nil-ness and otherwise ignored. I'd suggest to pass something like :repeat
> or t to that argument so that readers are less confused.
>
>
I've attached another patch that does this.
[-- Attachment #1.2: Type: text/html, Size: 850 bytes --]
[-- Attachment #2: 0001-Use-a-simple-keyword-for-a-non-nil-argument.txt --]
[-- Type: text/plain, Size: 1645 bytes --]
From 08b386db1f4212ce90f726442fcf356885fb31ae Mon Sep 17 00:00:00 2001
From: Philipp Stephani <phst@google.com>
Date: Sat, 1 Oct 2016 20:13:53 +0200
Subject: [PATCH] Use a simple keyword for a non-nil argument
The second argument of `run-with-idle-timer' is Boolean, i.e. only nil
and non-nil values are distinguished. Passing a number here is
confusing. Pass a descriptive symbol instead.
* lisp/frame.el (blink-cursor-mode, blink-cursor-check): Use
:repeat symbol instead of number for second argument of
`run-with-idle-timer'
---
lisp/frame.el | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/lisp/frame.el b/lisp/frame.el
index b13621a..d3b6353 100644
--- a/lisp/frame.el
+++ b/lisp/frame.el
@@ -2119,8 +2119,7 @@ blink-cursor-check
;; during command execution) if they set blink-cursor-delay
;; to a very small or even zero value.
(run-with-idle-timer (max 0.2 blink-cursor-delay)
- blink-cursor-delay
- 'blink-cursor-start))))
+ :repeat #'blink-cursor-start))))
(define-obsolete-variable-alias 'blink-cursor 'blink-cursor-mode "22.1")
@@ -2157,8 +2156,7 @@ blink-cursor-mode
;; during command execution) if they set blink-cursor-delay
;; to a very small or even zero value.
(run-with-idle-timer (max 0.2 blink-cursor-delay)
- blink-cursor-delay
- #'blink-cursor-start))))
+ :repeat #'blink-cursor-start))))
\f
;; Frame maximization/fullscreen
--
2.10.0
next prev parent reply other threads:[~2016-10-01 18:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 19:16 bug#24372: 25.1.50; After losing focus, cursor is hidden when moving point Philipp Stephani
2016-09-05 21:29 ` Clément Pit--Claudel
2016-09-06 16:03 ` Eli Zaretskii
2016-09-09 15:59 ` Philipp Stephani
2016-09-09 16:07 ` Eli Zaretskii
2016-09-09 16:20 ` Philipp Stephani
2016-09-09 16:29 ` Philipp Stephani
2016-09-09 17:18 ` Philipp Stephani
2016-09-09 18:59 ` Philipp Stephani
2016-09-10 7:21 ` Eli Zaretskii
2016-09-11 9:15 ` Philipp Stephani
2016-09-11 16:23 ` Eli Zaretskii
2016-09-11 17:37 ` Philipp Stephani
2016-09-11 19:18 ` Eli Zaretskii
2016-09-23 14:28 ` Eli Zaretskii
2016-09-25 19:09 ` Philipp Stephani
2016-10-01 8:25 ` Eli Zaretskii
2016-10-01 16:11 ` Philipp Stephani
2016-10-01 17:29 ` Eli Zaretskii
2016-10-01 18:10 ` Philipp Stephani
2016-10-02 7:12 ` Eli Zaretskii
2016-10-01 18:16 ` Philipp Stephani [this message]
2016-10-02 7:14 ` Eli Zaretskii
2016-10-02 17:56 ` Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAArVCkRXwiGjuJU+J2hL0wfoFy-GHa3biPb6cxhwTVkfdpHx6Q@mail.gmail.com \
--to=p.stephani2@gmail.com \
--cc=24372@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.