From: Philipp Stephani <p.stephani2@gmail.com>
To: Gemini Lasswell <gazally@runbox.com>, 24747@debbugs.gnu.org
Subject: bug#24747: 26.0.50; test/lisp/progmodes/cc-mode.el sets lexical-binning not lexical-binding
Date: Thu, 20 Oct 2016 18:29:38 +0000 [thread overview]
Message-ID: <CAArVCkRNwYKA+jbi168zNP-yTtsYf5qqTktCd5Cg6XNc+EJARw@mail.gmail.com> (raw)
In-Reply-To: <m2h986kiut.fsf@rainbow.local>
[-- Attachment #1.1: Type: text/plain, Size: 525 bytes --]
Gemini Lasswell <gazally@runbox.com> schrieb am Do., 20. Okt. 2016 um
19:55 Uhr:
> On loading the file test/lisp/progmodes/cc-mode.el, Emacs gives the
> warning that the local variables list may not be safe. Looks like a
> typo. Also, the first line of the file refers to cc-mode-tests.el but
> the file is called cc-mode.el. IMO cc-mode-tests.el would be a better
> name for this file and more consistent with other file names in the test
> directory.
>
>
>
Thanks for reporting. I've attached a patch to fix these issues.
[-- Attachment #1.2: Type: text/html, Size: 967 bytes --]
[-- Attachment #2: 0001-Minor-fixes-to-cc-mode-tests.el.txt --]
[-- Type: text/plain, Size: 1505 bytes --]
From 56f8384bb3f20d55693a3a1db8aa2cf490e6d18e Mon Sep 17 00:00:00 2001
From: Philipp Stephani <phst@google.com>
Date: Thu, 20 Oct 2016 20:22:40 +0200
Subject: [PATCH] Minor fixes to cc-mode-tests.el
See Bug#24747.
* progmodes/cc-mode-tests.el: Rename from cc-mode.el; fix typo in
file-local variable; add comments to make checkdoc happy.
---
test/lisp/progmodes/{cc-mode.el => cc-mode-tests.el} | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
rename test/lisp/progmodes/{cc-mode.el => cc-mode-tests.el} (96%)
diff --git a/test/lisp/progmodes/cc-mode.el b/test/lisp/progmodes/cc-mode-tests.el
similarity index 96%
rename from test/lisp/progmodes/cc-mode.el
rename to test/lisp/progmodes/cc-mode-tests.el
index 6cd9fa4..62e0a73 100644
--- a/test/lisp/progmodes/cc-mode.el
+++ b/test/lisp/progmodes/cc-mode-tests.el
@@ -1,4 +1,4 @@
-;;; cc-mode-tests.el --- Test suite for cc-mode. -*- lexical-binning: t -*-
+;;; cc-mode-tests.el --- Test suite for cc-mode. -*- lexical-binding: t; -*-
;; Copyright (C) 2016 Free Software Foundation, Inc.
@@ -21,6 +21,11 @@
;; You should have received a copy of the GNU General Public License
;; along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.
+
+;;; Commentary:
+
+;; Unit tests for cc-mode.el.
+
;;; Code:
(require 'ert)
@@ -63,3 +68,5 @@
'("struct \t Blah_42 \t {"
"struct template {"
"#include <string.h>")))))
+
+;;; cc-mode-tests.el ends here
--
2.8.0.rc3.226.g39d4020
next prev parent reply other threads:[~2016-10-20 18:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 17:53 bug#24747: 26.0.50; test/lisp/progmodes/cc-mode.el sets lexical-binning not lexical-binding Gemini Lasswell
2016-10-20 18:29 ` Philipp Stephani [this message]
2016-10-20 19:26 ` Eli Zaretskii
2016-10-20 19:34 ` Philipp Stephani
2016-10-20 19:55 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAArVCkRNwYKA+jbi168zNP-yTtsYf5qqTktCd5Cg6XNc+EJARw@mail.gmail.com \
--to=p.stephani2@gmail.com \
--cc=24747@debbugs.gnu.org \
--cc=gazally@runbox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.