From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#27059: Can't compile master branch on Mac OS X Date: Wed, 24 May 2017 20:20:14 +0000 Message-ID: References: <0641617c-09f7-4a2a-f332-77f66c7cef4b@porkrind.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a11455dfe9b731f05504ad589" X-Trace: blaine.gmane.org 1495657277 27317 195.159.176.226 (24 May 2017 20:21:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 24 May 2017 20:21:17 +0000 (UTC) To: David Caldwell , 27059@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 24 22:21:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDcmL-0006rv-BX for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 May 2017 22:21:09 +0200 Original-Received: from localhost ([::1]:56681 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dDcmP-0001V8-3w for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 May 2017 16:21:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59319) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dDcmH-0001V1-Ve for bug-gnu-emacs@gnu.org; Wed, 24 May 2017 16:21:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dDcmE-0002Fd-Iy for bug-gnu-emacs@gnu.org; Wed, 24 May 2017 16:21:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33959) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dDcmE-0002FT-8Z for bug-gnu-emacs@gnu.org; Wed, 24 May 2017 16:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dDcmE-0007HI-0f for bug-gnu-emacs@gnu.org; Wed, 24 May 2017 16:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 May 2017 20:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27059 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27059-submit@debbugs.gnu.org id=B27059.149565723327936 (code B ref 27059); Wed, 24 May 2017 20:21:01 +0000 Original-Received: (at 27059) by debbugs.gnu.org; 24 May 2017 20:20:33 +0000 Original-Received: from localhost ([127.0.0.1]:36636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDcll-0007GV-4d for submit@debbugs.gnu.org; Wed, 24 May 2017 16:20:33 -0400 Original-Received: from mail-oi0-f50.google.com ([209.85.218.50]:33380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDcli-0007GI-U4 for 27059@debbugs.gnu.org; Wed, 24 May 2017 16:20:31 -0400 Original-Received: by mail-oi0-f50.google.com with SMTP id w10so257119301oif.0 for <27059@debbugs.gnu.org>; Wed, 24 May 2017 13:20:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=404ujDN5ZcyWuFzweNC+89p7x9rHGfDkRPXBIqtjYKs=; b=WFYnjMFRKJGlj6fcGpEjgw3ZnWgCKIhCM9+idHY+2Lr54/ptDBHf2HqrPkoJBcGykt 6zhRJLM2ZUECvw1DgGnCglYuJJ8SoCsYcXOzOKM8j7pb6LXZX7TtVw3Geg3q/9Ad+EWP O+pjW9Jfwx8un+EGj84IBFgO0ytV9V9BviDo+kImwQSxXlLfhh72NDu3N/dzbXxy4MPa 2FhC9yyVK3rC8VQdnucwccoTpPVVlPpnUIhKZFKRTy5dYfWLDUgLwX63Mp8Gly8HEFDj e5qw03ljyVm+gAxnY0cMbhMx85attnWtI1AvGbKdK2T9usd8xcTOHiP8tEn02KCIUeYp llmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=404ujDN5ZcyWuFzweNC+89p7x9rHGfDkRPXBIqtjYKs=; b=tHUNJOSTh9b9IgDAwG3Pg79t5r756WGlPWJ0qKzN8Mqgowfnh/MyVPcAFbBtDejteV g2uXTVIsF4ckrWtG6B5hEO0qr6FnnQeQeL4aInmp7L8gL87/NDYM26pbOVj8HgG+dUUS akN4diyPKvH/vSsQLWwEHfGfuit7O1ZYA5B/LFo9kU9CEOZtkXX6aNZojHJMgsexj85E 01iqBqRH1XVl7d6scmCXVyIp0aOgLtgAjBfv8wir4puJmPzDmjBD6LQ6oPezsRdQV9mu 26qguCD5ZKqOV8dil1kL2FAO3RKE5PaWAtiJQIIPADN5rLyBEtAb3qBqi/ZJQw3EuV4A Xjpg== X-Gm-Message-State: AODbwcBKown/qn1xm6Yu4yYSl1+qyOZG1kD9jnld425IV2PCJKBZb9lv uSAwllkEKsTShtx7iWa/cqYqcKwfbg== X-Received: by 10.157.37.194 with SMTP id q60mr6010929ota.44.1495657225087; Wed, 24 May 2017 13:20:25 -0700 (PDT) In-Reply-To: <0641617c-09f7-4a2a-f332-77f66c7cef4b@porkrind.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:132809 Archived-At: --001a11455dfe9b731f05504ad589 Content-Type: text/plain; charset="UTF-8" David Caldwell schrieb am Mi., 24. Mai 2017 um 18:24 Uhr: > On Mac OS X 10.9 (Mavericks) and Mac OS X 10.8 (Mountain Lion): > > CC nsterm.o > nsterm.m:5496:33: warning: format string is not a string literal > (potentially insecure) [-Wformat-security] > return NSRunAlertPanel(title, msgFormat, defaultButton, > alternateButton, nil) > ^~~~~~~~~ > 1 warning generated. > CC nsfns.o > CC nsmenu.o > nsmenu.m:1496:70: error: expected a type > - (instancetype)initWithContentRect: (NSRect)contentRect styleMask: > (NSWindowStyleMask)aStyle > ^ > nsmenu.m:1520:10: warning: incompatible integer to pointer conversion > assigning to 'id' from 'int' [-Wint-conversion] > aStyle = > > NSWindowStyleMaskTitled|NSWindowStyleMaskClosable|NSWindowStyleMaskUtilityWindow; > ^ > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > nsmenu.m:1524:54: warning: incompatible pointer to integer conversion > sending 'id' to parameter of type 'NSUInteger' (aka 'unsigned long') > [-Wint-conversion] > [super initWithContentRect: contentRect styleMask: aStyle > ^~~~~~ > /System/Library/Frameworks/AppKit.framework/Headers/NSWindow.h:289:69: > note: passing argument to parameter 'aStyle' here > - (id)initWithContentRect:(NSRect)contentRect > styleMask:(NSUInteger)aStyle backing:(NSBackingStoreType)bufferingType > defer:(BOOL)flag; > ^ > nsmenu.m:1496:88: warning: conflicting parameter types in implementation > of 'initWithContentRect:styleMask:backing:defer:': 'NSUInteger' (aka > 'unsigned long') vs 'id' [-Wmismatched-parameter-types] > - (instancetype)initWithContentRect: (NSRect)contentRect styleMask: > (NSWindowStyleMask)aStyle > > ^ > /System/Library/Frameworks/AppKit.framework/Headers/NSWindow.h:289:69: > note: previous definition is here > - (id)initWithContentRect:(NSRect)contentRect > styleMask:(NSUInteger)aStyle backing:(NSBackingStoreType)bufferingType > defer:(BOOL)flag; > ~~~~~~~~~~ ^ > 3 warnings and 1 error generated. > make[1]: *** [nsmenu.o] Error 1 > make: *** [src] Error 2 > make failed > > > > On Mac OS X 10.6 (Snow Leopard): > CC nsterm.o > In file included from nsterm.m:48: > nsterm.h:454: error: expected ')' before 'instancetype' > nsterm.h:455: error: expected ')' before 'instancetype' > nsterm.h:456: error: expected ')' before 'instancetype' > nsterm.h:460: error: expected ')' before 'instancetype' > nsterm.h:463: error: expected ')' before 'instancetype' > nsterm.h:523: error: expected ')' before 'instancetype' > nsterm.h:557: error: expected ')' before 'instancetype' > nsterm.h:592: error: expected ')' before 'instancetype' > nsterm.h:611: error: expected ')' before 'instancetype' > nsterm.h:659: error: expected ')' before 'instancetype' > nsterm.h:661: error: expected ')' before 'instancetype' > nsterm.h:663: error: expected ')' before 'instancetype' > nsterm.h:664: error: expected ')' before 'instancetype' > nsterm.h:703: error: expected ')' before 'instancetype' > nsterm.h:706: error: expected ')' before 'instancetype' > nsterm.h:710: error: expected ')' before 'instancetype' > nsterm.h:711: error: expected ')' before 'instancetype' > nsterm.h:712: error: expected ')' before 'instancetype' > nsterm.h:735: error: expected ')' before 'instancetype' > nsterm.m:6900: error: expected ')' before 'instancetype' > nsterm.m:7630: error: expected ')' before 'instancetype' > nsterm.m:7655: error: expected ')' before 'instancetype' > nsterm.m:7681: error: expected ')' before 'instancetype' > nsterm.m:7909: error: expected ')' before 'instancetype' > nsterm.m:8261: error: expected ')' before 'instancetype' > nsterm.m:8345: error: expected ')' before 'instancetype' > nsterm.m:8353: error: expected ')' before 'instancetype' > nsterm.m:8408: error: expected ')' before 'instancetype' > nsterm.m:8487: error: expected ')' before 'instancetype' > make[1]: *** [nsterm.o] Error 1 > make: *** [src] Error 2 > make failed > > > I think these may have been caused by the recent GNUStep changes. > Can you try applying the following patch: diff --git a/src/nsterm.h b/src/nsterm.h index 8f3d92b353..288b91269d 100644 --- a/src/nsterm.h +++ b/src/nsterm.h @@ -65,7 +65,7 @@ typedef float EmacsCGFloat; /* FIXME: instancetype is a language built-in, but older versions of Clang don't support it, and I don't know if GCC supports it at all. Should this be tested for in ./configure? */ -#if defined (NS_IMPL_GNUSTEP) +#if defined (NS_IMPL_GNUSTEP) \ || MAC_OS_X_VERSION_MAX_ALLOWED < MAC_OS_X_VERSION_10_10 typedef id instancetype; typedef NSUInteger NSWindowStyleMask; --001a11455dfe9b731f05504ad589 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


David = Caldwell <david@porkrind.org&g= t; schrieb am Mi., 24. Mai 2017 um 18:24=C2=A0Uhr:
On Mac OS X 10.9 (Mavericks) and Mac OS X 10.8 (Mountain Li= on):

=C2=A0 CC=C2=A0 =C2=A0 =C2=A0 =C2=A0nsterm.o
nsterm.m:5496:33: warning: format string is not a string literal
(potentially insecure) [-Wformat-security]
=C2=A0 return NSRunAlertPanel(title, msgFormat, defaultButton,
alternateButton, nil)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^~~~~~~~~
1 warning generated.
=C2=A0 CC=C2=A0 =C2=A0 =C2=A0 =C2=A0nsfns.o
=C2=A0 CC=C2=A0 =C2=A0 =C2=A0 =C2=A0nsmenu.o
nsmenu.m:1496:70: error: expected a type
- (instancetype)initWithContentRect: (NSRect)contentRect styleMask:
(NSWindowStyleMask)aStyle
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0^
nsmenu.m:1520:10: warning: incompatible integer to pointer conversion
assigning to 'id' from 'int' [-Wint-conversion]
=C2=A0 aStyle =3D
NSWindowStyleMaskTitled|NSWindowStyleMaskClosable|NSWindowStyleMaskUtilityW= indow;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~= ~~~~~
nsmenu.m:1524:54: warning: incompatible pointer to integer conversion
sending 'id' to parameter of type 'NSUInteger' (aka 'un= signed long')
[-Wint-conversion]
=C2=A0 [super initWithContentRect: contentRect styleMask: aStyle
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^~~~~~
/System/Library/Frameworks/AppKit.framework/Headers/NSWindow.h:289:69:
note: passing argument to parameter 'aStyle' here
- (id)initWithContentRect:(NSRect)contentRect
styleMask:(NSUInteger)aStyle backing:(NSBackingStoreType)bufferingType
defer:(BOOL)flag;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 ^
nsmenu.m:1496:88: warning: conflicting parameter types in implementation of 'initWithContentRect:styleMask:backing:defer:': 'NSUInteger&= #39; (aka
'unsigned long') vs 'id' [-Wmismatched-parameter-types]
- (instancetype)initWithContentRect: (NSRect)contentRect styleMask:
(NSWindowStyleMask)aStyle

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^
/System/Library/Frameworks/AppKit.framework/Headers/NSWindow.h:289:69:
note: previous definition is here
- (id)initWithContentRect:(NSRect)contentRect
styleMask:(NSUInteger)aStyle backing:(NSBackingStoreType)bufferingType
defer:(BOOL)flag;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0~~~~~~~~~~ ^
3 warnings and 1 error generated.
make[1]: *** [nsmenu.o] Error 1
make: *** [src] Error 2
make failed



On Mac OS X 10.6 (Snow Leopard):
=C2=A0 CC=C2=A0 =C2=A0 =C2=A0 =C2=A0nsterm.o
In file included from nsterm.m:48:
nsterm.h:454: error: expected ')' before 'instancetype'
nsterm.h:455: error: expected ')' before 'instancetype'
nsterm.h:456: error: expected ')' before 'instancetype'
nsterm.h:460: error: expected ')' before 'instancetype'
nsterm.h:463: error: expected ')' before 'instancetype'
nsterm.h:523: error: expected ')' before 'instancetype'
nsterm.h:557: error: expected ')' before 'instancetype'
nsterm.h:592: error: expected ')' before 'instancetype'
nsterm.h:611: error: expected ')' before 'instancetype'
nsterm.h:659: error: expected ')' before 'instancetype'
nsterm.h:661: error: expected ')' before 'instancetype'
nsterm.h:663: error: expected ')' before 'instancetype'
nsterm.h:664: error: expected ')' before 'instancetype'
nsterm.h:703: error: expected ')' before 'instancetype'
nsterm.h:706: error: expected ')' before 'instancetype'
nsterm.h:710: error: expected ')' before 'instancetype'
nsterm.h:711: error: expected ')' before 'instancetype'
nsterm.h:712: error: expected ')' before 'instancetype'
nsterm.h:735: error: expected ')' before 'instancetype'
nsterm.m:6900: error: expected ')' before 'instancetype' nsterm.m:7630: error: expected ')' before 'instancetype' nsterm.m:7655: error: expected ')' before 'instancetype' nsterm.m:7681: error: expected ')' before 'instancetype' nsterm.m:7909: error: expected ')' before 'instancetype' nsterm.m:8261: error: expected ')' before 'instancetype' nsterm.m:8345: error: expected ')' before 'instancetype' nsterm.m:8353: error: expected ')' before 'instancetype' nsterm.m:8408: error: expected ')' before 'instancetype' nsterm.m:8487: error: expected ')' before 'instancetype' make[1]: *** [nsterm.o] Error 1
make: *** [src] Error 2
make failed


I think these may have been caused by the recent GNUStep changes.

Can you try applying the following patch:<= /div>

diff --git a/src/nsterm.h b/src/nsterm.h
index 8f3d92b353..288b91269d 100644
--- a/src/nsterm.h
+++ b/src/nsterm.h
@@ -65,7 +65,7 @@ typedef float EmacsCGFloat;=
=C2=A0/* FIXME: instancetype is a language built-in, but older v= ersions of
=C2=A0 =C2=A0 Clang don't support it, and I don= 9;t know if GCC supports it at all.
=C2=A0 =C2=A0 Should this be = tested for in ./configure? */
-#if defined (NS_IMPL_GNUSTEP)
+#if defined (NS_IMPL_GNUSTEP) \
=C2=A0 =C2=A0 =C2=A0|| MAC= _OS_X_VERSION_MAX_ALLOWED < MAC_OS_X_VERSION_10_10
=C2=A0typed= ef id instancetype;
=C2=A0typedef NSUInteger NSWindowStyleMask;

--001a11455dfe9b731f05504ad589--