From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 2/2] Check for __attribute__ ((cleanup)) during configuration. Date: Sun, 28 Apr 2019 20:12:05 +0200 Message-ID: References: <20190425134609.39314-1-phst@google.com> <20190425134609.39314-2-phst@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="60739"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Philipp Stephani , Emacs developers To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 28 20:17:36 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hKoMp-000Fgj-L8 for ged-emacs-devel@m.gmane.org; Sun, 28 Apr 2019 20:17:35 +0200 Original-Received: from localhost ([127.0.0.1]:47126 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hKoMo-0004Rd-DL for ged-emacs-devel@m.gmane.org; Sun, 28 Apr 2019 14:17:34 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44454) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hKoMi-0004RQ-3t for emacs-devel@gnu.org; Sun, 28 Apr 2019 14:17:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hKoHW-0006P0-Ez for emacs-devel@gnu.org; Sun, 28 Apr 2019 14:12:11 -0400 Original-Received: from mail-oi1-x244.google.com ([2607:f8b0:4864:20::244]:38685) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hKoHV-0006My-TT for emacs-devel@gnu.org; Sun, 28 Apr 2019 14:12:06 -0400 Original-Received: by mail-oi1-x244.google.com with SMTP id t70so1117162oif.5 for ; Sun, 28 Apr 2019 11:12:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Iwul+2PAfYGrqIDcYOOlZy6sjmDVHDqFPtfYyuEHgvc=; b=Lv5JZyninGfk7grQWrbuY25nTKyedlB8rFFSyJfEevtX3uOUxBabZEia/W3qyNopy1 SKnfbL4uprr7L3Oku1szoCkSNYsxxgDZi3PfbQh06XGGYwJ/wMWwtLa5yNeTzsmrwJIL fQiQZe3P50Rei+uIyTQ3jdIomooQJAC/DbIOGEq39G+EbBippjC/U6PLcmBPDDsz+gZV VUZOPbq2StDynU/gCMiiTXkvK04OYyfNudzBSwyIMPvfhRf4gu37e9eOARmF1197fvBo vbNXpSpgPAWVd6mVLLxbZU/SPV9S6krG/cFOqC3dbDuqWzm5W/XQk6inArcmlj18JZK0 D0OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Iwul+2PAfYGrqIDcYOOlZy6sjmDVHDqFPtfYyuEHgvc=; b=WYMFSC59L5KNuQ5yQOgPG2Oqo0GrJfjdyPeiEe12YAu3niFKsRk82pIkqiVaOHH08h fkOEn2K+GtjU0wa31CmAt4cTz1qvtU0+tHMSNRVHYrISIHq7nFQZYLdKSHMp1wt1tC7g UhJYVepYwHOotnO1/XLShnsP4PhQPwr6mREMxu6Cuaame9Y+I7LyTVefon7IWf2aRhUz olt/XFQSfNtDTu13aZED74ABb7p/Mbq5AbhKMk93SAIBG1SE+si3XZpVron63XwdKjec V/hNcQ17ECkgD0CjlbQR7zqu3Szo5bkNXlPxvjeMW48MMOCdnR/Oy0lLSuyuXxJfauLi PomA== X-Gm-Message-State: APjAAAV1ytENZC1gF0G931XQpLkVvv2aZhQcDasVT1NlKnBOI/oGHQig eyq+Awnz+dgv8GqkKR+nShx2SKh+e+kmrI0RwD0= X-Google-Smtp-Source: APXvYqy5RrX6QXC+vAnAnWybnRyRgx/RyyjTG8a4oB32puLQURXLv8iobRQQVDsrjoSvr1ESJ0cijeWOfQAcKsiM804= X-Received: by 2002:aca:d90a:: with SMTP id q10mr14285738oig.65.1556475124388; Sun, 28 Apr 2019 11:12:04 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::244 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236008 Archived-At: Am Do., 25. Apr. 2019 um 23:18 Uhr schrieb Paul Eggert = : > > On 4/25/19 6:46 AM, Philipp Stephani wrote: > > It=E2=80=99s nicer to fail early if __attribute__ ((cleanup)) doesn=E2= =80=99t work. > > Yes, but it's not nicer to make 'configure' slower than it already is. > As the slowness happens to every builder, whereas the "fail early" > problem happens only to the tiny minority of builders who configure > --with-modules but whose compilers don't support __attribute__ > ((cleanup)), it might be better to omit this unnecessary complication. > Fine with me.