From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: Emacs 26 MacOS bugs Date: Sun, 11 Feb 2018 13:53:10 +0000 Message-ID: References: <20180206190518.f43jsoughhlsi22y@adversary.org> <20180206222722.5uf43fd56p44dk5z@adversary.org> <20180207004331.q4cll6nyldse2bin@adversary.org> <20180207021301.zpvpexdkewztqxo4@adversary.org> <20180207225505.GB1066@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a113aad98a895d90564f015ec" X-Trace: blaine.gmane.org 1518357116 7300 195.159.176.226 (11 Feb 2018 13:51:56 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 11 Feb 2018 13:51:56 +0000 (UTC) Cc: Ben McGinnes , Emacs developers , Noam Postavsky To: Alan Third Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 11 14:51:52 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eks2X-0000Ol-SU for ged-emacs-devel@m.gmane.org; Sun, 11 Feb 2018 14:51:34 +0100 Original-Received: from localhost ([::1]:40671 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eks4Z-00024t-JL for ged-emacs-devel@m.gmane.org; Sun, 11 Feb 2018 08:53:39 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50361) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eks4K-000239-Mq for emacs-devel@gnu.org; Sun, 11 Feb 2018 08:53:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eks4J-0005MR-T2 for emacs-devel@gnu.org; Sun, 11 Feb 2018 08:53:24 -0500 Original-Received: from mail-lf0-x22c.google.com ([2a00:1450:4010:c07::22c]:41170) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eks4J-0005KW-LZ for emacs-devel@gnu.org; Sun, 11 Feb 2018 08:53:23 -0500 Original-Received: by mail-lf0-x22c.google.com with SMTP id f136so17114757lff.8 for ; Sun, 11 Feb 2018 05:53:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qBpAYbPZGQrOPYNrRJNvjFmtbjgqo/FgxRqkS18orbQ=; b=l9ya+MG6NPM7N0Xj05d4ZuvMs5q9L3kFqd2HN4to7cuW4mQEzsrx/VkHzJbC8ScAdi W9zR1k4DJ19z+oEQbwQiZc5NHVsRTmO16rYchm72t4CzjyW37hmLuWUUKq04lk4cPG0f Obr39VJKaqHK9HRxjSPD/8ricuCaMzaqTFcwdrr5ISdUs6daov34ZmUk2Gz6pei4UY0m dGo17I+lmlJQIojdWu67TPhPkK9nhVmPt7+3LU6CFHkoIAPvW6HIoGYuH1rtDssLzYTL V7c+SyH4cA3T3mXuuqPW6J0QhsecsN0q3VWoEEMYl/FyhOjm7SaFjkSEc3MoRJQ+POCp Xh/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qBpAYbPZGQrOPYNrRJNvjFmtbjgqo/FgxRqkS18orbQ=; b=a2Gg7gJztG9p5L6Uj0zFekyPSE5fepK4EkPGow0kdSJUNE8mm/+4+VrxA9LS1J6W3m FJEnB+dVIJPMc/wlBPyKTnZlEF7SfvIq1YepWzwHyAYTE0dFBpLmQ1SwByY5TxQxmPTR bP7y4GybtPyzDEgs7RUekxtFzaFJj3VvjVZExZco9rtoiuaEtSnU4tbMAyMPwiRne2r1 JSTPU4eqYSaGb7/dSruphzd5cJ0dWCsUwV2DmOH+lHGQ+WQkfC0Q5C2UsAP8Ag5qw/p0 Y412lTEY1UwuHsM68T4a2fhnFglrssXo5zg94NGm3n4DcvrbsYcl3np5j93roVeUvDyj lxoQ== X-Gm-Message-State: APf1xPAu6XEm/PwlFMFK2Bq2UAFvMh4NveKyFCn/7JvixnKdbSCud6fy tVusnQBXJDngBt5+kxqv6YTpSXLOonk/qqtDwDjmeQ== X-Google-Smtp-Source: AH8x225c++MzR83+l5su//FsO5KF3AABW7j4KInBWF/uRa7BzFtdLuh/MVL5qDxLxQmvym1KGm106+Ruvo970CuE6nk= X-Received: by 10.25.35.137 with SMTP id j131mr5989137lfj.17.1518357201849; Sun, 11 Feb 2018 05:53:21 -0800 (PST) In-Reply-To: <20180207225505.GB1066@breton.holly.idiocy.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::22c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222664 Archived-At: --001a113aad98a895d90564f015ec Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Alan Third schrieb am Mi., 7. Feb. 2018 um 23:55 Uhr: > On Wed, Feb 07, 2018 at 01:13:01PM +1100, Ben McGinnes wrote: > > Philipp, it seems that EV_MODIFIERS2 was quite, quite broken. I=E2=80=99v= e > split it into various parts and tried to fix it. > > Additionally the fn key has some strange interactions with =E2=80=98funct= ion=E2=80=99 > keys, like the Fx keys, arrows, tab and so on. The old code simply > didn=E2=80=99t set its modifier when those keys were used, so I=E2=80=99v= e followed > that lead and am XORing it out of emacs_event->modifiers. > > Sounds good, feel free to install the patch. Is there some documentation for the strange interactions? If so, please add it to the comment. --001a113aad98a895d90564f015ec Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Alan T= hird <alan@idiocy.org> schrieb= am Mi., 7. Feb. 2018 um 23:55=C2=A0Uhr:
On Wed, Feb 07, 2018 at 01:13:01PM +1100, Ben McGinnes wrote:

Philipp, it seems that EV_MODIFIERS2 was quite, quite broken. I=E2=80=99ve<= br> split it into various parts and tried to fix it.

Additionally the fn key has some strange interactions with =E2=80=98functio= n=E2=80=99
keys, like the Fx keys, arrows, tab and so on. The old code simply
didn=E2=80=99t set its modifier when those keys were used, so I=E2=80=99ve = followed
that lead and am XORing it out of emacs_event->modifiers.


Sounds good, feel free to install the = patch.
Is there some documentation for the strange interactions? = If so, please add it to the comment.=C2=A0
--001a113aad98a895d90564f015ec--