From: Philipp Stephani <p.stephani2@gmail.com>
To: Alan Mackenzie <acm@muc.de>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: Somwhat subtle issues with raw string literals in C++
Date: Thu, 30 Jun 2016 11:35:27 +0000 [thread overview]
Message-ID: <CAArVCkRCkJ=yUw7rs1vyrAFTwKZn937eHGwmwO_tHH35muVTQw@mail.gmail.com> (raw)
In-Reply-To: <20160629135725.GA5327@acm.fritz.box>
[-- Attachment #1: Type: text/plain, Size: 1358 bytes --]
Alan Mackenzie <acm@muc.de> schrieb am Do., 30. Juni 2016 um 07:59 Uhr:
> Hello again, Philipp,
>
> On Tue, Jun 28, 2016 at 03:33:30PM +0000, Philipp Stephani wrote:
> > Hi,
>
> > there still seem to be some subtle issues with detection of raw string
> > literals. Unfortunately they are hard to reproduce. One example that
> fails
> > (for me) with a recent master build is:
>
> > cd /tmp
> > wget
> >
> https://raw.githubusercontent.com/google/protobuf/ef7894e2dc6d287419e42a4fdc52cdfedd386d16/conformance/conformance_test.cc
> > /path/to/emacs -Q +686 conformance_test.cc
>
> > Around that line the fontification of the raw string literals is wrong
> > (quote characters are treated as string terminators), in other parts of
> the
> > file the fontification is correct. This typically happens with files that
> > contain many large raw string literals that contain quote characters.
>
> Again, thanks for the report.
>
> The problem was a mishandling of a cache, with the result that the raw
> string handling code mistakenly believed it was within a string when it
> wasn't, at a critical point in the file.
>
> Would you please try out the following patch and confirm that it fixes
> the problem, or let me know what's still not working properly.
>
>
At least in the case I tested, the patch appears to fix the problem. Thanks
a lot for the quick fix.
[-- Attachment #2: Type: text/html, Size: 1920 bytes --]
next prev parent reply other threads:[~2016-06-30 11:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 15:33 Somwhat subtle issues with raw string literals in C++ Philipp Stephani
2016-06-28 16:06 ` Alan Mackenzie
2016-06-29 13:57 ` Alan Mackenzie
2016-06-30 11:35 ` Philipp Stephani [this message]
2016-06-30 13:07 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAArVCkRCkJ=yUw7rs1vyrAFTwKZn937eHGwmwO_tHH35muVTQw@mail.gmail.com' \
--to=p.stephani2@gmail.com \
--cc=acm@muc.de \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.