From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#30460: [PATCH] Remove :stop key from make-process. Date: Fri, 19 Apr 2019 14:15:10 +0200 Message-ID: References: <20190419110643.33444-1-phst@google.com> <83bm12ck1o.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="54968"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Philipp Stephani , 30460-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 19 14:16:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hHSRA-000ECM-6t for geb-bug-gnu-emacs@m.gmane.org; Fri, 19 Apr 2019 14:16:12 +0200 Original-Received: from localhost ([127.0.0.1]:55978 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHSR9-0007pI-4a for geb-bug-gnu-emacs@m.gmane.org; Fri, 19 Apr 2019 08:16:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40461) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHSR1-0007p3-UQ for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2019 08:16:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hHSR1-0005tF-1l for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2019 08:16:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58234) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hHSR0-0005su-UC for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2019 08:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hHSR0-00088M-OS for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2019 08:16:02 -0400 Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Apr 2019 12:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 30460 X-GNU-PR-Package: emacs Mail-Followup-To: 30460@debbugs.gnu.org, p.stephani2@gmail.com, p.stephani2@gmail.com Original-Received: via spool by 30460-done@debbugs.gnu.org id=D30460.155567613031215 (code D ref 30460); Fri, 19 Apr 2019 12:16:02 +0000 Original-Received: (at 30460-done) by debbugs.gnu.org; 19 Apr 2019 12:15:30 +0000 Original-Received: from localhost ([127.0.0.1]:43543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHSQT-00087O-5N for submit@debbugs.gnu.org; Fri, 19 Apr 2019 08:15:30 -0400 Original-Received: from mail-oi1-f171.google.com ([209.85.167.171]:33430) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHSQR-000879-Fx for 30460-done@debbugs.gnu.org; Fri, 19 Apr 2019 08:15:28 -0400 Original-Received: by mail-oi1-f171.google.com with SMTP id e5so3910772oii.0 for <30460-done@debbugs.gnu.org>; Fri, 19 Apr 2019 05:15:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AYvlUIXKqOPW/Io+ufgVkepaPXBaBNoqQjLC1HTymPU=; b=vc3S8LmOQUdLYJsz89he/9VDlA6v6fupnaP8BxZ/vPjt3Q88D9K82bc+85EtfATXC9 TNpIDaScHDNVJTDAjea0hLU+YQkEPDrilR403iCGYN7SPqFf0OmMZZU/SmM5oWJ1ebsS Y8NnHVDsUf4hoIcDoJt1BTqLsT7a89OOQFtpG6FZ5ZVQ0g9JbNfkh2YVhYeCEjtw32yH v85tWTrv+DfoxFw8LjS5KJ3laxDiP+YQaXOw8M9uJa0JuyqQVdAIyPY8fV5A4jefCKWv 6iaHnBst338SbZDLh7qPBmizdw8qIEApX5wr6vlkFjlI1LLLP+xpzititdNenWo9ti7+ YzDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AYvlUIXKqOPW/Io+ufgVkepaPXBaBNoqQjLC1HTymPU=; b=YGDmVhwqxEDJYaaLviOYsR5Cyhij240DNu9bkHI4Db1khrCNlMrZGtpzF4SJPwRMvp 1WktnEkQxUDsydxzQ7DIRWvu24GnVZvnY6lA7vZhvEeaod+CV8anBLy4z0okP0QmOIHg abIfw+gsJ5ej2ajlytoLmsBfO53yt4sT+l5L1rH4poAH6L2AXRvCvRlmQTtmlFKU6Bs9 yu2ziUDo/Mg3W90+9qU6s1kTre6G5hZukdrp/AZlNP4k8vak0apadQEXEliHDrSROCbI Zek/GGLeeZp1AlJQIBxPzk9QQWV1Drn6usI3gGE4L36BNFtFm28+hv9/8amiNDximx2I AQfQ== X-Gm-Message-State: APjAAAUyn1nCPZhKOH1yHrz8OwfleFYzwpety3Syl0ApIO+w3WA9kBrx EnRFxv4C8R8y2HohYb8DRvBtz94ndHAq2wUVK3E= X-Google-Smtp-Source: APXvYqzYUlGTSb+urFdDgPwXFVBX0kVa0LmDtORZV4AX5OF01ZsAwaO9xuTuNwLx7haR/5uZVTEpMIKFDdEnWnbDd1M= X-Received: by 2002:aca:310a:: with SMTP id x10mr1740908oix.161.1555676121513; Fri, 19 Apr 2019 05:15:21 -0700 (PDT) In-Reply-To: <83bm12ck1o.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157833 Archived-At: Am Fr., 19. Apr. 2019 um 13:27 Uhr schrieb Eli Zaretskii : > > > From: Philipp Stephani > > Cc: 30460@debbugs.gnu.org, > > Philipp Stephani > > Date: Fri, 19 Apr 2019 13:06:43 +0200 > > > > This has never worked and caused issues such as Bug#30460. > > > > * src/process.c (Fmake_process): Don't accept :stop key any more. > > (syms_of_process): Define needed symbol 'null'. > > > > * test/src/process-tests.el (make-process/stop): New unit test. > > > > * doc/lispref/processes.texi (Asynchronous Processes): Remove :stop > > key from manual. > > Please don't remove that, but instead document that it's an error to > use that keyword. OK, I've reworded it a bit and pushed as 5c5e309527.