From: Philipp Stephani <p.stephani2@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Philipp Stephani <phst@google.com>, 30460-done@debbugs.gnu.org
Subject: bug#30460: [PATCH] Remove :stop key from make-process.
Date: Fri, 19 Apr 2019 14:15:10 +0200 [thread overview]
Message-ID: <CAArVCkRCWJCXO8f2zGvtmvjTayG7Zjpqt5On-9YeazFrvkusbg@mail.gmail.com> (raw)
In-Reply-To: <83bm12ck1o.fsf@gnu.org>
Am Fr., 19. Apr. 2019 um 13:27 Uhr schrieb Eli Zaretskii <eliz@gnu.org>:
>
> > From: Philipp Stephani <p.stephani2@gmail.com>
> > Cc: 30460@debbugs.gnu.org,
> > Philipp Stephani <phst@google.com>
> > Date: Fri, 19 Apr 2019 13:06:43 +0200
> >
> > This has never worked and caused issues such as Bug#30460.
> >
> > * src/process.c (Fmake_process): Don't accept :stop key any more.
> > (syms_of_process): Define needed symbol 'null'.
> >
> > * test/src/process-tests.el (make-process/stop): New unit test.
> >
> > * doc/lispref/processes.texi (Asynchronous Processes): Remove :stop
> > key from manual.
>
> Please don't remove that, but instead document that it's an error to
> use that keyword.
OK, I've reworded it a bit and pushed as 5c5e309527.
prev parent reply other threads:[~2019-04-19 12:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 22:00 bug#30460: 27.0.50; `process-command' of a stopped process is t p.stephani2
2018-02-17 13:25 ` Eli Zaretskii
2019-04-19 11:05 ` Philipp Stephani
2019-04-19 11:06 ` bug#30460: [PATCH] Remove :stop key from make-process Philipp Stephani
2019-04-19 11:26 ` Eli Zaretskii
2019-04-19 12:15 ` Philipp Stephani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAArVCkRCWJCXO8f2zGvtmvjTayG7Zjpqt5On-9YeazFrvkusbg@mail.gmail.com \
--to=p.stephani2@gmail.com \
--cc=30460-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=phst@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.