From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el Date: Wed, 28 Dec 2016 18:22:45 +0000 Message-ID: References: <6d0c8c2e-8428-2fdb-0d6e-899f7b9d7ffd@nifty.com> <8053af81-80e1-a24a-f649-8ffc86963ed5@nifty.com> <0cc7fab4-9a2c-6a8d-def7-36bd50317ca3@yandex.ru> <7f9a799f-de88-fd78-0cdc-dac0928f1503@nifty.com> <308bb78f-8be3-092d-d877-e129d340242b@nifty.com> <4dc615e7-ec73-60a5-426e-0d6986f15d76@yandex.ru> <0cb406fb-ffc4-a4ad-557a-2cacc99b8e75@nifty.com> <86ccb4af-5719-c017-26bb-fc06b4c904d2@yandex.ru> <83r35uxkr5.fsf@gnu.org> <4e12d4ad-cd6b-3087-5d7c-449d4c1886e2@yandex.ru> <83lgw1q9uu.fsf@gnu.org> <83eg1tq8is.fsf@gnu.org> <787e5206-53e0-752f-a339-4608d2f7ad39@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11444f22cacb580544bc0ef1 X-Trace: blaine.gmane.org 1482949428 14694 195.159.176.226 (28 Dec 2016 18:23:48 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 28 Dec 2016 18:23:48 +0000 (UTC) Cc: Eli Zaretskii , kentaro.nakazawa@nifty.com, emacs-devel@gnu.org To: Lars Ingebrigtsen , Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 28 19:23:42 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cMIt3-0002lq-RX for ged-emacs-devel@m.gmane.org; Wed, 28 Dec 2016 19:23:42 +0100 Original-Received: from localhost ([::1]:60415 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cMIt7-000818-30 for ged-emacs-devel@m.gmane.org; Wed, 28 Dec 2016 13:23:45 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cMIsU-00080z-Kt for emacs-devel@gnu.org; Wed, 28 Dec 2016 13:23:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cMIsQ-0004Dr-D2 for emacs-devel@gnu.org; Wed, 28 Dec 2016 13:23:06 -0500 Original-Received: from mail-wm0-x22d.google.com ([2a00:1450:400c:c09::22d]:37552) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cMIsL-0004DA-Dn; Wed, 28 Dec 2016 13:22:57 -0500 Original-Received: by mail-wm0-x22d.google.com with SMTP id t79so315578413wmt.0; Wed, 28 Dec 2016 10:22:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QF8wFC/QId39a4ZbQt6G1tX9ELcj5JggFCV2/H6sXcY=; b=ogurpRqy+1RKgnjXVxQi84ZnwhlxNnauLY/NpzwO52/CiHhTpmu1b2VaeKCmITQsL4 +Im2CLAFvZNrw/hm7nALsqezrvAsVw6yUHRvl1g2kgbSY/QGlWfmvglmutog9OlAnm/r 2pBCLen/ZtaZgH63iVwH+jlo8XlxnMgSIN+L+538X2nkmbMXsm9SYFEdqVzKV12FLst4 MxrChvKflT64ov3geQYIMeRPXHBWJJql/j+pDclffgqyq31I6JSd0/DiXXqpehXjjpUS cSUEoCIGfEmyGZCcidcXmBvQWuiv7klA7tk1iBho8bzVfav63pb3rpw3c+2XAF8BaSBK tWLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QF8wFC/QId39a4ZbQt6G1tX9ELcj5JggFCV2/H6sXcY=; b=CrdQoe4yRqRw+JA6YEYt+c4CPzHCUzOx8E6xmKyAn6pJ/5BRo78EBOLoWH/D7SR4SK FY1KKi/qhpJ99QZhMjGIppYOG/VCyIrkAm+SXVQP6hU23vXay3wJ2FlqEnzx5uVvfOB7 Fng7sBn6mrM5UsnFKSuVq0enAzOzI8MaMGqyS74u+ZDR7M3m1f1P99bOn/gnDwpIFm1R Afev6NVNeLBV2AtjD65tJtsMyxEw3k7esigxSRU7/HuG+9FH+9/n2+Iyv8XBdTPYlHUq tk8nMKHm2ybEB6iYQWZy7kDoy3vdk8vR5RroOTdD+BzbnHETM1hKf8uooZHwk8uK5Wkd 6qLQ== X-Gm-Message-State: AIkVDXKblTX7M/QPtB1lGNsQs0llMqebzhUyDXHBPcHApdoSfNpwYQRX0/06kxuGgzbtQ5+aq+n14CTEvTNKvQ== X-Received: by 10.28.87.21 with SMTP id l21mr17590373wmb.48.1482949376260; Wed, 28 Dec 2016 10:22:56 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210918 Archived-At: --001a11444f22cacb580544bc0ef1 Content-Type: text/plain; charset=UTF-8 Lars Ingebrigtsen schrieb am Mi., 30. Nov. 2016 um 16:48 Uhr: > Dmitry Gutov writes: > > > In json-encode? Should it really deal with that concern explicitly? > > > > I could understand an idea along the lines of "use a different > > algorithm", but calling encode-coding-string inside json-encode sounds > > odd. > > Yes, this is not a json.el problem at all. It does the correct thing, > and shouldn't be changed. > Agreed. Neither symbol-function nor concat nor the JSON function do anything wrong here. > > It's just url.el being lacking in features, as usual. > > > I don't think url.el needs to grow features for encoding; after all, Emacs already has functions for that. I'd rather add an explicit check for unibyte-ness of url-request-data and document that url-request-data must be a unibyte string or nil. --001a11444f22cacb580544bc0ef1 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Lars I= ngebrigtsen <larsi@gnus.org> sc= hrieb am Mi., 30. Nov. 2016 um 16:48=C2=A0Uhr:
Dmitry Gutov <dgutov@yandex.ru> writes:

> In json-encode? Should it really deal with that concern explicitly? >
> I could understand an idea along the lines of "use a different > algorithm", but calling encode-coding-string inside json-encode s= ounds
> odd.

Yes, this is not a json.el problem at all.=C2=A0 It does the correct thing,=
and shouldn't be changed.

=
Agreed. Neither symbol-function nor concat nor the JSON function= do anything wrong here.
=C2=A0

It's just url.el being lacking in features, as usual.



I don't think = url.el needs to grow features for encoding; after all, Emacs already has fu= nctions for that. I'd rather add an explicit check for unibyte-ness of = url-request-data and document that url-request-data must be a unibyte strin= g or nil.=C2=A0
--001a11444f22cacb580544bc0ef1--