From: Philipp Stephani <p.stephani2@gmail.com>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 41099@debbugs.gnu.org, Michael Albinus <michael.albinus@gmx.de>
Subject: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process
Date: Thu, 14 May 2020 16:48:22 +0200 [thread overview]
Message-ID: <CAArVCkR6Vb8tyWRMuA5wF4MQ=vJQCF954x=Y9Ozj1karL75gRw@mail.gmail.com> (raw)
In-Reply-To: <85zhaafw4k.fsf@gmail.com>
Am Do., 14. Mai 2020 um 16:07 Uhr schrieb Noam Postavsky <npostavs@gmail.com>:
>
> Philipp Stephani <p.stephani2@gmail.com> writes:
>
> > Am Do., 14. Mai 2020 um 13:00 Uhr schrieb Michael Albinus
> > <michael.albinus@gmx.de>:
>
> >> I see. A short test shows, that git is using exit code 129 in case of
> >> error in invocation, although it isn't documented in the man pages.
> >>
> >> Hmm, this seems to be a contradiction to the specification of reserved
> >> exit codes, as described in <https://tldp.org/LDP/abs/html/exitcodes.html>.
> >> We cannot change git
> >
> > We can at least file a bug against Git.
> >
> >> so either
> >>
> >> - we keep Tramp's process-file implementation as it is,
> >
> > I'd (naturally) prefer that way. Exit codes > 128 are nonportable, as
> > they don't allow shells to detect signals.
>
> I don't think this is a correct description. Bash has the convention
> that it uses codes > 128 to indicate commands terminated by signals.
> But processes other than bash (like git) don't necessarily follow this
> convention. The shell can still detect the signals, it's shell
> *scripts* that will have the problem (when running commands that use
> exit codes > 128).
Yes, I mean scripts here. (TRAMP essentially runs a bunch of shell scripts.)
Since Unix binaries get invoked from shell scripts regularly, they
better behave in a predictable way. Bash scripts will regularly assume
that an exit code > 128 means termination by signal, so these binaries
are not portable in that sense.
>
> >> - we don't return a string in case a signal has interrupted the process,
>
> Since we don't have a reliable way to detect signals, I think this is
> the only viable option.
I'd expect the vast majority of programs to avoid such exit codes,
precisely because they would want to allow portable usage in shell
scripts. So I expect that the current behavior in master provides the
"correct" result in the majority of cases.
next prev parent reply other threads:[~2020-05-14 14:48 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 18:49 bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process Philipp Stephani
2020-05-05 19:02 ` Philipp Stephani
2020-05-05 19:25 ` Michael Albinus
2020-05-06 8:38 ` Michael Albinus
2020-05-06 10:38 ` Philipp Stephani
2020-05-06 10:50 ` Philipp Stephani
2020-05-06 11:24 ` Michael Albinus
2020-05-06 13:32 ` Michael Albinus
2020-05-06 15:36 ` Philipp Stephani
2020-05-06 17:30 ` Michael Albinus
2020-05-06 17:56 ` Philipp Stephani
2020-05-06 17:57 ` Philipp Stephani
2020-05-06 19:33 ` Michael Albinus
2020-05-07 8:29 ` Michael Albinus
2020-05-09 19:53 ` Philipp Stephani
2020-05-14 1:39 ` Noam Postavsky
2020-05-14 11:00 ` Michael Albinus
2020-05-14 12:38 ` Philipp Stephani
2020-05-14 12:50 ` Andreas Schwab
2020-05-14 14:07 ` Noam Postavsky
2020-05-14 14:48 ` Philipp Stephani [this message]
2020-05-14 15:49 ` Michael Albinus
2020-05-16 12:06 ` Michael Albinus
2020-05-16 12:11 ` Dmitry Gutov
2020-05-16 12:19 ` Michael Albinus
2020-05-16 22:03 ` Dmitry Gutov
2020-05-17 8:19 ` Michael Albinus
2020-05-23 19:17 ` Philipp Stephani
2020-05-23 19:35 ` Michael Albinus
2020-05-23 19:42 ` Philipp Stephani
2020-05-06 17:41 ` Andreas Schwab
2020-05-06 17:53 ` Philipp Stephani
2020-05-06 18:58 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAArVCkR6Vb8tyWRMuA5wF4MQ=vJQCF954x=Y9Ozj1karL75gRw@mail.gmail.com' \
--to=p.stephani2@gmail.com \
--cc=41099@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.