From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: Dynamic modules: MODULE_HANDLE_SIGNALS etc. Date: Sun, 26 Mar 2017 20:18:16 +0000 Message-ID: References: <83mvu1x6t3.fsf@gnu.org> <565779CD.80405@cs.ucla.edu> <83io4nuc68.fsf@gnu.org> <83poy1t927.fsf@gnu.org> <83d1u1t07d.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a1147c434eede68054ba7edf7 X-Trace: blaine.gmane.org 1490559568 2530 195.159.176.226 (26 Mar 2017 20:19:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 26 Mar 2017 20:19:28 +0000 (UTC) Cc: aurelien.aptel+emacs@gmail.com, tzz@lifelogs.com, eggert@cs.ucla.edu, dancol@dancol.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 26 22:19:22 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1csEd4-000733-FY for ged-emacs-devel@m.gmane.org; Sun, 26 Mar 2017 22:19:10 +0200 Original-Received: from localhost ([::1]:42168 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1csEd7-00063I-7e for ged-emacs-devel@m.gmane.org; Sun, 26 Mar 2017 16:19:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56336) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1csEcR-000636-7K for emacs-devel@gnu.org; Sun, 26 Mar 2017 16:18:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1csEcP-0003sq-U1 for emacs-devel@gnu.org; Sun, 26 Mar 2017 16:18:31 -0400 Original-Received: from mail-wr0-x22d.google.com ([2a00:1450:400c:c0c::22d]:36141) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1csEcO-0003qS-2b; Sun, 26 Mar 2017 16:18:28 -0400 Original-Received: by mail-wr0-x22d.google.com with SMTP id w11so17279033wrc.3; Sun, 26 Mar 2017 13:18:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=W7f7N7Qv2Tcyysw+MiGv9sBGtIPBFdxuVtuX4+iN1s8=; b=chJ3OI1qy04AXRxXZ8ueEOwV/D9zVNImk8hQe2ohrKOYzg8NMqVQHynRk2+ZV56L++ TJUHTjfoHYEYyt16hyT8o3LS2xP64Kh34RvauTHPbWonL84iNw1ANrGt39bwOzqSQrea wQdOv0lNMHjhPAutZ60SjXmrGJ2hXYBhaL52Dr0lz5jbeYCsl/qHMZqEtianWUpoGlab OLvEBYWbL649zP3QY7t23szqP4ZkvP1an4IGfknTW0xPcke4qoKJlh4tvex2t3uknEBC A9aHgth5FBjDeJi0qJal0XH5J5z+G5ybxk/x14MK9V83VjMp4iFnEIIqx0cBW5eJBihj L6Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=W7f7N7Qv2Tcyysw+MiGv9sBGtIPBFdxuVtuX4+iN1s8=; b=ctUOYQ069eMA+9emCXpaJm9iV+E6D8PvJWQlGWo4Jp4ClQKWbZ/fR8AVGi+Cvuc6hn KSeD51EdGLjaPrkQ3bwI/I8n9y8PKH6C8ESU1pNb37rjuaSVlM1XNUd4eTelsBScdg4h sxq6INP8CeVodsohKHJJfeAnMkzuSsKBUdTANLqzcCDjaa+UYSEvEDY6GbVDlA96XbgA le2S3iN1e5TFB0IVT6/yCASLCF5KOho0M/iSv1B5oyouIqSXFUsnZQto21S8/ObStGFZ 2O7qacuj0aWGPVgY2iLGkKegECe2UAKlEqbYn0enSBoDt+ZCVV3BC1onKb0YKCZOkjq1 dQBA== X-Gm-Message-State: AFeK/H1uEU/Bzh+2GPv7bsx1pYLhCLGKh57vuDd8r3WAS0KaeJse44fkAoMiOHek0WUxlm35gIxfZSYzHbtY9Q== X-Received: by 10.28.109.93 with SMTP id i90mr6613819wmc.44.1490559507027; Sun, 26 Mar 2017 13:18:27 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213393 Archived-At: --001a1147c434eede68054ba7edf7 Content-Type: text/plain; charset=UTF-8 Philipp Stephani schrieb am So., 20. Dez. 2015 um 22:00 Uhr: > Eli Zaretskii schrieb am So., 20. Dez. 2015 um 19:59 Uhr: > > > From: Philipp Stephani > > Date: Sun, 20 Dec 2015 18:27:19 +0000 > > Cc: eggert@cs.ucla.edu, dancol@dancol.org, tzz@lifelogs.com, > > aurelien.aptel+emacs@gmail.com, emacs-devel@gnu.org > > > > and did you make sure > > that signaling an error from a module still reports the same > > information and backtrace as before the change? > > > > No, but I wouldn't know how the patch should change this. It only > changes an > > implementation detail in the error reporting code of the module > implementation > > itself. > > I provided one such test here: > > http://lists.gnu.org/archive/html/emacs-devel/2015-11/msg02318.html > > and the resulting backtrace here: > > http://lists.gnu.org/archive/html/emacs-devel/2015-11/msg02405.html > > > If we wanted to check the backtrace, I think we should rather add a unit > test > > for it. > > That would be good, thanks. > > > Added a patch to that effect. > Pushed to master as 05bfebfc91. --001a1147c434eede68054ba7edf7 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Philip= p Stephani <p.stephani2@gmail.c= om> schrieb am So., 20. Dez. 2015 um 22:00=C2=A0Uhr:
Eli Zaretskii = <e= liz@gnu.org> schrieb am So., 20. Dez. 2015 um 19:59=C2=A0Uhr:
> From: = Philipp Stephani <p.stephani2@gmail.com>
> Date: Sun, 20 Dec 2015 18:27:19 +0000
> Cc: eggert@cs.ucla.edu, dancol@dancol.org, tzz@lifelogs.com<= /a>,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0aurelien.aptel+emacs@gmail.co= m, emacs-devel@gnu.org
>
>=C2=A0 =C2=A0 =C2=A0and did you make sure
>=C2=A0 =C2=A0 =C2=A0that signaling an error from a module still reports= the same
>=C2=A0 =C2=A0 =C2=A0information and backtrace as before the change?
>
> No, but I wouldn't know how the patch should change this. It only = changes an
> implementation detail in the error reporting code of the module implem= entation
> itself.

I provided one such test here:

=C2=A0 http:/= /lists.gnu.org/archive/html/emacs-devel/2015-11/msg02318.html

and the resulting backtrace here:

=C2=A0 http:/= /lists.gnu.org/archive/html/emacs-devel/2015-11/msg02405.html

> If we wanted to check the backtrace, I think we should rather add a un= it test
> for it.

That would be good, thanks.


Added a patch to that = effect.=C2=A0

Pushed to m= aster as 05bfebfc91.=C2=A0
--001a1147c434eede68054ba7edf7--