From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#28189: 26.0.50; Emacs uses deprecated function gtk_window_parse_geometry Date: Sun, 27 Aug 2017 13:34:14 +0000 Message-ID: References: <599D40CB.1090100@gmx.at> <599D80D1.6090508@gmx.at> <59A13F90.5080804@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a113d5f88952fde0557bc3cf1" X-Trace: blaine.gmane.org 1503840918 10934 195.159.176.226 (27 Aug 2017 13:35:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 27 Aug 2017 13:35:18 +0000 (UTC) To: martin rudalics , 28189@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 27 15:35:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dlxiV-0002Du-Ng for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Aug 2017 15:35:07 +0200 Original-Received: from localhost ([::1]:32778 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dlxic-0001Ru-BF for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Aug 2017 09:35:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52092) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dlxiV-0001QB-M2 for bug-gnu-emacs@gnu.org; Sun, 27 Aug 2017 09:35:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dlxiQ-0007PL-U6 for bug-gnu-emacs@gnu.org; Sun, 27 Aug 2017 09:35:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48453) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dlxiQ-0007P4-PY for bug-gnu-emacs@gnu.org; Sun, 27 Aug 2017 09:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dlxiQ-0006A0-94 for bug-gnu-emacs@gnu.org; Sun, 27 Aug 2017 09:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Aug 2017 13:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28189-submit@debbugs.gnu.org id=B28189.150384087323641 (code B ref 28189); Sun, 27 Aug 2017 13:35:02 +0000 Original-Received: (at 28189) by debbugs.gnu.org; 27 Aug 2017 13:34:33 +0000 Original-Received: from localhost ([127.0.0.1]:57134 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dlxhx-00069F-Iq for submit@debbugs.gnu.org; Sun, 27 Aug 2017 09:34:33 -0400 Original-Received: from mail-oi0-f44.google.com ([209.85.218.44]:36437) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dlxhv-000692-Fv for 28189@debbugs.gnu.org; Sun, 27 Aug 2017 09:34:32 -0400 Original-Received: by mail-oi0-f44.google.com with SMTP id r9so28338531oie.3 for <28189@debbugs.gnu.org>; Sun, 27 Aug 2017 06:34:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=SrUnSguB5iAw6xxrQe+wXJpifcfPW+Aswwp05dp/QRo=; b=s6yMZcZ+440hmGMiHgbix7sqHabO7oDiPxIWR3PU0Uf9H8lSky84HcXHaDZr5mp1dy UOwaTaKBlCD6csL1+cF7PW5CwcKL09vvKv57zG9+x6gcGIpoPvBRDgGfT4XFSa+bejF/ yLL/mhHKkBVroxp4wJU90gZREKxoHeXYX9qs76CpxwE4c/NEr3DLIdVtWJnRe/lvDmBU tfOQCjaF9Li73CVLgjip3gTxIGhz71NjAotGjQPyR66xAVv9qn0qnahcf/C5ZMwg/DKC o/HFFcOY8Ws4eBHeiUziUWtbNhDLSAWAGKVI/O4ms652Gy20IsLY0kkp2314Q+yVYh1D DvqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=SrUnSguB5iAw6xxrQe+wXJpifcfPW+Aswwp05dp/QRo=; b=DwBRK4cu0nOQYR6gdl0XoBaSvz4EnBudVdVk1qNNPMTk1YH5pxAv4t3OznyLGdhsLW MEwGyw9GfMz1mZVvp/VIJbOdyVNek+4g9upEqILoq+qdCPoDmjDAOJY9q1W1W2EmwlhO ULz+RsJ9e2J/J6g1AOE6QnZM2dK7UCLhL9mlgxXXFUbuG29kkh3VE98vl8XVFWqNOYTg I0WzBTmSfItoaByW4JfSt9lyOC3dabJs5U8C7CQwhlbw8jLqJB+8TT2Jqk5RFTvVsekn tiHvy9doVHOPgSMEYm3aF3npFRD+xAYATz7m+mv6yB7Nxk2i42hL8WG/DJnpjk/lmDOM 1XSg== X-Gm-Message-State: AHYfb5hqcDcCBY68dChnmSvsaaEKFfbASlzWULUZquGhAWhKaEokMxe1 qa5Z+UKJ/vWuhNZT9a7eLO9kG2EUlA== X-Received: by 10.202.222.138 with SMTP id v132mr5137752oig.223.1503840865429; Sun, 27 Aug 2017 06:34:25 -0700 (PDT) In-Reply-To: <59A13F90.5080804@gmx.at> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136255 Archived-At: --001a113d5f88952fde0557bc3cf1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable martin rudalics schrieb am Sa., 26. Aug. 2017 um 11:29 Uhr: > > I've attached a patch that fixes all deprecation warnings. It's not > > intended to be installed as-is, more as a baseline for discussion. Som= e > of > > the functions have straightforward replacements, others are harder to > > replace, yet others have vanished altogether. > > I think you should install most of it right now so we have enough time > to test it before a release. There are people who build with GTK 3.22 > and could tell us whether it breaks anything (substantially, at least). > The sooner we know the better. > OK, I've pushed all the "simple" changes for now. > > This one > > +#if GTK_CHECK_VERSION (3, 16, 0) > + emacs_abort (); > +#else > > looks a bit harsh and the corresponding logic appears quite contrived. > Maybe the entire function should be rewritten. > The underlying issue here is that GTK no longer seems to have a concept of a "background color", but Emacs still assumes that concept exists. > > Removing the gtk_adjustment_changed calls should be tested ASAP. How could that be tested? > + /* FIXME: This function assumes that GdkMonitor objects are never > + * destroyed, even if the monitor is unplugged. That=E2=80=99s probab= ly the > + * case, but should be verified. */ > > If this is a problem it is a problem already now. Or am I missing > something? > I think you're right, I've removed the comment. I was concerned about the lifetime of the monitor objects, but I can't imagine this being an issue. > > +#if GTK_CHECK_VERSION (3, 22, 0) > + /* FIXME: We should pass the GDK event to this function instead of > + * synthesizing it. */ > > (I think you might want to get this from event_handler_gdk) > I don't think that's possible, because the filter is run before the GTK event is even created, so it has no access to it. In fact, Emacs appears to swallow most X events before they are translated to GTK events. This should be fixed "for real" by creating a gtk3term, which doesn't use any X functions. It appears to me that the current "X with a bit of GTK sprinkled on top" can't work any more. > > I have no idea about the cairo related change. That's only used for the visible bell, which still works after the change. --001a113d5f88952fde0557bc3cf1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


martin= rudalics <rudalics@gmx.at> sc= hrieb am Sa., 26. Aug. 2017 um 11:29=C2=A0Uhr:
=C2=A0> I've attached a patch that fixes all deprecati= on warnings. It's not
=C2=A0> intended to be installed as-is, more as a baseline for discussio= n. Some of
=C2=A0> the functions have straightforward replacements, others are hard= er to
=C2=A0> replace, yet others have vanished altogether.

I think you should install most of it right now so we have enough time
to test it before a release.=C2=A0 There are people who build with GTK 3.22=
and could tell us whether it breaks anything (substantially, at least).
The sooner we know the better.

OK, I= 9;ve pushed all the "simple" changes for now.
=C2=A0

This one

+#if GTK_CHECK_VERSION (3, 16, 0)
+=C2=A0 =C2=A0 =C2=A0 emacs_abort ();
+#else

looks a bit harsh and the corresponding logic appears quite contrived.
Maybe the entire function should be rewritten.

The underlying issue here is that GTK no longer seems to have a con= cept of a "background color", but Emacs still assumes that concep= t exists.
=C2=A0

Removing the gtk_adjustment_changed calls should be tested ASAP.

How could that be tested?

= =C2=A0=C2=A0
+=C2=A0 /* FIXME: This fun= ction assumes that GdkMonitor objects are never
+=C2=A0 =C2=A0* destroyed, even if the monitor is unplugged.=C2=A0 That=E2= =80=99s probably the
+=C2=A0 =C2=A0* case, but should be verified.=C2=A0 */

If this is a problem it is a problem already now.=C2=A0 Or am I missing
something?

I think you're right, I&= #39;ve removed the comment. I was concerned about the lifetime of the monit= or objects, but I can't imagine this being an issue.
=C2=A0

+#if GTK_CHECK_VERSION (3, 22, 0)
+=C2=A0 /* FIXME: We should pass the GDK event to this function instead of<= br> +=C2=A0 =C2=A0* synthesizing it.=C2=A0 */

(I think you might want to get this from event_handler_gdk)

I don't think that's possible, because the fi= lter is run before the GTK event is even created, so it has no access to it= . In fact, Emacs appears to swallow most X events before they are translate= d to GTK events.
This should be fixed "for real" by cre= ating a gtk3term, which doesn't use any X functions. It appears to me t= hat the current "X with a bit of GTK sprinkled on top" can't = work any more.
=C2=A0

I have no idea about the cairo related change.=C2=A0

<= /div>
That's only used for the visible bell, which still works afte= r the change.=C2=A0
--001a113d5f88952fde0557bc3cf1--