From: Philipp Stephani <p.stephani2@gmail.com>
To: martin rudalics <rudalics@gmx.at>, 28189@debbugs.gnu.org
Subject: bug#28189: 26.0.50; Emacs uses deprecated function gtk_window_parse_geometry
Date: Sun, 27 Aug 2017 13:34:14 +0000 [thread overview]
Message-ID: <CAArVCkR215c7uzKmVqMw_bCPnVvpRJ=LiY_fbzS38=jZx+9rUA@mail.gmail.com> (raw)
In-Reply-To: <59A13F90.5080804@gmx.at>
[-- Attachment #1: Type: text/plain, Size: 2359 bytes --]
martin rudalics <rudalics@gmx.at> schrieb am Sa., 26. Aug. 2017 um
11:29 Uhr:
> > I've attached a patch that fixes all deprecation warnings. It's not
> > intended to be installed as-is, more as a baseline for discussion. Some
> of
> > the functions have straightforward replacements, others are harder to
> > replace, yet others have vanished altogether.
>
> I think you should install most of it right now so we have enough time
> to test it before a release. There are people who build with GTK 3.22
> and could tell us whether it breaks anything (substantially, at least).
> The sooner we know the better.
>
OK, I've pushed all the "simple" changes for now.
>
> This one
>
> +#if GTK_CHECK_VERSION (3, 16, 0)
> + emacs_abort ();
> +#else
>
> looks a bit harsh and the corresponding logic appears quite contrived.
> Maybe the entire function should be rewritten.
>
The underlying issue here is that GTK no longer seems to have a concept of
a "background color", but Emacs still assumes that concept exists.
>
> Removing the gtk_adjustment_changed calls should be tested ASAP.
How could that be tested?
> + /* FIXME: This function assumes that GdkMonitor objects are never
> + * destroyed, even if the monitor is unplugged. That’s probably the
> + * case, but should be verified. */
>
> If this is a problem it is a problem already now. Or am I missing
> something?
>
I think you're right, I've removed the comment. I was concerned about the
lifetime of the monitor objects, but I can't imagine this being an issue.
>
> +#if GTK_CHECK_VERSION (3, 22, 0)
> + /* FIXME: We should pass the GDK event to this function instead of
> + * synthesizing it. */
>
> (I think you might want to get this from event_handler_gdk)
>
I don't think that's possible, because the filter is run before the GTK
event is even created, so it has no access to it. In fact, Emacs appears to
swallow most X events before they are translated to GTK events.
This should be fixed "for real" by creating a gtk3term, which doesn't use
any X functions. It appears to me that the current "X with a bit of GTK
sprinkled on top" can't work any more.
>
> I have no idea about the cairo related change.
That's only used for the visible bell, which still works after the change.
[-- Attachment #2: Type: text/html, Size: 3535 bytes --]
next prev parent reply other threads:[~2017-08-27 13:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 20:22 bug#28189: 26.0.50; Emacs uses deprecated function gtk_window_parse_geometry Philipp
2017-08-23 8:46 ` martin rudalics
2017-08-23 10:38 ` Philipp Stephani
2017-08-23 13:19 ` martin rudalics
2017-08-23 23:26 ` Philipp Stephani
2017-08-24 9:37 ` martin rudalics
2017-08-25 9:28 ` Philipp Stephani
2017-08-26 9:29 ` martin rudalics
2017-08-27 13:34 ` Philipp Stephani [this message]
2017-09-03 11:49 ` martin rudalics
2017-09-19 15:35 ` Philipp Stephani
2017-09-19 16:38 ` Philipp Stephani
2017-09-23 11:22 ` Philipp Stephani
2017-09-23 13:21 ` martin rudalics
2017-09-23 13:28 ` Eli Zaretskii
2017-09-23 16:32 ` Philipp Stephani
2017-09-23 16:48 ` Eli Zaretskii
2017-09-23 18:28 ` martin rudalics
2017-09-23 18:31 ` Eli Zaretskii
2017-09-23 16:36 ` Philipp Stephani
2017-09-23 18:29 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAArVCkR215c7uzKmVqMw_bCPnVvpRJ=LiY_fbzS38=jZx+9rUA@mail.gmail.com' \
--to=p.stephani2@gmail.com \
--cc=28189@debbugs.gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.