bug#33771: 27.0.50; Error building Harfbuzz branch on Debian testing

bug#33771: 27.0.50; Error building Harfbuzz branch on Debian testing

[Philipp]

Got the following compiler error when trying to compile the Harfbuzz
branch:

  CC       ftfont.o
ftfont.c: In function ‘ftfont_shape’:
ftfont.c:2952:7: error: unknown type name ‘OTF’
       OTF *otf = ftfont_get_otf (ftfont_info);
       ^~~
ftfont.c:2952:18: warning: implicit declaration of function ‘ftfont_get_otf’; did you mean ‘ftfont_get_cache’? [-Wimplicit-function-declaration]
       OTF *otf = ftfont_get_otf (ftfont_info);
                  ^~~~~~~~~~~~~~
                  ftfont_get_cache
ftfont.c:2952:18: warning: nested extern declaration of ‘ftfont_get_otf’ [-Wnested-externs]
ftfont.c:2952:18: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
ftfont.c:2954:14: warning: implicit declaration of function ‘ftfont_shape_by_flt’; did you mean ‘ftfont_shape_by_hb’? [-Wimplicit-function-declaration]
       return ftfont_shape_by_flt (lgstring, font, ftfont_info->ft_size->face,
              ^~~~~~~~~~~~~~~~~~~
              ftfont_shape_by_hb
ftfont.c:2954:14: warning: nested extern declaration of ‘ftfont_shape_by_flt’ [-Wnested-externs]
ftfont.c:2954:14: error: incompatible types when returning type ‘int’ but ‘Lisp_Object {aka struct Lisp_Object}’ was expected
       return ftfont_shape_by_flt (lgstring, font, ftfont_info->ft_size->face,
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       otf, &ftfont_info->matrix);
       ~~~~~~~~~~~~~~~~~~~~~~~~~~
ftfont.c:2957:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
Makefile:386: recipe for target 'ftfont.o' failed
make[1]: *** [ftfont.o] Error 1

$ ./config.status --config
'--with-harfbuzz' '--enable-gtk-deprecation-warnings' '--enable-gcc-warnings=warn-only' '--with-modules' '--without-pop' '--with-mailutils' '--enable-checking' '--enable-check-lisp-object-type' 'CFLAGS=-O0 -ggdb3' 'LDFLAGS=-O0'

$ git log -n 1 --oneline
051d65a5a0 (HEAD -> harfbuzz, origin/harfbuzz) Assume hb_ft_font_create_referenced if HarfBuzz



In GNU Emacs 27.0.50 (build 59, x86_64-pc-linux-gnu, GTK+ Version 3.22.24)
 of 2018-12-16
Repository revision: 2f65525774b6e7edf119db678c9eb78cbb84de6a
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.11906000
System Description: Debian GNU/Linux buster/sid

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Configured using:
 'configure --enable-gtk-deprecation-warnings
 --enable-gcc-warnings=warn-only --with-modules --without-pop
 --with-mailutils --enable-checking --enable-check-lisp-object-type
 'CFLAGS=-O0 -ggdb3''

Configured features:
XPM JPEG TIFF GIF PNG SOUND DBUS GSETTINGS GLIB NOTIFY INOTIFY GNUTLS
FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS
JSON GMP

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc dired dired-loaddefs
format-spec rfc822 mml easymenu mml-sec epa derived epg epg-config
gnus-util rmail rmail-loaddefs time-date mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047
rfc2045 ietf-drums mm-util mail-prsvr mail-utils phst pcase ffap
thingatpt url-parse auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache json map url-vars subr-x rx gnutls puny
seq byte-opt gv bytecomp byte-compile cconv dbus xml cl-loaddefs cl-lib
elec-pair mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode elisp-mode lisp-mode prog-mode register page menu-bar
rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core term/tty-colors frame cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote threads dbusbind
inotify dynamic-setting system-font-setting font-render-setting
move-toolbar gtk x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 109228 5116)
 (symbols 48 21803 1)
 (strings 32 32886 1896)
 (string-bytes 1 890091)
 (vectors 16 16542)
 (vector-slots 8 535229 8918)
 (floats 8 51 66)
 (intervals 56 224 0)
 (buffers 992 12))

-- 
Google Germany GmbH
Erika-Mann-Straße 33
80636 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Paul Manicle, Halimah DeLaine Prado

If you received this communication by mistake, please don’t forward it to
anyone else (it may contain confidential or privileged information), please
erase all copies of it, including all attachments, and please let the sender
know it went to the wrong person.  Thanks.

bug#33771: 27.0.50; Error building Harfbuzz branch on Debian testing

[Eli Zaretskii]

> From: Philipp <p.stephani2@gmail.com>
> Date: Sun, 16 Dec 2018 19:57:54 +0100
> 
> 
> Got the following compiler error when trying to compile the Harfbuzz
> branch:
> 
>   CC       ftfont.o
> ftfont.c: In function ‘ftfont_shape’:
> ftfont.c:2952:7: error: unknown type name ‘OTF’
>        OTF *otf = ftfont_get_otf (ftfont_info);
>        ^~~

You are building without libotf?

> ftfont.c:2952:18: warning: implicit declaration of function ‘ftfont_get_otf’; did you mean ‘ftfont_get_cache’? [-Wimplicit-function-declaration]
>        OTF *otf = ftfont_get_otf (ftfont_info);
>                   ^~~~~~~~~~~~~~
>                   ftfont_get_cache
> ftfont.c:2952:18: warning: nested extern declaration of ‘ftfont_get_otf’ [-Wnested-externs]
> ftfont.c:2952:18: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
> ftfont.c:2954:14: warning: implicit declaration of function ‘ftfont_shape_by_flt’; did you mean ‘ftfont_shape_by_hb’? [-Wimplicit-function-declaration]
>        return ftfont_shape_by_flt (lgstring, font, ftfont_info->ft_size->face,
>               ^~~~~~~~~~~~~~~~~~~
>               ftfont_shape_by_hb
> ftfont.c:2954:14: warning: nested extern declaration of ‘ftfont_shape_by_flt’ [-Wnested-externs]
> ftfont.c:2954:14: error: incompatible types when returning type ‘int’ but ‘Lisp_Object {aka struct Lisp_Object}’ was expected
>        return ftfont_shape_by_flt (lgstring, font, ftfont_info->ft_size->face,
>               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>        otf, &ftfont_info->matrix);
>        ~~~~~~~~~~~~~~~~~~~~~~~~~~
> ftfont.c:2957:1: warning: control reaches end of non-void function [-Wreturn-type]
>  }
>  ^
> Makefile:386: recipe for target 'ftfont.o' failed
> make[1]: *** [ftfont.o] Error 1

Does the below fix the problem?

diff --git a/src/ftfont.c b/src/ftfont.c
index bc98896..bbdc936 100644
--- a/src/ftfont.c
+++ b/src/ftfont.c
@@ -2931,7 +2931,7 @@ ftfont_shape_by_hb (Lisp_Object lgstring, FT_Face ft_face, hb_font_t *hb_font,
 
 #endif /* HAVE_HARFBUZZ */
 
-#if defined HAVE_M17N_FLT || defined HAVE_HARFBUZZ
+#if defined HAVE_LIBOTF && (defined HAVE_M17N_FLT || defined HAVE_HARFBUZZ)
 
 Lisp_Object
 ftfont_shape (Lisp_Object lgstring)
@@ -2956,7 +2956,7 @@ ftfont_shape (Lisp_Object lgstring)
     }
 }
 
-#endif /* defined HAVE_M17N_FLT || defined HAVE_HARFBUZZ */
+#endif /* HAVE_LIBOTF && (HAVE_M17N_FLT || defined HAVE_HARFBUZZ) */
 
 static const char *const ftfont_booleans [] = {
   ":antialias",
@@ -3037,7 +3037,7 @@ static struct font_driver const ftfont_driver =
 #ifdef HAVE_LIBOTF
   .otf_capability = ftfont_otf_capability,
 #endif
-#if defined HAVE_M17N_FLT || defined HAVE_HARFBUZZ
+#if defined HAVE_LIBOTF && (defined HAVE_M17N_FLT || defined HAVE_HARFBUZZ)
   .shape = ftfont_shape,
 #endif
 #ifdef HAVE_OTF_GET_VARIATION_GLYPHS

bug#33771: 27.0.50; Error building Harfbuzz branch on Debian testing

[Mike Kupfer]

>   CC       ftfont.o
> ftfont.c: In function ‘ftfont_shape’:
> ftfont.c:2952:7: error: unknown type name ‘OTF’
>        OTF *otf = ftfont_get_otf (ftfont_info);
>        ^~~
[...]

Heh, I was just about to report the same build problem on Solaris 11.4,
which has HarfBuzz but apparently lacks libotf.

mike

bug#33771: 27.0.50; Error building Harfbuzz branch on Debian testing

[Mike Kupfer]

[-- Attachment #1: Type: text/plain, Size: 1618 bytes --]

Eli Zaretskii wrote:

> Does the below fix the problem?

It helps, thanks.  I needed to make a similar change in a few other
places, at least for building on Solaris.  I've attached the patch I
ended up with.

I still can't get a clean build, because of

    Checking /export/home/kupfer/src/emacs-git/lisp/leim/quail/japanese.el ...
    Fatal error 11: Segmentation Fault
    Backtrace:
    /export/home/kupfer/src/emacs-git/src/bootstrap-emacs'emacs_backtrace+0x43 [0x5b63f3]
    /export/home/kupfer/src/emacs-git/src/bootstrap-emacs'terminate_due_to_signal+0x8b [0x59c40b]
    /export/home/kupfer/src/emacs-git/src/bootstrap-emacs'0x1b4cfe [0x5b4cfe]
    /export/home/kupfer/src/emacs-git/src/bootstrap-emacs'deliver_thread_signal.constprop.13+0x2a [0x5b4eea]
    /export/home/kupfer/src/emacs-git/src/bootstrap-emacs'handle_sigsegv+0x1f [0x5b4f4f]
    /lib/amd64/libc.so.1'__sighndlr+0x6 [0x7fffbe44ebe6]
    /lib/amd64/libc.so.1'call_user_handler+0x2f1 [0x7fffbe4406b1]
    /export/home/kupfer/src/emacs-git/src/bootstrap-emacs'decode_char+0x3db [0x53804b]
    /export/home/kupfer/src/emacs-git/src/bootstrap-emacs'decode_coding_iso_2022+0x141e [0x544bde]
    /export/home/kupfer/src/emacs-git/src/bootstrap-emacs'decode_coding+0x18f [0x54976f]
    /export/home/kupfer/src/emacs-git/src/bootstrap-emacs'decode_coding_gap+0x15f [0x550f9f]
    /export/home/kupfer/src/emacs-git/src/bootstrap-emacs'Finsert_file_contents+0x11fb [0x5cf5eb]
    ...

I got the same failure building master, so it's not related to HarfBuzz.
I'll follow up about this second failure when I get some time; maybe
next week.

cheers,
mike


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch: HarfBuzz but no libotf --]
[-- Type: text/x-diff, Size: 2755 bytes --]

diff --git a/src/ftcrfont.c b/src/ftcrfont.c
index 6d74d937a7..ae5b0a92ee 100644
--- a/src/ftcrfont.c
+++ b/src/ftcrfont.c
@@ -302,7 +302,7 @@ struct font_driver const ftcrfont_driver =
 #ifdef HAVE_LIBOTF
   .otf_capability = ftfont_otf_capability,
 #endif
-#if defined HAVE_M17N_FLT || defined HAVE_HARFBUZZ
+#if defined HAVE_LIBOTF && (defined HAVE_M17N_FLT || defined HAVE_HARFBUZZ)
   .shape = ftfont_shape,
 #endif
 #ifdef HAVE_OTF_GET_VARIATION_GLYPHS
diff --git a/src/ftfont.c b/src/ftfont.c
index bc98896393..bbdc936ffd 100644
--- a/src/ftfont.c
+++ b/src/ftfont.c
@@ -2931,7 +2931,7 @@ ftfont_shape_by_hb (Lisp_Object lgstring, FT_Face ft_face, hb_font_t *hb_font,
 
 #endif /* HAVE_HARFBUZZ */
 
-#if defined HAVE_M17N_FLT || defined HAVE_HARFBUZZ
+#if defined HAVE_LIBOTF && (defined HAVE_M17N_FLT || defined HAVE_HARFBUZZ)
 
 Lisp_Object
 ftfont_shape (Lisp_Object lgstring)
@@ -2956,7 +2956,7 @@ ftfont_shape (Lisp_Object lgstring)
     }
 }
 
-#endif /* defined HAVE_M17N_FLT || defined HAVE_HARFBUZZ */
+#endif /* HAVE_LIBOTF && (HAVE_M17N_FLT || defined HAVE_HARFBUZZ) */
 
 static const char *const ftfont_booleans [] = {
   ":antialias",
@@ -3037,7 +3037,7 @@ static struct font_driver const ftfont_driver =
 #ifdef HAVE_LIBOTF
   .otf_capability = ftfont_otf_capability,
 #endif
-#if defined HAVE_M17N_FLT || defined HAVE_HARFBUZZ
+#if defined HAVE_LIBOTF && (defined HAVE_M17N_FLT || defined HAVE_HARFBUZZ)
   .shape = ftfont_shape,
 #endif
 #ifdef HAVE_OTF_GET_VARIATION_GLYPHS
diff --git a/src/ftxfont.c b/src/ftxfont.c
index 4d4ff6ee0c..a30b07636e 100644
--- a/src/ftxfont.c
+++ b/src/ftxfont.c
@@ -359,7 +359,7 @@ struct font_driver const ftxfont_driver =
   .otf_capability = ftfont_otf_capability,
 #endif
   .end_for_frame = ftxfont_end_for_frame,
-#if defined HAVE_M17N_FLT || defined HAVE_HARFBUZZ
+#if defined HAVE_LIBOTF && (defined HAVE_M17N_FLT || defined HAVE_HARFBUZZ)
   .shape = ftfont_shape,
 #endif
 #ifdef HAVE_OTF_GET_VARIATION_GLYPHS
diff --git a/src/xftfont.c b/src/xftfont.c
index e0bd243467..5111936f3e 100644
--- a/src/xftfont.c
+++ b/src/xftfont.c
@@ -672,7 +672,7 @@ xftfont_draw (struct glyph_string *s, int from, int to, int x, int y,
   return len;
 }
 
-#if defined HAVE_M17N_FLT || defined HAVE_HARFBUZZ
+#if defined HAVE_LIBOTF && (defined HAVE_M17N_FLT || defined HAVE_HARFBUZZ)
 static Lisp_Object
 xftfont_shape (Lisp_Object lgstring)
 {
@@ -784,7 +784,7 @@ struct font_driver const xftfont_driver =
   .otf_capability = ftfont_otf_capability,
 #endif
   .end_for_frame = xftfont_end_for_frame,
-#if defined HAVE_M17N_FLT || defined HAVE_HARFBUZZ
+#if defined HAVE_LIBOTF && (defined HAVE_M17N_FLT || defined HAVE_HARFBUZZ)
   .shape = xftfont_shape,
 #endif
 #ifdef HAVE_OTF_GET_VARIATION_GLYPHS

bug#33771: 27.0.50; Error building Harfbuzz branch on Debian testing

[Eli Zaretskii]

> From: Mike Kupfer <mkupfer@alum.berkeley.edu>
> cc: Philipp <p.stephani2@gmail.com>, 33771@debbugs.gnu.org,
>         far.nasiri.m@gmail.com
> Date: Sun, 16 Dec 2018 21:18:04 -0800
> 
> Eli Zaretskii wrote:
> 
> > Does the below fix the problem?
> 
> It helps, thanks.  I needed to make a similar change in a few other
> places, at least for building on Solaris.  I've attached the patch I
> ended up with.

Thanks, pushed.

bug#33771: 27.0.50; Error building Harfbuzz branch on Debian testing

[Philipp Stephani]

Am Mo., 17. Dez. 2018 um 18:11 Uhr schrieb Eli Zaretskii <eliz@gnu.org>:
>
> > From: Mike Kupfer <mkupfer@alum.berkeley.edu>
> > cc: Philipp <p.stephani2@gmail.com>, 33771@debbugs.gnu.org,
> >         far.nasiri.m@gmail.com
> > Date: Sun, 16 Dec 2018 21:18:04 -0800
> >
> > Eli Zaretskii wrote:
> >
> > > Does the below fix the problem?
> >
> > It helps, thanks.  I needed to make a similar change in a few other
> > places, at least for building on Solaris.  I've attached the patch I
> > ended up with.
>
> Thanks, pushed.

Thanks, it seems to build now without errors.
I still get a few warnings though:

  CC       ftfont.o
ftfont.c:2819:1: warning: ‘ftfont_shape_by_hb’ defined but not used
[-Wunused-function]
 ftfont_shape_by_hb (Lisp_Object lgstring, FT_Face ft_face, hb_font_t *hb_font,
 ^~~~~~~~~~~~~~~~~~
ftfont.c:482:1: warning: ‘ftfont_get_hb_font’ defined but not used
[-Wunused-function]
 ftfont_get_hb_font (struct ftfont_info *ftfont_info)
 ^~~~~~~~~~~~~~~~~~

bug#33771: 27.0.50; Error building Harfbuzz branch on Debian testing

[Philipp Stephani]

Am So., 16. Dez. 2018 um 20:52 Uhr schrieb Eli Zaretskii <eliz@gnu.org>:
>
> > From: Philipp <p.stephani2@gmail.com>
> > Date: Sun, 16 Dec 2018 19:57:54 +0100
> >
> >
> > Got the following compiler error when trying to compile the Harfbuzz
> > branch:
> >
> >   CC       ftfont.o
> > ftfont.c: In function ‘ftfont_shape’:
> > ftfont.c:2952:7: error: unknown type name ‘OTF’
> >        OTF *otf = ftfont_get_otf (ftfont_info);
> >        ^~~
>
> You are building without libotf?

Yes, my configure output contains

  Does Emacs use -lotf?                                   no

bug#33771: 27.0.50; Error building Harfbuzz branch on Debian testing

[Eli Zaretskii]

> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Mon, 17 Dec 2018 18:20:28 +0100
> Cc: Mike Kupfer <mkupfer@alum.berkeley.edu>, 33771-done@debbugs.gnu.org, 
> 	far.nasiri.m@gmail.com
> 
> Thanks, it seems to build now without errors.
> I still get a few warnings though:
> 
>   CC       ftfont.o
> ftfont.c:2819:1: warning: ‘ftfont_shape_by_hb’ defined but not used
> [-Wunused-function]
>  ftfont_shape_by_hb (Lisp_Object lgstring, FT_Face ft_face, hb_font_t *hb_font,
>  ^~~~~~~~~~~~~~~~~~
> ftfont.c:482:1: warning: ‘ftfont_get_hb_font’ defined but not used
> [-Wunused-function]
>  ftfont_get_hb_font (struct ftfont_info *ftfont_info)
>  ^~~~~~~~~~~~~~~~~~

I tried to fix that, please test.

bug#33771: 27.0.50; Error building Harfbuzz branch on Debian testing

[Philipp Stephani]

Am Mo., 17. Dez. 2018 um 18:46 Uhr schrieb Eli Zaretskii <eliz@gnu.org>:
>
> > From: Philipp Stephani <p.stephani2@gmail.com>
> > Date: Mon, 17 Dec 2018 18:20:28 +0100
> > Cc: Mike Kupfer <mkupfer@alum.berkeley.edu>, 33771-done@debbugs.gnu.org,
> >       far.nasiri.m@gmail.com
> >
> > Thanks, it seems to build now without errors.
> > I still get a few warnings though:
> >
> >   CC       ftfont.o
> > ftfont.c:2819:1: warning: ‘ftfont_shape_by_hb’ defined but not used
> > [-Wunused-function]
> >  ftfont_shape_by_hb (Lisp_Object lgstring, FT_Face ft_face, hb_font_t *hb_font,
> >  ^~~~~~~~~~~~~~~~~~
> > ftfont.c:482:1: warning: ‘ftfont_get_hb_font’ defined but not used
> > [-Wunused-function]
> >  ftfont_get_hb_font (struct ftfont_info *ftfont_info)
> >  ^~~~~~~~~~~~~~~~~~
>
> I tried to fix that, please test.

Sure, now I get two different warnings:

  CC       ftfont.o
ftfont.c:2804:1: warning: ‘get_hb_unicode_funcs’ defined but not used
[-Wunused-function]
 get_hb_unicode_funcs (void)
 ^~~~~~~~~~~~~~~~~~~~
ftfont.c:482:1: warning: ‘ftfont_get_hb_font’ defined but not used
[-Wunused-function]
 ftfont_get_hb_font (struct ftfont_info *ftfont_info)
 ^~~~~~~~~~~~~~~~~~

bug#33771: 27.0.50; Error building Harfbuzz branch on Debian testing

[Eli Zaretskii]

> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Mon, 17 Dec 2018 21:34:52 +0100
> Cc: Mike Kupfer <mkupfer@alum.berkeley.edu>, 33771@debbugs.gnu.org, 
> 	far.nasiri.m@gmail.com
> 
> > >   CC       ftfont.o
> > > ftfont.c:2819:1: warning: ‘ftfont_shape_by_hb’ defined but not used
> > > [-Wunused-function]
> > >  ftfont_shape_by_hb (Lisp_Object lgstring, FT_Face ft_face, hb_font_t *hb_font,
> > >  ^~~~~~~~~~~~~~~~~~
> > > ftfont.c:482:1: warning: ‘ftfont_get_hb_font’ defined but not used
> > > [-Wunused-function]
> > >  ftfont_get_hb_font (struct ftfont_info *ftfont_info)
> > >  ^~~~~~~~~~~~~~~~~~
> >
> > I tried to fix that, please test.
> 
> Sure, now I get two different warnings:
> 
>   CC       ftfont.o
> ftfont.c:2804:1: warning: ‘get_hb_unicode_funcs’ defined but not used
> [-Wunused-function]
>  get_hb_unicode_funcs (void)
>  ^~~~~~~~~~~~~~~~~~~~
> ftfont.c:482:1: warning: ‘ftfont_get_hb_font’ defined but not used
> [-Wunused-function]
>  ftfont_get_hb_font (struct ftfont_info *ftfont_info)
>  ^~~~~~~~~~~~~~~~~~

Any improvement now?

bug#33771: 27.0.50; Error building Harfbuzz branch on Debian testing

[Philipp Stephani]

Am Di., 18. Dez. 2018 um 16:04 Uhr schrieb Eli Zaretskii <eliz@gnu.org>:
>
> > From: Philipp Stephani <p.stephani2@gmail.com>
> > Date: Mon, 17 Dec 2018 21:34:52 +0100
> > Cc: Mike Kupfer <mkupfer@alum.berkeley.edu>, 33771@debbugs.gnu.org,
> >       far.nasiri.m@gmail.com
> >
> > > >   CC       ftfont.o
> > > > ftfont.c:2819:1: warning: ‘ftfont_shape_by_hb’ defined but not used
> > > > [-Wunused-function]
> > > >  ftfont_shape_by_hb (Lisp_Object lgstring, FT_Face ft_face, hb_font_t *hb_font,
> > > >  ^~~~~~~~~~~~~~~~~~
> > > > ftfont.c:482:1: warning: ‘ftfont_get_hb_font’ defined but not used
> > > > [-Wunused-function]
> > > >  ftfont_get_hb_font (struct ftfont_info *ftfont_info)
> > > >  ^~~~~~~~~~~~~~~~~~
> > >
> > > I tried to fix that, please test.
> >
> > Sure, now I get two different warnings:
> >
> >   CC       ftfont.o
> > ftfont.c:2804:1: warning: ‘get_hb_unicode_funcs’ defined but not used
> > [-Wunused-function]
> >  get_hb_unicode_funcs (void)
> >  ^~~~~~~~~~~~~~~~~~~~
> > ftfont.c:482:1: warning: ‘ftfont_get_hb_font’ defined but not used
> > [-Wunused-function]
> >  ftfont_get_hb_font (struct ftfont_info *ftfont_info)
> >  ^~~~~~~~~~~~~~~~~~
>
> Any improvement now?

We're down to 1 warning:

  CC       ftfont.o
ftfont.c:482:1: warning: ‘ftfont_get_hb_font’ defined but not used
[-Wunused-function]
 ftfont_get_hb_font (struct ftfont_info *ftfont_info)
 ^~~~~~~~~~~~~~~~~~

bug#33771: 27.0.50; Error building Harfbuzz branch on Debian testing

[Eli Zaretskii]

> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Tue, 18 Dec 2018 16:06:48 +0100
> Cc: Mike Kupfer <mkupfer@alum.berkeley.edu>, 33771@debbugs.gnu.org, 
> 	far.nasiri.m@gmail.com
> 
> We're down to 1 warning:
> 
>   CC       ftfont.o
> ftfont.c:482:1: warning: ‘ftfont_get_hb_font’ defined but not used
> [-Wunused-function]
>  ftfont_get_hb_font (struct ftfont_info *ftfont_info)
>  ^~~~~~~~~~~~~~~~~~

Should be fixed now.

bug#33771: 27.0.50; Error building Harfbuzz branch on Debian testing

[Philipp Stephani]

Am Di., 18. Dez. 2018 um 19:47 Uhr schrieb Eli Zaretskii <eliz@gnu.org>:
>
> > From: Philipp Stephani <p.stephani2@gmail.com>
> > Date: Tue, 18 Dec 2018 16:06:48 +0100
> > Cc: Mike Kupfer <mkupfer@alum.berkeley.edu>, 33771@debbugs.gnu.org,
> >       far.nasiri.m@gmail.com
> >
> > We're down to 1 warning:
> >
> >   CC       ftfont.o
> > ftfont.c:482:1: warning: ‘ftfont_get_hb_font’ defined but not used
> > [-Wunused-function]
> >  ftfont_get_hb_font (struct ftfont_info *ftfont_info)
> >  ^~~~~~~~~~~~~~~~~~
>
> Should be fixed now.

Confirmed, thanks.