From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED!not-for-mail
From: Philipp Stephani <p.stephani2@gmail.com>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] Bound index checks in cl-seq functions
Date: Sat, 04 Feb 2017 20:42:10 +0000
Message-ID: <CAArVCkQxrwy-M7dj27y=rLAs=Lu1PSkH9j48V2p+AEjqYnAsgg@mail.gmail.com>
References: <87efzdrjsj.fsf@calancha-pc>
NNTP-Posting-Host: blaine.gmane.org
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary=001a113db4b25894e30547ba6fd3
X-Trace: blaine.gmane.org 1486240960 31288 195.159.176.226 (4 Feb 2017 20:42:40 GMT)
X-Complaints-To: usenet@blaine.gmane.org
NNTP-Posting-Date: Sat, 4 Feb 2017 20:42:40 +0000 (UTC)
To: Tino Calancha <tino.calancha@gmail.com>,
	Emacs developers <emacs-devel@gnu.org>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 04 21:42:35 2017
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
	by blaine.gmane.org with esmtp (Exim 4.84_2)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1ca7AI-0007sL-HC
	for ged-emacs-devel@m.gmane.org; Sat, 04 Feb 2017 21:42:34 +0100
Original-Received: from localhost ([::1]:40811 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1ca7AO-0005i3-0c
	for ged-emacs-devel@m.gmane.org; Sat, 04 Feb 2017 15:42:40 -0500
Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45730)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <p.stephani2@gmail.com>) id 1ca7AA-0005hv-8m
	for emacs-devel@gnu.org; Sat, 04 Feb 2017 15:42:29 -0500
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <p.stephani2@gmail.com>) id 1ca7A6-0000oS-Fo
	for emacs-devel@gnu.org; Sat, 04 Feb 2017 15:42:26 -0500
Original-Received: from mail-ot0-x230.google.com ([2607:f8b0:4003:c0f::230]:36287)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <p.stephani2@gmail.com>)
	id 1ca7A6-0000oJ-5i
	for emacs-devel@gnu.org; Sat, 04 Feb 2017 15:42:22 -0500
Original-Received: by mail-ot0-x230.google.com with SMTP id 32so37994799oth.3
	for <emacs-devel@gnu.org>; Sat, 04 Feb 2017 12:42:21 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
	h=mime-version:references:in-reply-to:from:date:message-id:subject:to; 
	bh=pX+AlwSewRWPyR+RLTDFZf14CmJlzlsXCdLZAaHIZFM=;
	b=ZSuVt9S4VtEV0RbnLRlL6hulSoRiv8vYy+d+zOLtQeXZgHDba4lJrF/Iqu3iry+9lW
	5D9yWZicPLKpvSS1clqVvjBzGvnA66JJu6DZaw+VmTmquyAo/DtLtHu+VBHth0mLPYCT
	VwjxelFOI4axXbvjY3i27EAfIIiKhxCPAALsta+rZre7SJ43pvcx4381xpy90tElpIL5
	WUyrweifBMedijQEGjg8k34CxdZI5xanF/EYXJa16WaIkbgA2PBEZgNrO/WxuNWUTLGO
	5QaoufX/AwNwugP9bMZK+CmX5pIMhF9mo9XsAR8i0+F3sfjXqUvLtJvbZUTbAf/hqOQO
	Y1IQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20161025;
	h=x-gm-message-state:mime-version:references:in-reply-to:from:date
	:message-id:subject:to;
	bh=pX+AlwSewRWPyR+RLTDFZf14CmJlzlsXCdLZAaHIZFM=;
	b=nCjHMyyZcn5gT4/Vtpui15m3Z+4rCJ2Ac6mvBk7E8i1AVfcUNr0TvG74IgXOEjAygK
	CENFskuz9+EwPdGN+7sEMVvhziLL8sko7c2k9xfEVQlA/UYxcS+kM4GjScjFfaGsH9G4
	ea8a6gflzWRbzcKL5uSKI3lBpnLAsAcb+5QLVstpP3CCHMbe6HnQ8ZtQrRbkCl9sUnSJ
	4uqQIJ9fj7QuNjenv4iSWtniIkGOTshcIRXhUouG18IZKt9nEbZC2u+H49Jv8t++KgcB
	UDEKzIKVtb6PsejvqvV5sJJKRgGHDU64jvZVwm6eoSfNHl56Stx7x5gxcvVAGpwRzRqu
	YTOA==
X-Gm-Message-State: AIkVDXKfhNzhpG37oLdSzjVYCEvE0+AyoT7x/2FzE2/mXwXGYj74EV8ll0xzjSWcJkKsIZ3I8qpg/KoJ4uFxXg==
X-Received: by 10.157.37.209 with SMTP id q75mr1898384ota.267.1486240941116;
	Sat, 04 Feb 2017 12:42:21 -0800 (PST)
In-Reply-To: <87efzdrjsj.fsf@calancha-pc>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2607:f8b0:4003:c0f::230
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:211969
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/211969>

--001a113db4b25894e30547ba6fd3
Content-Type: text/plain; charset=UTF-8

Tino Calancha <tino.calancha@gmail.com> schrieb am Sa., 4. Feb. 2017 um
17:41 Uhr:

>
> Consider following evaluations:
>
> (cl-position 2 (list 1 2 3) :start -999)
> => -998
> (cl-position 2 (list 1 2 3) :start 999)
> => nil
> (cl-position 2 (list 1 2 3) :start 1 :end 0)
> => nil
>
> *) In the first two, the indices are out of range.
> *) In the 3rd, the start index is higher than the end index.
>
> Guy L. Steele recommends to throw an error in those cases:
> http://www.lispworks.com/documentation/HyperSpec/Issues/iss332_w.htm
>
> We have partially done the job, at least for `cl-subseq':
> (cl-subseq (list 1 2 3) 999)
> ; Signal: "Bad bounding indices: 999, nil"
>
> (cl-subseq (list 1 2 3) -999)
> ; Signal: "Bad bounding indices: -999, nil"
>
> (cl-subseq (list 1 2 3) -1)
> => (3) ; This is OK as documented in the docstring.
>
> See:
> https://lists.gnu.org/archive/html/emacs-devel/2015-08/msg00182.html
>
> It would be nice if all the sequence functions in cl-seq.el
> throw errors in those situations.
>
> What do you think?
>

I agree that these should throw errors.


> The following patch implements such bounding checks for the indices.
> Comments are very welcome.
>
>
> ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
> From c076a16716d6b9ad5c971d67375223974df53a40 Mon Sep 17 00:00:00 2001
> From: Tino Calancha <tino.calancha@gmail.com>
> Date: Sat, 4 Feb 2017 21:53:48 +0900
> Subject: [PATCH 1/3] cl--parsing-keywords: Check for negative indices
>
> * lisp/emacs-lisp/cl-seq.el (cl--parsing-keywords):
> Throw and error when the user inputs a negative index for the sequence.
> ---
>  lisp/emacs-lisp/cl-seq.el | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/emacs-lisp/cl-seq.el b/lisp/emacs-lisp/cl-seq.el
> index 67ff1a00bd..558adf22fe 100644
> --- a/lisp/emacs-lisp/cl-seq.el
> +++ b/lisp/emacs-lisp/cl-seq.el
> @@ -59,7 +59,13 @@ cl--parsing-keywords
>                     (setq mem `(and ,mem (setq cl-if ,mem) t)))
>                 (list (intern
>                        (format "cl-%s" (substring (symbol-name var) 1)))
> -                     (if (consp x) `(or ,mem ,(car (cdr x))) mem))))
> +                     `(if (and (string-match ":\\(start\\|end\\)"
> (symbol-name ,var))
>

I think you can replace the string-match with (memq ,var '(:start :end))


> +                               (integerp (or ,mem ,(car (cdr-safe x))))
> +                               (not (natnump (or ,mem ,(car (cdr-safe
> x))))))
> +                          (error "Wrong negative index '%s': natnump, %s"
> +                                 (substring (symbol-name ,var) 1)
>

Please use (signal 'args-out-of-range ...) to be more specific and
consistent with similar checks.


> +                                 (or ,mem ,(car (cdr-safe x))))
> +                        (or ,mem ,(car (cdr-safe x)))))))
>             kwords)
>       ,@(append
>          (and (not (eq other-keys t))
> --
> 2.11.0
>
> From 9898718b96109c5815b81f8dc8868de4d86db453 Mon Sep 17 00:00:00 2001
> From: Tino Calancha <tino.calancha@gmail.com>
> Date: Sun, 5 Feb 2017 00:04:12 +0900
> Subject: [PATCH 2/3] cl--check-bound-indices: Check for unbound indices
>
> Throw and error if the user inputs an index higher than the sequence length
> or if :start value is higher than :end value.
> * lisp/emacs-lisp/cl-seq.el (cl--check-bound-indices): New defun.
> (cl-reduce, cl-fill, cl-replace, cl-remove, cl-delete)
> (cl--delete-duplicates, cl-substitute, cl-nsubstitute, cl-position)
> (cl-count, cl-mismatch, cl-search): Use it.
> ---
>  lisp/emacs-lisp/cl-seq.el | 51
> +++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 51 insertions(+)
>
> diff --git a/lisp/emacs-lisp/cl-seq.el b/lisp/emacs-lisp/cl-seq.el
> index 558adf22fe..0cb7ac7bdd 100644
> --- a/lisp/emacs-lisp/cl-seq.el
> +++ b/lisp/emacs-lisp/cl-seq.el
> @@ -42,6 +42,7 @@
>  ;;; Code:
>
>  (require 'cl-lib)
> +(eval-when-compile (require 'subr-x))
>
>  ;; Keyword parsing.
>  ;; This is special-cased here so that we can compile
> @@ -118,6 +119,44 @@ cl-test
>  (defvar cl-if) (defvar cl-if-not)
>  (defvar cl-key)
>
> +;; Throw an error when :start or :end are > sequence length.
> +(defmacro cl--check-bound-indices (cl-seq1 cl-seq2 cl-keys)
> +  (declare (debug t))
> +  `(let ((len1 (length ,cl-seq1))
> +         (len2 (and ,cl-seq2 (length ,cl-seq2)))
> +         (kwds (list :start1 :start2 :start :end1 :end2 :end))
> +         (keys ,cl-keys)
> +         alist)
> +     (while keys
> +       (when (and (memq (car keys) kwds)
> +                  (string-match ":\\(start\\|end\\)\\([1-2]?\\)\\'"
> +                                (symbol-name (car keys))))
> +         (delq (car keys) kwds) ; Ignore succesive equal keys.
> +         (let* ((idx (match-string 2 (symbol-name (car keys))))
> +                (len (if (equal idx "2") len2 len1)))
> +           (when (integerp (cadr keys))
> +             (push (cons (car keys) (cadr keys)) alist))
> +           (when (> (cadr keys) len)
> +             (error "Wrong bounding indices '%s', %s > (length %s), %s"
> +                    (substring (symbol-name (car keys)) 1)
> +                    (cadr keys)
> +                    (concat "cl-seq" idx)
> +                    len))))
> +       (setq keys (cddr keys)))
> +     ;; Check :start value > :end value.
> +     (mapc (lambda (x)
> +             (and-let* ((start (alist-get (car x) alist))
> +                        (end (alist-get (cdr x) alist)))
> +               (when (> start end)
> +                 (error "Bad bounding indices '%s', '%s': %d, %d"
> +                        (substring (symbol-name (car x)) 1)
> +                        (substring (symbol-name (cdr x)) 1)
> +                        start
> +                        end))))
> +           (list (cons :start :end)
> +                 (cons :start1 :end1)
> +                 (cons :start2 :end2)))))
> +
>  ;;;###autoload
>  (defun cl-reduce (cl-func cl-seq &rest cl-keys)
>    "Reduce two-argument FUNCTION across SEQ.
> @@ -134,6 +173,7 @@ cl-reduce
>
>  \n(fn FUNCTION SEQ [KEYWORD VALUE]...)"
>    (cl--parsing-keywords (:from-end (:start 0) :end :initial-value :key) ()
> +    (cl--check-bound-indices cl-seq nil cl-keys)
>      (or (listp cl-seq) (setq cl-seq (append cl-seq nil)))
>      (setq cl-seq (cl-subseq cl-seq cl-start cl-end))
>      (if cl-from-end (setq cl-seq (nreverse cl-seq)))
> @@ -155,6 +195,7 @@ cl-fill
>  \nKeywords supported:  :start :end
>  \n(fn SEQ ITEM [KEYWORD VALUE]...)"
>    (cl--parsing-keywords ((:start 0) :end) ()
> +    (cl--check-bound-indices cl-seq nil cl-keys)
>      (if (listp cl-seq)
>         (let ((p (nthcdr cl-start cl-seq))
>               (n (and cl-end (- cl-end cl-start))))
> @@ -176,6 +217,7 @@ cl-replace
>  \nKeywords supported:  :start1 :end1 :start2 :end2
>  \n(fn SEQ1 SEQ2 [KEYWORD VALUE]...)"
>    (cl--parsing-keywords ((:start1 0) :end1 (:start2 0) :end2) ()
> +    (cl--check-bound-indices cl-seq1 cl-seq2 cl-keys)
>      (if (and (eq cl-seq1 cl-seq2) (<= cl-start2 cl-start1))
>         (or (= cl-start1 cl-start2)
>             (let* ((cl-len (length cl-seq1))
> @@ -225,6 +267,7 @@ cl-remove
>  \n(fn ITEM SEQ [KEYWORD VALUE]...)"
>    (cl--parsing-keywords (:test :test-not :key :if :if-not :count :from-end
>                         (:start 0) :end) ()
> +    (cl--check-bound-indices cl-seq nil cl-keys)
>      (let ((len (length cl-seq)))
>        (if (<= (or cl-count (setq cl-count len)) 0)
>         cl-seq
> @@ -289,6 +332,7 @@ cl-delete
>  \n(fn ITEM SEQ [KEYWORD VALUE]...)"
>    (cl--parsing-keywords (:test :test-not :key :if :if-not :count :from-end
>                         (:start 0) :end) ()
> +    (cl--check-bound-indices cl-seq nil cl-keys)
>      (let ((len (length cl-seq)))
>        (if (<= (or cl-count (setq cl-count len)) 0)
>         cl-seq
> @@ -362,6 +406,7 @@ cl--delete-duplicates
>            ;; We need to parse :if, otherwise `cl-if' is unbound.
>            (:test :test-not :key (:start 0) :end :from-end :if)
>           ()
> +        (cl--check-bound-indices cl-seq nil cl-keys)
>         (if cl-from-end
>             (let ((cl-p (nthcdr cl-start cl-seq)) cl-i)
>               (setq cl-end (- (or cl-end (length cl-seq)) cl-start))
> @@ -407,6 +452,7 @@ cl-substitute
>  \n(fn NEW OLD SEQ [KEYWORD VALUE]...)"
>    (cl--parsing-keywords (:test :test-not :key :if :if-not :count
>                         (:start 0) :end :from-end) ()
> +    (cl--check-bound-indices cl-seq nil cl-keys)
>      (if (or (eq cl-old cl-new)
>             (<= (or cl-count (setq cl-from-end nil
>                                    cl-count (length cl-seq))) 0))
> @@ -448,6 +494,7 @@ cl-nsubstitute
>  \n(fn NEW OLD SEQ [KEYWORD VALUE]...)"
>    (cl--parsing-keywords (:test :test-not :key :if :if-not :count
>                         (:start 0) :end :from-end) ()
> +    (cl--check-bound-indices cl-seq nil cl-keys)
>      (let ((len (length cl-seq)))
>        (or (eq cl-old cl-new) (<= (or cl-count (setq cl-count len)) 0)
>           (if (and (listp cl-seq) (or (not cl-from-end) (> cl-count (/ len
> 2))))
> @@ -524,6 +571,7 @@ cl-position
>  \n(fn ITEM SEQ [KEYWORD VALUE]...)"
>    (cl--parsing-keywords (:test :test-not :key :if :if-not
>                         (:start 0) :end :from-end) ()
> +    (cl--check-bound-indices cl-seq nil cl-keys)
>      (cl--position cl-item cl-seq cl-start cl-end cl-from-end)))
>
>  (defun cl--position (cl-item cl-seq cl-start &optional cl-end cl-from-end)
> @@ -568,6 +616,7 @@ cl-count
>  \nKeywords supported:  :test :test-not :key :start :end
>  \n(fn ITEM SEQ [KEYWORD VALUE]...)"
>    (cl--parsing-keywords (:test :test-not :key :if :if-not (:start 0)
> :end) ()
> +    (cl--check-bound-indices cl-seq nil cl-keys)
>      (let ((cl-count 0) cl-x)
>        (or cl-end (setq cl-end (length cl-seq)))
>        (if (consp cl-seq) (setq cl-seq (nthcdr cl-start cl-seq)))
> @@ -600,6 +649,7 @@ cl-mismatch
>  \n(fn SEQ1 SEQ2 [KEYWORD VALUE]...)"
>    (cl--parsing-keywords (:test :test-not :key :from-end
>                         (:start1 0) :end1 (:start2 0) :end2) ()
> +    (cl--check-bound-indices cl-seq1 cl-seq2 cl-keys)
>      (or cl-end1 (setq cl-end1 (length cl-seq1)))
>      (or cl-end2 (setq cl-end2 (length cl-seq2)))
>      (if cl-from-end
> @@ -631,6 +681,7 @@ cl-search
>  \n(fn SEQ1 SEQ2 [KEYWORD VALUE]...)"
>    (cl--parsing-keywords (:test :test-not :key :from-end
>                         (:start1 0) :end1 (:start2 0) :end2) ()
> +    (cl--check-bound-indices cl-seq1 cl-seq2 cl-keys)
>      (or cl-end1 (setq cl-end1 (length cl-seq1)))
>      (or cl-end2 (setq cl-end2 (length cl-seq2)))
>      (if (>= cl-start1 cl-end1)
> --
> 2.11.0
>
> From 50cce9d03fa96d622d20f2218ec5ddcfeb246425 Mon Sep 17 00:00:00 2001
> From: Tino Calancha <tino.calancha@gmail.com>
> Date: Sun, 5 Feb 2017 01:06:01 +0900
> Subject: [PATCH 3/3] * test/lisp/emacs-lisp/cl-seq-tests.el
>  (cl-seq-check-bounds): New test.
>
> ---
>  test/lisp/emacs-lisp/cl-seq-tests.el | 91
> ++++++++++++++++++++++++++++++++++++
>  1 file changed, 91 insertions(+)
>
> diff --git a/test/lisp/emacs-lisp/cl-seq-tests.el
> b/test/lisp/emacs-lisp/cl-seq-tests.el
> index 61e3d72033..f5ecfe4b92 100644
> --- a/test/lisp/emacs-lisp/cl-seq-tests.el
> +++ b/test/lisp/emacs-lisp/cl-seq-tests.el
> @@ -294,6 +294,7 @@ cl-seq--with-side-effects
>
>  (ert-deftest cl-seq-test-bug24264 ()
>    "Test for http://debbugs.gnu.org/24264 ."
> +  :tags '(:expensive-test)
>    (let ((list  (append (make-list 8000005 1) '(8)))
>          (list2 (make-list 8000005 2)))
>      (should (cl-position 8 list))
> @@ -302,6 +303,96 @@ cl-seq--with-side-effects
>      (should (equal '(2 8) (last (cl-replace list list2) 2)))
>      (should (equal '(1 1) (last (cl-fill list 1) 2)))))
>
> +(ert-deftest cl-seq-check-bounds ()
> +  (let ((lst (list 1 2 3))
> +        (lst2 (list 'a 'b 'c))
> +        ;; t means pass, nil means fails.
> +        (tests '("((lambda (x y) (cl-reduce #'max x :start 1)) . t)"
> +                 "((lambda (x y) (cl-reduce #'max x :start -1)))"
> +                 "((lambda (x y) (cl-reduce #'max x :start 4)))"
> +                 "((lambda (x y) (cl-reduce #'max x :start 2 :end 1)))"
> +                 ;;
> +                 "((lambda (x y) (cl-fill x 'b :start 3)) . t)"
> +                 "((lambda (x y) (cl-fill x 'b :start 4)))"
> +                 "((lambda (x y) (cl-fill x 'b :start -1)))"
> +                 "((lambda (x y) (cl-fill x 'b :start 2 :end 1)))"
> +                 ;;
> +                 "((lambda (x y) (cl-replace x y :start1 3)) . t)"
> +                 "((lambda (x y) (cl-replace x y :start2 3)) . t)"
> +                 "((lambda (x y) (cl-replace x y :start1 4)))"
> +                 "((lambda (x y) (cl-replace x y :start2 4)))"
> +                 "((lambda (x y) (cl-replace x y :start1 -1)))"
> +                 "((lambda (x y) (cl-replace x y :start2 -1)))"
> +                 "((lambda (x y) (cl-replace x y :start1 2 :end1 1)))"
> +                 "((lambda (x y) (cl-replace x y :start2 2 :end2 1)))"
> +                 ;;
> +                 "((lambda (x y) (cl-remove nil x :start 3)) . t)"
> +                 "((lambda (x y) (cl-remove nil x :start 4)))"
> +                 "((lambda (x y) (cl-remove nil x :start -1)))"
> +                 "((lambda (x y) (cl-remove nil x :start 2 :end 1)))"
> +                 ;;
> +                 "((lambda (x y) (cl-delete nil x :start 3)) . t)"
> +                 "((lambda (x y) (cl-delete nil x :start 4)))"
> +                 "((lambda (x y) (cl-delete nil x :start -1)))"
> +                 "((lambda (x y) (cl-delete nil x :start 2 :end 1)))"
> +                 ;;
> +                 "((lambda (x y) (cl-remove-duplicates x :start 3)) . t)"
> +                 "((lambda (x y) (cl-remove-duplicates x :start 4)))"
> +                 "((lambda (x y) (cl-remove-duplicates x :start -1)))"
> +                 "((lambda (x y) (cl-remove-duplicates x :start 2 :end
> 1)))"
> +                 ;;
> +                 "((lambda (x y) (cl-substitute 'foo 2 x :start 3)) . t)"
> +                 "((lambda (x y) (cl-substitute 'foo 2 x :start 4)))"
> +                 "((lambda (x y) (cl-substitute 'foo 2 x :start -1)))"
> +                 "((lambda (x y) (cl-substitute 'foo 2 x :start 2 :end
> 1)))"
> +                 ;;
> +                 "((lambda (x y) (cl-nsubstitute 'foo 2 x :start 3)) . t)"
> +                 "((lambda (x y) (cl-nsubstitute 'foo 2 x :start 4)))"
> +                 "((lambda (x y) (cl-nsubstitute 'foo 2 x :start -1)))"
> +                 "((lambda (x y) (cl-nsubstitute 'foo 2 x :start 2 :end
> 1)))"
> +                 ;;
> +                 "((lambda (x y) (cl-position 2 x :start 4)))"
> +                 "((lambda (x y) (cl-position 2 x :start -1)))"
> +                 "((lambda (x y) (cl-position 2 x :start 2 :end 1)))"
> +                 ;;
> +                 "((lambda (x y) (cl-count 2 x :start 3)) . t)"
> +                 "((lambda (x y) (cl-count 2 x :start 4)))"
> +                 "((lambda (x y) (cl-count 2 x :start -1)))"
> +                 "((lambda (x y) (cl-count 2 x :start 2 :end 1)))"
> +                 ;;
> +                 "((lambda (x y) (cl-mismatch x x :start1 1 :start2 3)) .
> t)"
> +                 "((lambda (x y) (cl-mismatch x x :start1 1 :start2 4)))"
> +                 "((lambda (x y) (cl-mismatch x x :start1 4 :start2 1)))"
> +                 "((lambda (x y) (cl-mismatch x x :start1 -1 :start2 1)))"
> +                 "((lambda (x y) (cl-mismatch x x :start1 1 :start2 -1)))"
> +                 "((lambda (x y) (cl-mismatch x x :start1 2 :end1 1)))"
> +                 "((lambda (x y) (cl-mismatch x x :start2 2 :end2 1)))"
> +                 ;;
> +                 "((lambda (x y) (cl-search x x :start1 3 :start2 3)) .
> t)"
> +                 "((lambda (x y) (cl-search x x :start1 4 :start2 4)))"
> +                 "((lambda (x y) (cl-search x x :start1 -1 :start2 3)))"
> +                 "((lambda (x y) (cl-search x x :start1 1 :start2 -1)))"
> +                 "((lambda (x y) (cl-search x x :start1 2 :end1 1)))"
> +                 "((lambda (x y) (cl-search x x :start2 2 :end2 1)))"
> +                 ;;
> +                 "((lambda (x y) (cl-subseq x -1)) . t)"
> +                 "((lambda (x y) (cl-subseq x -2 -1)) . t)"
> +                 "((lambda (x y) (cl-subseq x -4)))"
> +                 "((lambda (x y) (cl-subseq x 2 1)))")))
> +    (dolist (limit '("start" "end"))
> +      (dolist (x tests)
> +        (let ((form
> +               (car
> +                (read-from-string
> +                 (cond ((string-match ":start\\([1-2]?\\) \\([0-9-]+\\)
> :end\\([1-2]?\\)" x)
> +                        x)
> +                       ((string= limit "start") x)
> +                       (t
> +                        (replace-regexp-in-string "start" limit x)))))))
> +          (if (cdr form)
> +              (should (funcall (car form) lst lst2))
> +            (should-error (funcall (car form) lst lst2))))))))
> +
>
>  (provide 'cl-seq-tests)
>  ;;; cl-seq-tests.el ends here
> --
> 2.11.0
>
>
> ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
> In GNU Emacs 26.0.50.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.7)
>  of 2017-02-04
> Repository revision: ff4dd0d39c3f5dfb8f4988f840c2c05621db32db
>
>

--001a113db4b25894e30547ba6fd3
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><br><div class=3D"gmail_quote"><div dir=3D"ltr">Tino C=
alancha &lt;<a href=3D"mailto:tino.calancha@gmail.com">tino.calancha@gmail.=
com</a>&gt; schrieb am Sa., 4. Feb. 2017 um 17:41=C2=A0Uhr:<br></div><block=
quote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc=
 solid;padding-left:1ex"><br class=3D"gmail_msg">
Consider following evaluations:<br class=3D"gmail_msg">
<br class=3D"gmail_msg">
(cl-position 2 (list 1 2 3) :start -999)<br class=3D"gmail_msg">
=3D&gt; -998<br class=3D"gmail_msg">
(cl-position 2 (list 1 2 3) :start 999)<br class=3D"gmail_msg">
=3D&gt; nil<br class=3D"gmail_msg">
(cl-position 2 (list 1 2 3) :start 1 :end 0)<br class=3D"gmail_msg">
=3D&gt; nil<br class=3D"gmail_msg">
<br class=3D"gmail_msg">
*) In the first two, the indices are out of range.<br class=3D"gmail_msg">
*) In the 3rd, the start index is higher than the end index.<br class=3D"gm=
ail_msg">
<br class=3D"gmail_msg">
Guy L. Steele recommends to throw an error in those cases:<br class=3D"gmai=
l_msg">
<a href=3D"http://www.lispworks.com/documentation/HyperSpec/Issues/iss332_w=
.htm" rel=3D"noreferrer" class=3D"gmail_msg" target=3D"_blank">http://www.l=
ispworks.com/documentation/HyperSpec/Issues/iss332_w.htm</a><br class=3D"gm=
ail_msg">
<br class=3D"gmail_msg">
We have partially done the job, at least for `cl-subseq&#39;:<br class=3D"g=
mail_msg">
(cl-subseq (list 1 2 3) 999)<br class=3D"gmail_msg">
; Signal: &quot;Bad bounding indices: 999, nil&quot;<br class=3D"gmail_msg"=
>
<br class=3D"gmail_msg">
(cl-subseq (list 1 2 3) -999)<br class=3D"gmail_msg">
; Signal: &quot;Bad bounding indices: -999, nil&quot;<br class=3D"gmail_msg=
">
<br class=3D"gmail_msg">
(cl-subseq (list 1 2 3) -1)<br class=3D"gmail_msg">
=3D&gt; (3) ; This is OK as documented in the docstring.<br class=3D"gmail_=
msg">
<br class=3D"gmail_msg">
See:<br class=3D"gmail_msg">
<a href=3D"https://lists.gnu.org/archive/html/emacs-devel/2015-08/msg00182.=
html" rel=3D"noreferrer" class=3D"gmail_msg" target=3D"_blank">https://list=
s.gnu.org/archive/html/emacs-devel/2015-08/msg00182.html</a><br class=3D"gm=
ail_msg">
<br class=3D"gmail_msg">
It would be nice if all the sequence functions in cl-seq.el<br class=3D"gma=
il_msg">
throw errors in those situations.<br class=3D"gmail_msg">
<br class=3D"gmail_msg">
What do you think?<br class=3D"gmail_msg"></blockquote><div><br></div><div>=
I agree that these should throw errors.</div><div>=C2=A0</div><blockquote c=
lass=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;=
padding-left:1ex">
The following patch implements such bounding checks for the indices.<br cla=
ss=3D"gmail_msg">
Comments are very welcome.<br class=3D"gmail_msg">
<br class=3D"gmail_msg">
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;=
;;;;<br class=3D"gmail_msg">
>From c076a16716d6b9ad5c971d67375223974df53a40 Mon Sep 17 00:00:00 2001<br c=
lass=3D"gmail_msg">
From: Tino Calancha &lt;<a href=3D"mailto:tino.calancha@gmail.com" class=3D=
"gmail_msg" target=3D"_blank">tino.calancha@gmail.com</a>&gt;<br class=3D"g=
mail_msg">
Date: Sat, 4 Feb 2017 21:53:48 +0900<br class=3D"gmail_msg">
Subject: [PATCH 1/3] cl--parsing-keywords: Check for negative indices<br cl=
ass=3D"gmail_msg">
<br class=3D"gmail_msg">
* lisp/emacs-lisp/cl-seq.el (cl--parsing-keywords):<br class=3D"gmail_msg">
Throw and error when the user inputs a negative index for the sequence.<br =
class=3D"gmail_msg">
---<br class=3D"gmail_msg">
=C2=A0lisp/emacs-lisp/cl-seq.el | 8 +++++++-<br class=3D"gmail_msg">
=C2=A01 file changed, 7 insertions(+), 1 deletion(-)<br class=3D"gmail_msg"=
>
<br class=3D"gmail_msg">
diff --git a/lisp/emacs-lisp/cl-seq.el b/lisp/emacs-lisp/cl-seq.el<br class=
=3D"gmail_msg">
index 67ff1a00bd..558adf22fe 100644<br class=3D"gmail_msg">
--- a/lisp/emacs-lisp/cl-seq.el<br class=3D"gmail_msg">
+++ b/lisp/emacs-lisp/cl-seq.el<br class=3D"gmail_msg">
@@ -59,7 +59,13 @@ cl--parsing-keywords<br class=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (setq=
 mem `(and ,mem (setq cl-if ,mem) t)))<br class=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (list (intern<br cl=
ass=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0(format &quot;cl-%s&quot; (substring (symbol-name var) 1)))<br cl=
ass=3D"gmail_msg">
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0(if (consp x) `(or ,mem ,(car (cdr x))) mem))))<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0`(if (and (string-match &quot;:\\(start\\|end\\)&quot; (symbol-name ,var=
))<br class=3D"gmail_msg"></blockquote><div><br></div><div>I think you can =
replace the string-match with (memq ,var &#39;(:start :end))</div><div>=C2=
=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;borde=
r-left:1px #ccc solid;padding-left:1ex">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(integerp (or ,mem ,(car (cdr-safe x)=
)))<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(not (natnump (or ,mem ,(car (cdr-saf=
e x))))))<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 (error &quot;Wrong negative index &#39;%s&#39;: natnump, =
%s&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(substring (symbol-name ,var) =
1)<br class=3D"gmail_msg"></blockquote><div><br></div><div>Please use (sign=
al &#39;args-out-of-range ...) to be more specific and consistent with simi=
lar checks.</div><div>=C2=A0</div><blockquote class=3D"gmail_quote" style=
=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(or ,mem ,(car (cdr-safe x))))=
<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 (or ,mem ,(car (cdr-safe x)))))))<br class=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 kwords)<br class=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0 ,@(append<br class=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(and (not (eq other-keys t))<br class=3D"=
gmail_msg">
--<br class=3D"gmail_msg">
2.11.0<br class=3D"gmail_msg">
<br class=3D"gmail_msg">
>From 9898718b96109c5815b81f8dc8868de4d86db453 Mon Sep 17 00:00:00 2001<br c=
lass=3D"gmail_msg">
From: Tino Calancha &lt;<a href=3D"mailto:tino.calancha@gmail.com" class=3D=
"gmail_msg" target=3D"_blank">tino.calancha@gmail.com</a>&gt;<br class=3D"g=
mail_msg">
Date: Sun, 5 Feb 2017 00:04:12 +0900<br class=3D"gmail_msg">
Subject: [PATCH 2/3] cl--check-bound-indices: Check for unbound indices<br =
class=3D"gmail_msg">
<br class=3D"gmail_msg">
Throw and error if the user inputs an index higher than the sequence length=
<br class=3D"gmail_msg">
or if :start value is higher than :end value.<br class=3D"gmail_msg">
* lisp/emacs-lisp/cl-seq.el (cl--check-bound-indices): New defun.<br class=
=3D"gmail_msg">
(cl-reduce, cl-fill, cl-replace, cl-remove, cl-delete)<br class=3D"gmail_ms=
g">
(cl--delete-duplicates, cl-substitute, cl-nsubstitute, cl-position)<br clas=
s=3D"gmail_msg">
(cl-count, cl-mismatch, cl-search): Use it.<br class=3D"gmail_msg">
---<br class=3D"gmail_msg">
=C2=A0lisp/emacs-lisp/cl-seq.el | 51 ++++++++++++++++++++++++++++++++++++++=
+++++++++<br class=3D"gmail_msg">
=C2=A01 file changed, 51 insertions(+)<br class=3D"gmail_msg">
<br class=3D"gmail_msg">
diff --git a/lisp/emacs-lisp/cl-seq.el b/lisp/emacs-lisp/cl-seq.el<br class=
=3D"gmail_msg">
index 558adf22fe..0cb7ac7bdd 100644<br class=3D"gmail_msg">
--- a/lisp/emacs-lisp/cl-seq.el<br class=3D"gmail_msg">
+++ b/lisp/emacs-lisp/cl-seq.el<br class=3D"gmail_msg">
@@ -42,6 +42,7 @@<br class=3D"gmail_msg">
=C2=A0;;; Code:<br class=3D"gmail_msg">
<br class=3D"gmail_msg">
=C2=A0(require &#39;cl-lib)<br class=3D"gmail_msg">
+(eval-when-compile (require &#39;subr-x))<br class=3D"gmail_msg">
<br class=3D"gmail_msg">
=C2=A0;; Keyword parsing.<br class=3D"gmail_msg">
=C2=A0;; This is special-cased here so that we can compile<br class=3D"gmai=
l_msg">
@@ -118,6 +119,44 @@ cl-test<br class=3D"gmail_msg">
=C2=A0(defvar cl-if) (defvar cl-if-not)<br class=3D"gmail_msg">
=C2=A0(defvar cl-key)<br class=3D"gmail_msg">
<br class=3D"gmail_msg">
+;; Throw an error when :start or :end are &gt; sequence length.<br class=
=3D"gmail_msg">
+(defmacro cl--check-bound-indices (cl-seq1 cl-seq2 cl-keys)<br class=3D"gm=
ail_msg">
+=C2=A0 (declare (debug t))<br class=3D"gmail_msg">
+=C2=A0 `(let ((len1 (length ,cl-seq1))<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(len2 (and ,cl-seq2 (length ,cl-seq2)))<=
br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(kwds (list :start1 :start2 :start :end1=
 :end2 :end))<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(keys ,cl-keys)<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0alist)<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0(while keys<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0(when (and (memq (car keys) kwds)<br class=3D"g=
mail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (string-mat=
ch &quot;:\\(start\\|end\\)\\([1-2]?\\)\\&#39;&quot;<br class=3D"gmail_msg"=
>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (symbol-name (car keys))))<br class=
=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(delq (car keys) kwds) ; Ignore succesiv=
e equal keys.<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(let* ((idx (match-string 2 (symbol-name=
 (car keys))))<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (len (if (equal id=
x &quot;2&quot;) len2 len1)))<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(when (integerp (cadr keys))<br c=
lass=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(push (cons (car keys) (ca=
dr keys)) alist))<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(when (&gt; (cadr keys) len)<br c=
lass=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(error &quot;Wrong boundin=
g indices &#39;%s&#39;, %s &gt; (length %s), %s&quot;<br class=3D"gmail_msg=
">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (sub=
string (symbol-name (car keys)) 1)<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (cad=
r keys)<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (con=
cat &quot;cl-seq&quot; idx)<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 len)=
)))<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0(setq keys (cddr keys)))<br class=3D"gmail_msg"=
>
+=C2=A0 =C2=A0 =C2=A0;; Check :start value &gt; :end value.<br class=3D"gma=
il_msg">
+=C2=A0 =C2=A0 =C2=A0(mapc (lambda (x)<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(and-let* ((start (alist-g=
et (car x) alist))<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 (end (alist-get (cdr x) alist)))<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(when (&gt; start e=
nd)<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(error &quot=
;Bad bounding indices &#39;%s&#39;, &#39;%s&#39;: %d, %d&quot;<br class=3D"=
gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 (substring (symbol-name (car x)) 1)<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 (substring (symbol-name (cdr x)) 1)<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 start<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 end))))<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(list (cons :start :end)<br class=
=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(cons :start=
1 :end1)<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(cons :start=
2 :end2)))))<br class=3D"gmail_msg">
+<br class=3D"gmail_msg">
=C2=A0;;;###autoload<br class=3D"gmail_msg">
=C2=A0(defun cl-reduce (cl-func cl-seq &amp;rest cl-keys)<br class=3D"gmail=
_msg">
=C2=A0 =C2=A0&quot;Reduce two-argument FUNCTION across SEQ.<br class=3D"gma=
il_msg">
@@ -134,6 +173,7 @@ cl-reduce<br class=3D"gmail_msg">
<br class=3D"gmail_msg">
=C2=A0\n(fn FUNCTION SEQ [KEYWORD VALUE]...)&quot;<br class=3D"gmail_msg">
=C2=A0 =C2=A0(cl--parsing-keywords (:from-end (:start 0) :end :initial-valu=
e :key) ()<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 (cl--check-bound-indices cl-seq nil cl-keys)<br class=3D"gma=
il_msg">
=C2=A0 =C2=A0 =C2=A0(or (listp cl-seq) (setq cl-seq (append cl-seq nil)))<b=
r class=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0(setq cl-seq (cl-subseq cl-seq cl-start cl-end))<br cla=
ss=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0(if cl-from-end (setq cl-seq (nreverse cl-seq)))<br cla=
ss=3D"gmail_msg">
@@ -155,6 +195,7 @@ cl-fill<br class=3D"gmail_msg">
=C2=A0\nKeywords supported:=C2=A0 :start :end<br class=3D"gmail_msg">
=C2=A0\n(fn SEQ ITEM [KEYWORD VALUE]...)&quot;<br class=3D"gmail_msg">
=C2=A0 =C2=A0(cl--parsing-keywords ((:start 0) :end) ()<br class=3D"gmail_m=
sg">
+=C2=A0 =C2=A0 (cl--check-bound-indices cl-seq nil cl-keys)<br class=3D"gma=
il_msg">
=C2=A0 =C2=A0 =C2=A0(if (listp cl-seq)<br class=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (let ((p (nthcdr cl-start cl-seq))<br class=3D"=
gmail_msg">
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (n (and cl-end (- cl-end c=
l-start))))<br class=3D"gmail_msg">
@@ -176,6 +217,7 @@ cl-replace<br class=3D"gmail_msg">
=C2=A0\nKeywords supported:=C2=A0 :start1 :end1 :start2 :end2<br class=3D"g=
mail_msg">
=C2=A0\n(fn SEQ1 SEQ2 [KEYWORD VALUE]...)&quot;<br class=3D"gmail_msg">
=C2=A0 =C2=A0(cl--parsing-keywords ((:start1 0) :end1 (:start2 0) :end2) ()=
<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 (cl--check-bound-indices cl-seq1 cl-seq2 cl-keys)<br class=
=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0(if (and (eq cl-seq1 cl-seq2) (&lt;=3D cl-start2 cl-sta=
rt1))<br class=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (or (=3D cl-start1 cl-start2)<br class=3D"gmail=
_msg">
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (let* ((cl-len (length cl-seq1))<=
br class=3D"gmail_msg">
@@ -225,6 +267,7 @@ cl-remove<br class=3D"gmail_msg">
=C2=A0\n(fn ITEM SEQ [KEYWORD VALUE]...)&quot;<br class=3D"gmail_msg">
=C2=A0 =C2=A0(cl--parsing-keywords (:test :test-not :key :if :if-not :count=
 :from-end<br class=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 (:start 0) :end) ()<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 (cl--check-bound-indices cl-seq nil cl-keys)<br class=3D"gma=
il_msg">
=C2=A0 =C2=A0 =C2=A0(let ((len (length cl-seq)))<br class=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0 =C2=A0(if (&lt;=3D (or cl-count (setq cl-count len)) 0=
)<br class=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0 =C2=A0 cl-seq<br class=3D"gmail_msg">
@@ -289,6 +332,7 @@ cl-delete<br class=3D"gmail_msg">
=C2=A0\n(fn ITEM SEQ [KEYWORD VALUE]...)&quot;<br class=3D"gmail_msg">
=C2=A0 =C2=A0(cl--parsing-keywords (:test :test-not :key :if :if-not :count=
 :from-end<br class=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 (:start 0) :end) ()<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 (cl--check-bound-indices cl-seq nil cl-keys)<br class=3D"gma=
il_msg">
=C2=A0 =C2=A0 =C2=A0(let ((len (length cl-seq)))<br class=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0 =C2=A0(if (&lt;=3D (or cl-count (setq cl-count len)) 0=
)<br class=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0 =C2=A0 cl-seq<br class=3D"gmail_msg">
@@ -362,6 +406,7 @@ cl--delete-duplicates<br class=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;; We need to parse :if, otherwise=
 `cl-if&#39; is unbound.<br class=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(:test :test-not :key (:start 0) :=
end :from-end :if)<br class=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ()<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 (cl--check-bound-indices cl-seq nil cl-keys)<b=
r class=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (if cl-from-end<br class=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (let ((cl-p (nthcdr cl-start cl-s=
eq)) cl-i)<br class=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (setq cl-end (- (or cl-end=
 (length cl-seq)) cl-start))<br class=3D"gmail_msg">
@@ -407,6 +452,7 @@ cl-substitute<br class=3D"gmail_msg">
=C2=A0\n(fn NEW OLD SEQ [KEYWORD VALUE]...)&quot;<br class=3D"gmail_msg">
=C2=A0 =C2=A0(cl--parsing-keywords (:test :test-not :key :if :if-not :count=
<br class=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 (:start 0) :end :from-end) ()<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 (cl--check-bound-indices cl-seq nil cl-keys)<br class=3D"gma=
il_msg">
=C2=A0 =C2=A0 =C2=A0(if (or (eq cl-old cl-new)<br class=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (&lt;=3D (or cl-count (setq cl-fr=
om-end nil<br class=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0cl-count (length cl-seq=
))) 0))<br class=3D"gmail_msg">
@@ -448,6 +494,7 @@ cl-nsubstitute<br class=3D"gmail_msg">
=C2=A0\n(fn NEW OLD SEQ [KEYWORD VALUE]...)&quot;<br class=3D"gmail_msg">
=C2=A0 =C2=A0(cl--parsing-keywords (:test :test-not :key :if :if-not :count=
<br class=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 (:start 0) :end :from-end) ()<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 (cl--check-bound-indices cl-seq nil cl-keys)<br class=3D"gma=
il_msg">
=C2=A0 =C2=A0 =C2=A0(let ((len (length cl-seq)))<br class=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0 =C2=A0(or (eq cl-old cl-new) (&lt;=3D (or cl-count (se=
tq cl-count len)) 0)<br class=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (if (and (listp cl-seq) (or (not cl-from=
-end) (&gt; cl-count (/ len 2))))<br class=3D"gmail_msg">
@@ -524,6 +571,7 @@ cl-position<br class=3D"gmail_msg">
=C2=A0\n(fn ITEM SEQ [KEYWORD VALUE]...)&quot;<br class=3D"gmail_msg">
=C2=A0 =C2=A0(cl--parsing-keywords (:test :test-not :key :if :if-not<br cla=
ss=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 (:start 0) :end :from-end) ()<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 (cl--check-bound-indices cl-seq nil cl-keys)<br class=3D"gma=
il_msg">
=C2=A0 =C2=A0 =C2=A0(cl--position cl-item cl-seq cl-start cl-end cl-from-en=
d)))<br class=3D"gmail_msg">
<br class=3D"gmail_msg">
=C2=A0(defun cl--position (cl-item cl-seq cl-start &amp;optional cl-end cl-=
from-end)<br class=3D"gmail_msg">
@@ -568,6 +616,7 @@ cl-count<br class=3D"gmail_msg">
=C2=A0\nKeywords supported:=C2=A0 :test :test-not :key :start :end<br class=
=3D"gmail_msg">
=C2=A0\n(fn ITEM SEQ [KEYWORD VALUE]...)&quot;<br class=3D"gmail_msg">
=C2=A0 =C2=A0(cl--parsing-keywords (:test :test-not :key :if :if-not (:star=
t 0) :end) ()<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 (cl--check-bound-indices cl-seq nil cl-keys)<br class=3D"gma=
il_msg">
=C2=A0 =C2=A0 =C2=A0(let ((cl-count 0) cl-x)<br class=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0 =C2=A0(or cl-end (setq cl-end (length cl-seq)))<br cla=
ss=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0 =C2=A0(if (consp cl-seq) (setq cl-seq (nthcdr cl-start=
 cl-seq)))<br class=3D"gmail_msg">
@@ -600,6 +649,7 @@ cl-mismatch<br class=3D"gmail_msg">
=C2=A0\n(fn SEQ1 SEQ2 [KEYWORD VALUE]...)&quot;<br class=3D"gmail_msg">
=C2=A0 =C2=A0(cl--parsing-keywords (:test :test-not :key :from-end<br class=
=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 (:start1 0) :end1 (:start2 0) :end2) ()<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 (cl--check-bound-indices cl-seq1 cl-seq2 cl-keys)<br class=
=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0(or cl-end1 (setq cl-end1 (length cl-seq1)))<br class=
=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0(or cl-end2 (setq cl-end2 (length cl-seq2)))<br class=
=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0(if cl-from-end<br class=3D"gmail_msg">
@@ -631,6 +681,7 @@ cl-search<br class=3D"gmail_msg">
=C2=A0\n(fn SEQ1 SEQ2 [KEYWORD VALUE]...)&quot;<br class=3D"gmail_msg">
=C2=A0 =C2=A0(cl--parsing-keywords (:test :test-not :key :from-end<br class=
=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 (:start1 0) :end1 (:start2 0) :end2) ()<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 (cl--check-bound-indices cl-seq1 cl-seq2 cl-keys)<br class=
=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0(or cl-end1 (setq cl-end1 (length cl-seq1)))<br class=
=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0(or cl-end2 (setq cl-end2 (length cl-seq2)))<br class=
=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0(if (&gt;=3D cl-start1 cl-end1)<br class=3D"gmail_msg">
--<br class=3D"gmail_msg">
2.11.0<br class=3D"gmail_msg">
<br class=3D"gmail_msg">
>From 50cce9d03fa96d622d20f2218ec5ddcfeb246425 Mon Sep 17 00:00:00 2001<br c=
lass=3D"gmail_msg">
From: Tino Calancha &lt;<a href=3D"mailto:tino.calancha@gmail.com" class=3D=
"gmail_msg" target=3D"_blank">tino.calancha@gmail.com</a>&gt;<br class=3D"g=
mail_msg">
Date: Sun, 5 Feb 2017 01:06:01 +0900<br class=3D"gmail_msg">
Subject: [PATCH 3/3] * test/lisp/emacs-lisp/cl-seq-tests.el<br class=3D"gma=
il_msg">
=C2=A0(cl-seq-check-bounds): New test.<br class=3D"gmail_msg">
<br class=3D"gmail_msg">
---<br class=3D"gmail_msg">
=C2=A0test/lisp/emacs-lisp/cl-seq-tests.el | 91 +++++++++++++++++++++++++++=
+++++++++<br class=3D"gmail_msg">
=C2=A01 file changed, 91 insertions(+)<br class=3D"gmail_msg">
<br class=3D"gmail_msg">
diff --git a/test/lisp/emacs-lisp/cl-seq-tests.el b/test/lisp/emacs-lisp/cl=
-seq-tests.el<br class=3D"gmail_msg">
index 61e3d72033..f5ecfe4b92 100644<br class=3D"gmail_msg">
--- a/test/lisp/emacs-lisp/cl-seq-tests.el<br class=3D"gmail_msg">
+++ b/test/lisp/emacs-lisp/cl-seq-tests.el<br class=3D"gmail_msg">
@@ -294,6 +294,7 @@ cl-seq--with-side-effects<br class=3D"gmail_msg">
<br class=3D"gmail_msg">
=C2=A0(ert-deftest cl-seq-test-bug24264 ()<br class=3D"gmail_msg">
=C2=A0 =C2=A0&quot;Test for <a href=3D"http://debbugs.gnu.org/24264" rel=3D=
"noreferrer" class=3D"gmail_msg" target=3D"_blank">http://debbugs.gnu.org/2=
4264</a> .&quot;<br class=3D"gmail_msg">
+=C2=A0 :tags &#39;(:expensive-test)<br class=3D"gmail_msg">
=C2=A0 =C2=A0(let ((list=C2=A0 (append (make-list 8000005 1) &#39;(8)))<br =
class=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(list2 (make-list 8000005 2)))<br class=
=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0(should (cl-position 8 list))<br class=3D"gmail_msg">
@@ -302,6 +303,96 @@ cl-seq--with-side-effects<br class=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0(should (equal &#39;(2 8) (last (cl-replace list list2)=
 2)))<br class=3D"gmail_msg">
=C2=A0 =C2=A0 =C2=A0(should (equal &#39;(1 1) (last (cl-fill list 1) 2)))))=
<br class=3D"gmail_msg">
<br class=3D"gmail_msg">
+(ert-deftest cl-seq-check-bounds ()<br class=3D"gmail_msg">
+=C2=A0 (let ((lst (list 1 2 3))<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 (lst2 (list &#39;a &#39;b &#39;c))<br class=3D=
"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; t means pass, nil means fails.<br class=3D"=
gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 (tests &#39;(&quot;((lambda (x y) (cl-reduce #=
&#39;max x :start 1)) . t)&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-reduce #&#39;max x :start -1)))&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-reduce #&#39;max x :start 4)))&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-reduce #&#39;max x :start 2 :end 1)))&quot;<br class=3D"gmail_=
msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;;<br class=
=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-fill x &#39;b :start 3)) . t)&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-fill x &#39;b :start 4)))&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-fill x &#39;b :start -1)))&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-fill x &#39;b :start 2 :end 1)))&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;;<br class=
=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-replace x y :start1 3)) . t)&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-replace x y :start2 3)) . t)&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-replace x y :start1 4)))&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-replace x y :start2 4)))&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-replace x y :start1 -1)))&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-replace x y :start2 -1)))&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-replace x y :start1 2 :end1 1)))&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-replace x y :start2 2 :end2 1)))&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;;<br class=
=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-remove nil x :start 3)) . t)&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-remove nil x :start 4)))&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-remove nil x :start -1)))&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-remove nil x :start 2 :end 1)))&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;;<br class=
=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-delete nil x :start 3)) . t)&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-delete nil x :start 4)))&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-delete nil x :start -1)))&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-delete nil x :start 2 :end 1)))&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;;<br class=
=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-remove-duplicates x :start 3)) . t)&quot;<br class=3D"gmail_ms=
g">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-remove-duplicates x :start 4)))&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-remove-duplicates x :start -1)))&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-remove-duplicates x :start 2 :end 1)))&quot;<br class=3D"gmail=
_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;;<br class=
=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-substitute &#39;foo 2 x :start 3)) . t)&quot;<br class=3D"gmai=
l_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-substitute &#39;foo 2 x :start 4)))&quot;<br class=3D"gmail_ms=
g">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-substitute &#39;foo 2 x :start -1)))&quot;<br class=3D"gmail_m=
sg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-substitute &#39;foo 2 x :start 2 :end 1)))&quot;<br class=3D"g=
mail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;;<br class=
=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-nsubstitute &#39;foo 2 x :start 3)) . t)&quot;<br class=3D"gma=
il_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-nsubstitute &#39;foo 2 x :start 4)))&quot;<br class=3D"gmail_m=
sg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-nsubstitute &#39;foo 2 x :start -1)))&quot;<br class=3D"gmail_=
msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-nsubstitute &#39;foo 2 x :start 2 :end 1)))&quot;<br class=3D"=
gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;;<br class=
=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-position 2 x :start 4)))&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-position 2 x :start -1)))&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-position 2 x :start 2 :end 1)))&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;;<br class=
=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-count 2 x :start 3)) . t)&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-count 2 x :start 4)))&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-count 2 x :start -1)))&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-count 2 x :start 2 :end 1)))&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;;<br class=
=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-mismatch x x :start1 1 :start2 3)) . t)&quot;<br class=3D"gmai=
l_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-mismatch x x :start1 1 :start2 4)))&quot;<br class=3D"gmail_ms=
g">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-mismatch x x :start1 4 :start2 1)))&quot;<br class=3D"gmail_ms=
g">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-mismatch x x :start1 -1 :start2 1)))&quot;<br class=3D"gmail_m=
sg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-mismatch x x :start1 1 :start2 -1)))&quot;<br class=3D"gmail_m=
sg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-mismatch x x :start1 2 :end1 1)))&quot;<br class=3D"gmail_msg"=
>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-mismatch x x :start2 2 :end2 1)))&quot;<br class=3D"gmail_msg"=
>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;;<br class=
=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-search x x :start1 3 :start2 3)) . t)&quot;<br class=3D"gmail_=
msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-search x x :start1 4 :start2 4)))&quot;<br class=3D"gmail_msg"=
>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-search x x :start1 -1 :start2 3)))&quot;<br class=3D"gmail_msg=
">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-search x x :start1 1 :start2 -1)))&quot;<br class=3D"gmail_msg=
">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-search x x :start1 2 :end1 1)))&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-search x x :start2 2 :end2 1)))&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;;<br class=
=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-subseq x -1)) . t)&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-subseq x -2 -1)) . t)&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-subseq x -4)))&quot;<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;((lamb=
da (x y) (cl-subseq x 2 1)))&quot;)))<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 (dolist (limit &#39;(&quot;start&quot; &quot;end&quot;))<br =
class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 (dolist (x tests)<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 (let ((form<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(car<br class=3D"gm=
ail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (read-from-string<=
br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(cond ((stri=
ng-match &quot;:start\\([1-2]?\\) \\([0-9-]+\\) :end\\([1-2]?\\)&quot; x)<b=
r class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 x)<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0((string=3D limit &quot;start&quot;) x)<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0(t<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 (replace-regexp-in-string &quot;start&quot; limit x)))))))<br cl=
ass=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (if (cdr form)<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (should (funcall (car for=
m) lst lst2))<br class=3D"gmail_msg">
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (should-error (funcall (car form=
) lst lst2))))))))<br class=3D"gmail_msg">
+<br class=3D"gmail_msg">
<br class=3D"gmail_msg">
=C2=A0(provide &#39;cl-seq-tests)<br class=3D"gmail_msg">
=C2=A0;;; cl-seq-tests.el ends here<br class=3D"gmail_msg">
--<br class=3D"gmail_msg">
2.11.0<br class=3D"gmail_msg">
<br class=3D"gmail_msg">
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;=
;;;;<br class=3D"gmail_msg">
In GNU Emacs 26.0.50.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.7)<br class=
=3D"gmail_msg">
=C2=A0of 2017-02-04<br class=3D"gmail_msg">
Repository revision: ff4dd0d39c3f5dfb8f4988f840c2c05621db32db<br class=3D"g=
mail_msg">
<br class=3D"gmail_msg">
</blockquote></div></div>

--001a113db4b25894e30547ba6fd3--