all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Philipp Stephani <p.stephani2@gmail.com>
To: Glenn Morris <rgm@gnu.org>
Cc: 30106@debbugs.gnu.org, bugs@gnu.support
Subject: bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test'
Date: Wed, 17 Jan 2018 22:16:58 +0000	[thread overview]
Message-ID: <CAArVCkQwOWMK7GvzE=YzcrSx1e_B3Kz+rPHG7BN=vdrEhoa_eg@mail.gmail.com> (raw)
In-Reply-To: <k4a7xcrzz4.fsf@fencepost.gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1456 bytes --]

Glenn Morris <rgm@gnu.org> schrieb am Mi., 17. Jan. 2018 um 21:31 Uhr:

> Eli Zaretskii wrote:
>
> >> Same error on rhel 7.4 if configure with --without-threads
> --with-modules.
> >>
> >>   Emacs module assertion: Module function called from outside the
> current
> >>   Lisp thread
> >
> > Does this go away if you put
> >
> >   return true;
> >
> > at the end of in_current_thread, outside of all the #ifdef's?
>
> No.
>
>
>
>
>
The current implementation of in_current_thread is definitely bogus if
threads are disabled; I can't even compile temacs with --without-threads
--with-modules:

*emacs-module.c:814:42: **error: **incompatible integer to pointer
conversion passing 'sys_thread_t' (aka 'int') to parameter of type
'pthread_t _Nullable'*

*      (aka 'struct _opaque_pthread_t *') [-Werror,-Wint-conversion]*

  return pthread_equal (pthread_self (), current_thread->thread_id);

*                                         ^~~~~~~~~~~~~~~~~~~~~~~~~*

*/usr/include/pthread.h:340:59: note: *passing argument to parameter here

int pthread_equal(pthread_t _Nullable, pthread_t _Nullable);


because if threads are disabled, the thread ID is an int.

The function also doesn't handle the case where neither HAVE_PTHREAD nor
WINDOWSNT are defined (but maybe we don't have such platforms).

Maybe systhread.h should have a function

extern sys_thread_t sys_thread_self ();

so emacs-module.c doesn't have to care about the threading implementations.

[-- Attachment #2: Type: text/html, Size: 2881 bytes --]

  reply	other threads:[~2018-01-17 22:16 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-14  6:36 bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' Jean Louis
2018-01-14 16:08 ` Eli Zaretskii
2018-01-14 17:47   ` Jean Louis
2018-01-14 19:44     ` Eli Zaretskii
2018-01-14 22:12       ` Jean Louis
2018-01-15 13:14         ` Eli Zaretskii
2018-01-15 17:56           ` Glenn Morris
2018-01-18 19:35             ` Philipp Stephani
2018-01-18 23:00               ` Glenn Morris
2018-01-15 18:09           ` Jean Louis
2018-01-15 18:55           ` Jean Louis
2018-01-15 20:15             ` Eli Zaretskii
2018-01-16  5:17               ` Jean Louis
2018-01-16 18:06                 ` Glenn Morris
2018-01-16 19:17                   ` Jean Louis
2018-01-16 18:10             ` Eli Zaretskii
2018-01-16 19:18               ` Jean Louis
2018-01-17 15:36                 ` Eli Zaretskii
2018-01-17 17:03                   ` Jean Louis
2018-01-17 18:25                     ` Eli Zaretskii
2018-01-17 18:51                       ` Glenn Morris
2018-01-17 18:58                         ` Glenn Morris
2018-01-17 19:37                           ` Jean Louis
2018-01-18 23:01                             ` Glenn Morris
2018-01-17 20:05                         ` Eli Zaretskii
2018-01-17 20:29                           ` Glenn Morris
2018-01-17 22:16                             ` Philipp Stephani [this message]
2018-01-17 22:18                               ` Philipp Stephani
2018-01-17 22:28                                 ` bug#30106: [PATCH 1/2] Use recommended long options syntax in man page Philipp Stephani
2018-01-17 22:28                                   ` bug#30106: [PATCH 2/2] Fix module support if threads are disabled (Bug#30106) Philipp Stephani
2018-01-18 14:04                                     ` Eli Zaretskii
2018-01-18 14:23                                       ` Philipp Stephani
2018-01-18 15:23                                         ` Eli Zaretskii
2018-01-18 17:41                                           ` Glenn Morris
2018-01-18 18:53                                             ` Eli Zaretskii
2018-01-18 22:55                                               ` Glenn Morris
2018-01-19  7:58                                                 ` Eli Zaretskii
2018-01-20 18:07                                                   ` Glenn Morris
2018-01-20 19:01                                                     ` Eli Zaretskii
2018-01-18 19:25                                           ` Philipp Stephani
2018-01-17 22:35                                   ` bug#30106: [PATCH 1/2] Use recommended long options syntax in man page Philipp Stephani
2018-01-18 13:59                               ` bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' Eli Zaretskii
2018-01-18 17:40                               ` Glenn Morris
2018-01-17 19:20                       ` Jean Louis
2018-01-17 18:32                     ` Andy Moreton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAArVCkQwOWMK7GvzE=YzcrSx1e_B3Kz+rPHG7BN=vdrEhoa_eg@mail.gmail.com' \
    --to=p.stephani2@gmail.com \
    --cc=30106@debbugs.gnu.org \
    --cc=bugs@gnu.support \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.