From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#27346: module tests fail to compile with gcc 4.8.5 Date: Tue, 13 Jun 2017 18:50:22 +0000 Message-ID: References: <99r2ypw1ip.fsf@fencepost.gnu.org> <83mv9d3vxw.fsf@gnu.org> <1fvao16jco.fsf@fencepost.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="94eb2c18d98c0a067e0551dbe9d9" X-Trace: blaine.gmane.org 1497379875 26782 195.159.176.226 (13 Jun 2017 18:51:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 13 Jun 2017 18:51:15 +0000 (UTC) Cc: 27346@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 13 20:51:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKquF-0006co-7W for geb-bug-gnu-emacs@m.gmane.org; Tue, 13 Jun 2017 20:51:11 +0200 Original-Received: from localhost ([::1]:44733 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dKquI-0007lq-U6 for geb-bug-gnu-emacs@m.gmane.org; Tue, 13 Jun 2017 14:51:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47882) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dKqu9-0007ll-Is for bug-gnu-emacs@gnu.org; Tue, 13 Jun 2017 14:51:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dKqu6-0004sq-Dk for bug-gnu-emacs@gnu.org; Tue, 13 Jun 2017 14:51:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43542) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dKqu6-0004sm-AJ for bug-gnu-emacs@gnu.org; Tue, 13 Jun 2017 14:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dKqu6-0005hs-0x for bug-gnu-emacs@gnu.org; Tue, 13 Jun 2017 14:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Jun 2017 18:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27346 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27346-submit@debbugs.gnu.org id=B27346.149737984121904 (code B ref 27346); Tue, 13 Jun 2017 18:51:01 +0000 Original-Received: (at 27346) by debbugs.gnu.org; 13 Jun 2017 18:50:41 +0000 Original-Received: from localhost ([127.0.0.1]:46219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKqtk-0005hE-M3 for submit@debbugs.gnu.org; Tue, 13 Jun 2017 14:50:40 -0400 Original-Received: from mail-oi0-f53.google.com ([209.85.218.53]:33920) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKqti-0005h1-PF for 27346@debbugs.gnu.org; Tue, 13 Jun 2017 14:50:39 -0400 Original-Received: by mail-oi0-f53.google.com with SMTP id b6so23888203oia.1 for <27346@debbugs.gnu.org>; Tue, 13 Jun 2017 11:50:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bvvIian/PxLOSf2wBgOkMI1Y0ueSujR4SAwNdJQwRMI=; b=llt2MjR1tgdplQU/3p3OFwj8m6MXYFJi6ZTNpD3N8MrLVuXfvBAxHh9OnvrMPUf1Lx QKaNKFzaQkoFUR3KsvtkSm6DTj+5bMtcpzqkBfsIBJiogGdXnKPSEjWrHPu10SOj3R6o VpMalND5p0wDNAzN3fEXBUC7XAJ/HOxKrgpAl9M92zhYhu2Z/6kVuVp/d/WSynNgYwBK 6BI037bmhSwUEw7EvZn4h7KwdSGNnL/6J0175TcBoJ0/DIrNk/daSKIv7840mDZh5TyG AKajJimkjxdWT7XfawW2maC7pWPQi1LIv/TD1tH86II3DDncRSTwD6OPvnrK7UNAUpZe vsew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bvvIian/PxLOSf2wBgOkMI1Y0ueSujR4SAwNdJQwRMI=; b=RioQPCCTc27uyHuudEy6mNSwk8pPvDT2ob0a9oRl7GNmAD89muDc6I7fRiFc1yGSHt KslaldQHm/4Nunx10kuqm4WiYYYlmB6WpNVuJ+7ECJ5qrvWAjqosGRSEABx1/s7l9D/j V2qWYH6e+YJWHtUiIepZZy65UP+H5g/BAZJnckls1+7XZE6dvJVBwJQLemVO5MAzi4pi B7TSSmn5zkhmNDccMfZfpLrt6foG+7DGJrHziv42/x1eU6HJD1rVduF7ScNyvNLEogHX DbkCF0FrtPsJeyWzVrdO8tkZ9qrJnV6Wa3lECmZuQt3y2PQdAZPprWfwHKefB6gHP0UD oN7w== X-Gm-Message-State: AKS2vOw4UHNKfL6zlZZ52dbwMkRBwI0M2KLKF7jyQmEnP+PPM5mXHTmN 05A2CFGFuvwtx005bja5+aca/aNPLQ== X-Received: by 10.202.6.131 with SMTP id 125mr944665oig.114.1497379832979; Tue, 13 Jun 2017 11:50:32 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133561 Archived-At: --94eb2c18d98c0a067e0551dbe9d9 Content-Type: text/plain; charset="UTF-8" Glenn Morris schrieb am Di., 13. Juni 2017 um 19:04 Uhr: > Philipp Stephani wrote: > > > Does it also work if you run 'make src/emacs-module-tests' from 'test'? > > Yes, it does. > > Although I did change test/data/emacs-module/mod-test.o to not directly > depend on src/emacs-module.c (only on .h), because it doesn't. Depending > on the .c versions seems to me a bit like adding a depending on > "src/emacs", which is strictly true, but would probably be annoying in > practice. But put back the [ch] thing if that's the issue you mean. > No, that dependency would indeed be bogus. I don't remember why I put it into test/Makefile.in in the first place. > > BTW, the relevant rules in test/Makefile are duplicating some of the > logic of those in data/emacs-module/Makefile.in. Perhaps the latter > could be removed. > Yes, I've done that now and at least for me the dependency tracking now works fine. --94eb2c18d98c0a067e0551dbe9d9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Glenn = Morris <rgm@gnu.org> schrieb am Di= ., 13. Juni 2017 um 19:04=C2=A0Uhr:
Philipp Stephani wrote:

> Does it also work if you run 'make src/emacs-module-tests' fro= m 'test'?

Yes, it does.

Although I did change test/data/emacs-module/mod-test.o to not directly
depend on src/emacs-module.c (only on .h), because it doesn't. Dependin= g
on the .c versions seems to me a bit like adding a depending on
"src/emacs", which is strictly true, but would probably be annoyi= ng in
practice. But put back the [ch] thing if that's the issue you mean.
=

No, that dependency would indeed be bogus.= I don't remember why I put it into test/Makefile.in in the first place= .
=C2=A0

BTW, the relevant rules in test/Makefile are duplicating some of the
logic of those in data/emacs-module/Makefile.in. Perhaps the latter
could be removed.

Yes, I've done th= at now and at least for me the dependency tracking now works fine.=C2=A0
--94eb2c18d98c0a067e0551dbe9d9--