From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Enabling --enable-check-lisp-object-type by default on x86 and AMD64 (was: Re: bug#26597: 25.1; Compilation error on master with --enable-check-lisp-object-type) Date: Mon, 01 May 2017 11:32:55 +0000 Message-ID: References: <83mvb8riq0.fsf@gnu.org> <83a878r2d0.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=f403045f572e67a3b7054e74c976 X-Trace: blaine.gmane.org 1493638423 25334 195.159.176.226 (1 May 2017 11:33:43 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 1 May 2017 11:33:43 +0000 (UTC) To: Eli Zaretskii , Emacs developers Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 01 13:33:39 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d59aF-0006WI-F4 for ged-emacs-devel@m.gmane.org; Mon, 01 May 2017 13:33:39 +0200 Original-Received: from localhost ([::1]:53781 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d59aL-00017L-06 for ged-emacs-devel@m.gmane.org; Mon, 01 May 2017 07:33:45 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39606) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d59Zm-000173-1E for emacs-devel@gnu.org; Mon, 01 May 2017 07:33:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d59Zl-0007z0-4V for emacs-devel@gnu.org; Mon, 01 May 2017 07:33:10 -0400 Original-Received: from mail-wr0-x22d.google.com ([2a00:1450:400c:c0c::22d]:33042) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d59Zj-0007yY-AU; Mon, 01 May 2017 07:33:07 -0400 Original-Received: by mail-wr0-x22d.google.com with SMTP id w50so62508797wrc.0; Mon, 01 May 2017 04:33:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=uBLMtqU1I2I9rkxUa69471hS5Ldazz+RxRgueZoMIz4=; b=VJsRXZAzgrlbggq0HwRXLl1+xI4H101BH+CD+Pgw0Id4oVLe32UGZUG+ChrhIytsa1 REzn5IaT7XVbv+0gnolVJ8oyVSjQcUPtuD/44nKcuXChnIM7FzbvNY78CtQNCZSKM0kQ dNOTEExqPhErRbnyTvMW1nKAs/Ko7eTMGFUd3IDUh/WsJh/fkrjtUU2JwaPbTbBJghm/ KNRTnHCebfzSG/pJABIx4456XTp4vOEUAmJ8MYeOVgIMxaoGHYvwqYVx4EWnxVcE9VR8 bQZZiOi44hws9MCCQFSDlEvLmDkijOw1zBIXq1FS4dZP0QOsgK3qyOSYPzEaeBtOFHar hWuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=uBLMtqU1I2I9rkxUa69471hS5Ldazz+RxRgueZoMIz4=; b=lN1+ceYwEY+F/VrrDLl3AuoXAtljyXnSNNcLu5GiImVeyYZLEN70kmtqUd62n/bWH7 iU2vJzATW1KQc59J+yn5frXKeln8QoObght+/JLin9037GNvq5NRbrmb2fZqfmfDZYfF ew4sSyhAsttzmD3EcP3SFObNOuk77e1do8yO0nUtTh4cFweiTvYNSWBidslTQrrQFFI6 NqnwKYyVzooS65itaWVG1cyMKqA0NPgbGz2b+AK6uatUQhKKErBkVUtGI5JUw7Xh+tbO i08I3wlmDiS/CRkaO+YdHf0ujLHa885t5V4NUafSd363uaY3fUPqlAGGFNJfwuMc4kBd 3HJw== X-Gm-Message-State: AN3rC/4egq3jR5RQyPURIA6tjsW1tUqsm5+DfP5JKvs1xvzSEpSbkTQH z/Epv4YXhp6crQqsVGQOtR/ti69YoMx+ X-Received: by 10.223.154.40 with SMTP id z37mr17065390wrb.136.1493638385736; Mon, 01 May 2017 04:33:05 -0700 (PDT) In-Reply-To: <83a878r2d0.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214477 Archived-At: --f403045f572e67a3b7054e74c976 Content-Type: text/plain; charset=UTF-8 Eli Zaretskii schrieb am Sa., 22. Apr. 2017 um 15:35 Uhr: > > From: Philipp Stephani > > Date: Sat, 22 Apr 2017 11:57:11 +0000 > > > > > (Tangentially, is there any reason not to define Lisp_Object as struct > > > unconditionally, to avoid such coding errors?) > > > > Yes, it produces slower code. > > > > Are you sure that's still the case? I've just diffed the assembly output > for editfns.c with and without > > --enable-check-lisp-object-type, they seem identical (apart from minor > diffs due to different register allocation > > and instruction ordering). Replacing a primitive value with a struct > containing such a value should never > > degrade performance; that would be a compiler bug. > > On what OS/architecture, and with what compiler options? > On macOS, with configure called e.g. as ./configure '--without-xml2' '--with-modules' '--without-pop' '--with-mailutils' --enable-check-lisp-object-type 'CFLAGS=-O2 -save-temps' 'MAKEINFO=/usr/local/opt/texinfo/bin/makeinfo' > > in any case, if you want to raise this issue, please post to > emacs-devel, not here. > Moved to emacs-devel. --f403045f572e67a3b7054e74c976 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Eli Za= retskii <eliz@gnu.org> schrieb am= Sa., 22. Apr. 2017 um 15:35=C2=A0Uhr:
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Sat, 22 Apr 2017 11:57:11 +0000
>
>=C2=A0 > (Tangentially, is there any reason not to define Lisp_Objec= t as struct
>=C2=A0 > unconditionally, to avoid such coding errors?)
>
>=C2=A0 Yes, it produces slower code.
>
> Are you sure that's still the case? I've just diffed the assem= bly output for editfns.c with and without
> --enable-check-lisp-object-type, they seem identical (apart from minor= diffs due to different register allocation
> and instruction ordering). Replacing a primitive value with a struct c= ontaining such a value should never
> degrade performance; that would be a compiler bug.

On what OS/architecture, and with what compiler options?

On macOS, with configure called e.g. as

./configure=C2=A0 '--without-x= ml2' '--with-modules' '--without-pop' '--with-mailu= tils' --enable-check-lisp-object-type 'CFLAGS=3D-O2 -save-temps'= ; 'MAKEINFO=3D/usr/local/opt/texinfo/bin/makeinfo'

=
=C2=A0

in any case, if you want to raise this issue, please post to
emacs-devel, not here.

Moved to emacs-d= evel.=C2=A0
--f403045f572e67a3b7054e74c976--