all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Philipp Stephani <p.stephani2@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Phil Sainty <psainty@orcon.net.nz>, 42931@debbugs.gnu.org
Subject: bug#42931: 27.1; json-pretty-print-buffer on ~2MB line causes core dump
Date: Thu, 20 Aug 2020 15:26:06 +0200	[thread overview]
Message-ID: <CAArVCkQtVJyJ+7VBW4te2fTSGq8GNPvz5dgnD34NCLZCUwcSFA@mail.gmail.com> (raw)
In-Reply-To: <87imddwiy0.fsf@gnus.org>

Am Do., 20. Aug. 2020 um 15:23 Uhr schrieb Lars Ingebrigtsen <larsi@gnus.org>:
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > looks like stack overflow?  I guess the recursive nature of compareseq
> > is got to cause this at some point?
>
> Yup.
>
> I'm not sure what to do about it, though.  One easy way to "fix this"
> would be to not use replace-region-contents in json-pretty-print if the
> region is very large...  but that's kinda just wallpapering over the
> problem.
>
> replace-region-contents itself could decide to not do all its fancy
> stuff if the region is very large, and just replace the contents in the
> normal way instead?


I guess the underlying function (compareseq) should protect against
unbounded recursion and fall back to a more coarse diff if necessary.





  reply	other threads:[~2020-08-20 13:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-19 13:50 bug#42931: 27.1; json-pretty-print-buffer on ~2MB line causes core dump Phil Sainty
2020-08-19 14:15 ` Lars Ingebrigtsen
2020-08-19 15:18   ` Eli Zaretskii
2020-08-20 13:22     ` Lars Ingebrigtsen
2020-08-20 13:26       ` Philipp Stephani [this message]
2020-08-20 13:39       ` Eli Zaretskii
2020-08-24 23:46 ` Paul Eggert
2020-08-25  6:12   ` Eli Zaretskii
2020-08-25 18:19     ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAArVCkQtVJyJ+7VBW4te2fTSGq8GNPvz5dgnD34NCLZCUwcSFA@mail.gmail.com \
    --to=p.stephani2@gmail.com \
    --cc=42931@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=psainty@orcon.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.