From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#24998: Commit 'b5b997b95...' (Checkdoc: Don't require a space before an arg list) breaks defvar Date: Sat, 31 Dec 2016 16:35:44 +0000 Message-ID: References: <20161229042806.GG1039@smoon.vl-lomov.ru> <20161231004358.GK1039@smoon.vl-lomov.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7b86cf3e9997990544f6e9a2 X-Trace: blaine.gmane.org 1483202244 27634 195.159.176.226 (31 Dec 2016 16:37:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 31 Dec 2016 16:37:24 +0000 (UTC) To: Vladimir Lomov , 24998@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 31 17:37:20 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cNMeh-0005dL-Bq for geb-bug-gnu-emacs@m.gmane.org; Sat, 31 Dec 2016 17:37:15 +0100 Original-Received: from localhost ([::1]:44714 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cNMeh-0004sj-Cw for geb-bug-gnu-emacs@m.gmane.org; Sat, 31 Dec 2016 11:37:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40291) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cNMeX-0004sR-Vx for bug-gnu-emacs@gnu.org; Sat, 31 Dec 2016 11:37:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cNMeU-0003B7-0E for bug-gnu-emacs@gnu.org; Sat, 31 Dec 2016 11:37:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46238) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cNMeT-0003B3-Rz for bug-gnu-emacs@gnu.org; Sat, 31 Dec 2016 11:37:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cNMeT-0007rM-Is for bug-gnu-emacs@gnu.org; Sat, 31 Dec 2016 11:37:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 Dec 2016 16:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24998 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24998-submit@debbugs.gnu.org id=B24998.148320216330141 (code B ref 24998); Sat, 31 Dec 2016 16:37:01 +0000 Original-Received: (at 24998) by debbugs.gnu.org; 31 Dec 2016 16:36:03 +0000 Original-Received: from localhost ([127.0.0.1]:33404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cNMdW-0007q5-Rw for submit@debbugs.gnu.org; Sat, 31 Dec 2016 11:36:03 -0500 Original-Received: from mail-wj0-f171.google.com ([209.85.210.171]:35338) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cNMdV-0007pb-4f for 24998@debbugs.gnu.org; Sat, 31 Dec 2016 11:36:01 -0500 Original-Received: by mail-wj0-f171.google.com with SMTP id v7so397803087wjy.2 for <24998@debbugs.gnu.org>; Sat, 31 Dec 2016 08:36:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=xTI6g3ThBOVBPeCqXxCb9MQRcVRfSEsI5feD0GD3Vzs=; b=jqWVrzDfnC33ymmrU+sYqoGEVlFCiQM4R45Qvd4MW2S4g1anNkZvf5SLUSTsflOqBa op6YYWq3GgJkJwKRghUyzPleqliIbjaKNlmmNrQeskbBCEfg8ZyM7kYoQS4nsEtl4I2f VqRwE5gFhZIox1xfjUbaaODsorZ4FIYsuPyg6svuGi1Uh3uM352jz8nSEO4hSTPNvfOG bBYDrOXQzmZx88AWR5onnbPNhNfRSQvnMoN5LrYqMHnc8vYKoIDjTawLQsLlgewpCGSG 6vdXVuY3+fA3u41nwLIdN7lV84844hVFVEPp0vS/kBG67PcLhFn9O7nJCDAbl6bQrKEQ XZXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=xTI6g3ThBOVBPeCqXxCb9MQRcVRfSEsI5feD0GD3Vzs=; b=EXHo6iWfl+NnhEFvTVUzvwyiCAMzMkzeG7Xbcd1q21Da8RSFzFN5sNXU3k3zm+1LHQ va4gC7Tys9OBVQtxzyz9Wq0IFSweWd9zEY08RQ3Ft2fp8ZcY+Rb8YtoL26+RE0+Rt1X2 4Py77+6WWQGrs5u1vTke/kQbVlT8epFJ/7ZjSqltrRguGB5eEoG1CcOj7gUbeLuQBsxV HcNnDAxo8oErCRI39yVVhyaNzlWfPNFjozz78gFaX3p2lMYl6ZrGxGIfEuwwFIrTBfat kJrzVwD1A2g9HYJ25lhM5jcOBiYMoTTuoQ4WV6I7f90a+t8UqOrZiyb6hSGG8mRgo8Lk 2N/Q== X-Gm-Message-State: AIkVDXJZk9R2gkvNBp1hev8Ji+qiIHnyQ6/7UdvUUCfjyt2P3+eTAweat6nRqmsZhQrs81XjbiNE1Y2UaqDrQQ== X-Received: by 10.194.58.7 with SMTP id m7mr32015682wjq.73.1483202155352; Sat, 31 Dec 2016 08:35:55 -0800 (PST) In-Reply-To: <20161231004358.GK1039@smoon.vl-lomov.ru> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127632 Archived-At: --047d7b86cf3e9997990544f6e9a2 Content-Type: text/plain; charset=UTF-8 Vladimir Lomov schrieb am Sa., 31. Dez. 2016 um 01:44 Uhr: > ** Philipp Stephani [2016-12-30 17:04:04 +0000]: > > > Vladimir Lomov schrieb am Do., 29. Dez. 2016 um > > 05:29 Uhr: > > > >> Hello, > >> > >> I found that the commit 'b5b997b95' breaks a valid defvar, see > >> attached example file 'b.el'. If I run 'M-x checkdoc' in Emacs after > >> that commit (I tried in Emacs compiled from commit 112460da70) it shows > >> me error message (copy-pasted from *Message* buffer): > >> > >> forward-sexp: Scan error: "Containing expression ends prematurely", > 60, > >> 61 > >> > >> while before that commit (I tested in Emacs compiled from commit > >> e5ef59b87d) it works like a charm. > >> > >> > > Thanks for reporting. I've attached a patch that replaces the regex > > completely. > > Thank you, your patch works fine on my example and other real el file. > > Thanks, pushed as 4bbd5424a2290ab4bd88c0af602b7aa7d53a407e. --047d7b86cf3e9997990544f6e9a2 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Vladim= ir Lomov <v.p.lomov@yandex.ru= > schrieb am Sa., 31. Dez. 2016 um 01:44=C2=A0Uhr:
** Philipp Stephani [2016-12-30 17:04:04 +0000]:

> Vladimir Lomov <lomov.vl@gmail.com> schrieb am Do., 29. Dez= . 2016 um
> 05:29 Uhr:
>
>> Hello,
>>
>> I found that the commit 'b5b997b95' breaks a valid defvar,= see
>> attached example file 'b.el'. If I run 'M-x checkdoc&#= 39; in Emacs after
>> that commit (I tried in Emacs compiled from commit 112460da70) it = shows
>> me error message (copy-pasted from *Message* buffer):
>>
>>=C2=A0 =C2=A0forward-sexp: Scan error: "Containing expression = ends prematurely", 60,
>> 61
>>
>> while before that commit (I tested in Emacs compiled from commit >> e5ef59b87d) it works like a charm.
>>
>>
> Thanks for reporting. I've attached a patch that replaces the rege= x
> completely.

Thank you, your patch works fine on my example and other real el file.


Thanks, pushed as = 4bbd5424a2290ab4bd88c0af602b7aa7d53a407e.=C2=A0
--047d7b86cf3e9997990544f6e9a2--