all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Philipp Stephani <p.stephani2@gmail.com>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: Paul Eggert <eggert@cs.ucla.edu>,
	Stefan Monnier <monnier@iro.umontreal.ca>,
	Andrea Corallo <andrea_corallo@yahoo.it>,
	42147@debbugs.gnu.org
Subject: bug#42147: 28.0.50; pure vs side-effect-free, missing optimizations?
Date: Wed, 29 Jul 2020 15:10:22 +0200	[thread overview]
Message-ID: <CAArVCkQpum4Vu0tcPhNb-p+xMYKU2Z5nHvfo17Ta0qqa9bybNw@mail.gmail.com> (raw)
In-Reply-To: <51FE77F3-CA05-459A-9601-9E1EEBC1E2FE@acm.org>

Am Sa., 25. Juli 2020 um 23:00 Uhr schrieb Mattias Engdegård <mattiase@acm.org>:
>
> 25 juli 2020 kl. 22.11 skrev Philipp Stephani <p.stephani2@gmail.com>:
>
> > The manual states that
> > "This function [concat] always constructs a new string that is not
> > ‘eq’ to any existing string" so I don't see how it could ever be pure.
>
> Actually that part of the manual was corrected fairly recently, as that statement hasn't been true for decades.
>
> More to the point, the current set of functions marked as 'pure' are really the superset 'pure-absent-mutation': functions that are pure when it can be assumed that the arguments are not modified. This assumption can be based on physical immutability (integers), by convention (string constants), or anything else the compiler can prove such as control flow.
>
> There is also the question of what equality to use and here the answer is probably 'equal' since we are only dealing with immutables. (The return values of these functions cannot be considered mutable for obvious reasons, so make-string is out.)
>
> If you want to rename the property accordingly then I won't object. In any case, it is certainly a good idea to be precise about what the various sets really mean.

It looks like these are really two separate concepts, which should be
documented separately and should get separate function properties:
- Fully-pure functions are guaranteed to either return results that
are "eql" or signal error data that is "equal-including-properties"
when given arguments that are pairwise "eql", for all possible
arguments, mutable or not.
- Pure-unless-mutable functions are a strict superset whose
restrictions to immutable arguments are guaranteed to either return
results or signal error data that are "equal-including-properties"
when given arguments that are immutable and pairwise
"equal-including-properties".
Both categories must be free of observable side effects as well.

>
> There are also some functions declared 'pure' that appear to have side effects: kbd, package-get-version
>

kbd can and should be made pure-unless-mutable at least.
package-get-version should be neither, but should be marked using a
third to-be-introduced property (e.g. "eval-when-compile") to state
the intention without resorting to hacks.





  parent reply	other threads:[~2020-07-29 13:10 UTC|newest]

Thread overview: 98+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1583748933.1069307.1593556032592.ref@mail.yahoo.com>
2020-06-30 22:27 ` bug#42147: 28.0.50; pure vs side-effect-free, missing optimizations? Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-06-30 23:14   ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-07-01 12:46     ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-07-01 12:44   ` Mattias Engdegård
2020-07-01 16:08     ` Mattias Engdegård
2020-07-01 21:31       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-07-02 10:26         ` Mattias Engdegård
2020-07-02 10:59           ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-07-02 12:46             ` Mattias Engdegård
2020-07-02 13:56               ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-07-02 14:51                 ` Mattias Engdegård
2020-07-02 15:32                   ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-07-02 15:49                   ` Stefan Monnier
2020-07-02 18:01                     ` Mattias Engdegård
2020-07-02 18:55                       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-07-02 19:38                       ` Stefan Monnier
2020-07-02 20:09                         ` Paul Eggert
2020-07-03  9:32                           ` Mattias Engdegård
2020-07-03 13:39                             ` bug#42147: Hash-consing bignums (was: bug#42147: 28.0.50; pure vs side-effect-free, missing optimizations?) Stefan Monnier
2020-07-02 20:31                       ` bug#42147: 28.0.50; pure vs side-effect-free, missing optimizations? Paul Eggert
2020-07-02 21:41                       ` Stefan Monnier
2020-07-02 23:16                         ` Paul Eggert
2020-07-03  8:32                           ` Mattias Engdegård
2020-07-03 13:11                             ` Stefan Monnier
2020-07-03 18:35                               ` Mattias Engdegård
2020-07-03 18:43                                 ` Mattias Engdegård
2020-07-03 19:05                                 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-07-04 14:58                                   ` Mattias Engdegård
2020-07-04 15:06                                 ` Stefan Monnier
2020-07-04 16:13                                   ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-07-05 13:00                                     ` Mattias Engdegård
2020-07-05 13:16                                       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-07-06 17:20                                         ` Mattias Engdegård
2020-07-06 21:23                                           ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-07-07 15:54                                             ` Mattias Engdegård
2020-07-07 16:24                                               ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-07-07 16:55                                                 ` Mattias Engdegård
2020-07-07 17:42                                                   ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-07-08 19:14                                                   ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-07-08 21:25                                                     ` Mattias Engdegård
2020-07-08 22:19                                                       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-07-09 10:20                                                         ` Mattias Engdegård
2020-07-09 12:47                                                           ` Stefan Monnier
2020-07-09 12:57                                                             ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-07-09 14:35                                                               ` Stefan Monnier
2020-07-09 15:19                                                                 ` Paul Eggert
2020-07-09 15:37                                                                 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-07-05 15:26                                   ` Mattias Engdegård
2020-07-03 18:31                             ` Paul Eggert
2020-07-03 18:47                               ` Mattias Engdegård
2020-07-04 15:57                                 ` Paul Eggert
2020-07-04 16:15                                   ` Eli Zaretskii
2020-07-04 16:27                                     ` Paul Eggert
2020-07-04 16:33                                       ` Stefan Monnier
2020-07-04 16:44                                         ` Mattias Engdegård
2020-07-04 17:00                                         ` Paul Eggert
2020-07-04 18:37                                           ` Pip Cet
2020-07-04 21:05                                             ` Stefan Monnier
2020-07-04 22:25                                               ` Pip Cet
2020-07-05  2:38                                                 ` Eli Zaretskii
2020-07-05  8:28                                                   ` Paul Eggert
2020-07-05  8:39                                                     ` Andreas Schwab
2020-07-05 14:47                                                     ` Eli Zaretskii
2020-07-05 15:30                                                       ` Stefan Monnier
2020-07-06  0:14                                                         ` Paul Eggert
2020-07-05 15:11                                                     ` Stefan Monnier
2020-07-06  0:10                                                       ` Paul Eggert
2020-07-05  9:56                                             ` Paul Eggert
2020-07-05 10:03                                               ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-07-05 23:57                                                 ` Paul Eggert
2020-07-04 19:01                                           ` Mattias Engdegård
2020-07-04 17:10                                       ` Eli Zaretskii
2020-07-04 19:26                                         ` Paul Eggert
2020-07-02 19:09           ` Philipp Stephani
2020-07-03  9:25             ` Mattias Engdegård
2020-07-25 17:09               ` Philipp Stephani
2020-07-25 18:10                 ` Stefan Monnier
2020-07-25 20:03                   ` Philipp Stephani
2020-07-25 20:07                     ` Stefan Monnier
2020-07-25 20:11                       ` Philipp Stephani
2020-07-25 21:00                         ` Mattias Engdegård
2020-07-25 21:29                           ` Stefan Monnier
2020-07-25 21:39                             ` Philipp Stephani
2020-07-25 22:27                               ` Stefan Monnier
2020-07-29 12:53                                 ` Philipp Stephani
2020-07-29 14:28                                   ` Stefan Monnier
2020-07-25 21:54                             ` Mattias Engdegård
2020-07-25 22:30                               ` Stefan Monnier
2020-07-26  9:05                                 ` Mattias Engdegård
2020-07-29 16:03                                   ` Mattias Engdegård
2020-07-29 20:39                                     ` Stefan Monnier
2020-08-03 15:07                                       ` Mattias Engdegård
2020-08-10 13:39                                         ` Philipp Stephani
2020-08-10 22:07                                           ` Stefan Monnier
2020-08-10 13:42                                       ` Philipp Stephani
2020-08-10 22:10                                         ` Stefan Monnier
2020-07-29 13:10                           ` Philipp Stephani [this message]
2020-07-25 21:09                         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAArVCkQpum4Vu0tcPhNb-p+xMYKU2Z5nHvfo17Ta0qqa9bybNw@mail.gmail.com \
    --to=p.stephani2@gmail.com \
    --cc=42147@debbugs.gnu.org \
    --cc=andrea_corallo@yahoo.it \
    --cc=eggert@cs.ucla.edu \
    --cc=mattiase@acm.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.