From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete Date: Sun, 5 Apr 2020 11:47:10 +0200 Message-ID: References: <87a751uonw.fsf@mail.linkov.net> <9bab3a53-ec31-3300-132f-dc1e17ee0c53@yandex.ru> <875zfd9lzm.fsf@mail.linkov.net> <87mu8mieve.fsf@mail.linkov.net> <87k13pkxdl.fsf@mail.linkov.net> <207d4e30-aa59-b8eb-c39a-0957757f39eb@yandex.ru> <875zf6cy3w.fsf@mail.linkov.net> <9c39f788-29f1-5a68-c8f3-a4b08ae9ea3b@yandex.ru> <87lfo1dvcf.fsf@mail.linkov.net> <44cda45a-db93-f2c1-626d-9ace68cd6fd1@yandex.ru> <87y2rpqt28.fsf@mail.linkov.net> <874kuci4tx.fsf@mail.linkov.net> <786821a9-ceab-bbe8-b02a-69e77ddde426@yandex.ru> <878sjkjb8p.fsf@mail.linkov.net> <7d73cdd2-6af1-270c-1929-1bf618c304db@yandex.ru> <87tv26pzji.fsf@mail.linkov.net> <979c0191-48ce-f13f-361e-a03b3ff393a6@yandex.ru> <87a73t8rrl.fsf@mail.linkov.net> <87v9me960f.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="122575"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , 34949@debbugs.gnu.org, Dmitry Gutov To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 05 11:48:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jL1sx-000VlM-PX for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Apr 2020 11:48:11 +0200 Original-Received: from localhost ([::1]:46366 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jL1sw-00061I-G8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Apr 2020 05:48:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35688) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jL1sp-000617-1R for bug-gnu-emacs@gnu.org; Sun, 05 Apr 2020 05:48:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jL1so-0001dX-0b for bug-gnu-emacs@gnu.org; Sun, 05 Apr 2020 05:48:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33663) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jL1sn-0001dN-Rm for bug-gnu-emacs@gnu.org; Sun, 05 Apr 2020 05:48:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jL1sn-0006qT-QT for bug-gnu-emacs@gnu.org; Sun, 05 Apr 2020 05:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Apr 2020 09:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34949 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed fixed Original-Received: via spool by 34949-submit@debbugs.gnu.org id=B34949.158608004926199 (code B ref 34949); Sun, 05 Apr 2020 09:48:01 +0000 Original-Received: (at 34949) by debbugs.gnu.org; 5 Apr 2020 09:47:29 +0000 Original-Received: from localhost ([127.0.0.1]:45209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jL1sH-0006oV-K9 for submit@debbugs.gnu.org; Sun, 05 Apr 2020 05:47:29 -0400 Original-Received: from mail-oi1-f169.google.com ([209.85.167.169]:33130) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jL1sF-0006o2-Pj for 34949@debbugs.gnu.org; Sun, 05 Apr 2020 05:47:28 -0400 Original-Received: by mail-oi1-f169.google.com with SMTP id m14so10457139oic.0 for <34949@debbugs.gnu.org>; Sun, 05 Apr 2020 02:47:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZCX2afRWXt5LqIAv3mQch91sF2dcrqzzuO4wBHdQyxQ=; b=e6Y8VuWlptTmTcBF/fgUbkpXyA0+/1oLTLNLfy7/i+i+cWnrMEdOJI1TcGHstjVgc8 xSc1+EOpbU+UoyDFbJbYyuLQVJGhsvHiRx5nMo4dB7maWvSmR943wayOn2Dt4Z9nu6/t dlGdPGvBjsyYT6jOyTxxt/xy9E3Pyg6bAQe4xBCSANo0PeM+5UZS3yYnEOvaezwMhcGu ih88i9oeEMAgl0DKLrmG5v1lRRDPZEC8GmyNiII1aI/QtL9i+oyddKngECfJegaiqqN7 NWE4JUMeQVt/4tehe55tzc78SaW6xZmFLwspNPg+eLVl98X8nwT7U9C6mKIA92HPXr+S IYpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZCX2afRWXt5LqIAv3mQch91sF2dcrqzzuO4wBHdQyxQ=; b=mcaTcB9bDoN/rFj2omJWCO9ER63Ka2io49sPFNe1DrcTIvsyBNQfnpPkDeu4IWn/jD ywkrOKMpmJKsk6LvcuYM64Aj0u+mjl01yxhiVOCgGBujFnYpjdJiUDI3hA6J69cVi5uJ +w2KFb0rgTbGnOqSU/gz+i3l++9C8u/Q1Cw5NGwGlm38JwN8hGxSgh6Kd0EpyhBEOwtz cqYv3FYT5XfOD+5Qd70n9I2DAr7fR4UA7Qw4PrtiTJRZ1gLTGsGfkM3DhE0HRmj828Q+ zE2k+6O2gH2Ncwk5aGK5V9UpzBmW06jmTKUc0G/vzvJLM4GMqcDEkuG+dOKySuBHsPH2 rcFA== X-Gm-Message-State: AGi0PubKd0swi7NsN1Ct6mgRFc5cOxCv5wsHI9twqWyQS3lbenlO5vQt co2iUgJaosLc46v3yJiKnZjQ34zBRY3f64+XNdw= X-Google-Smtp-Source: APiQypJfXM240TMyJlpMlceQ/MpA+oR8cTEm7X/ml4OVO66Kb0ssbnDjeAVxI3/TMTCTglez23vupLd5HpVp+RbXYLI= X-Received: by 2002:aca:b245:: with SMTP id b66mr9178327oif.170.1586080041953; Sun, 05 Apr 2020 02:47:21 -0700 (PDT) In-Reply-To: <87v9me960f.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:178050 Archived-At: Am So., 5. Apr. 2020 um 01:58 Uhr schrieb Juri Linkov : > > >> Many things were implemented under this request > >> and more could be done on another round of improvements, > >> but it would be too much for the same request, > >> so I'm closing it now. > > > > I haven't followed this bug that closely, but it seems the initial > > issue about the undocumented arguments and return values of > > vc-deduced-fileset isn't addressed yet. At least on both master and > > emacs-27 these topics are still not documented. > > Thanks for the report, I checked your initial request to see what > remains to do: > > > The docstring of `vc-deduce-fileset' doesn't describe the OBSERVER parameter. > > OBSERVER was renamed to NOT-STATE-CHANGING a week ago in master and > described in the docstring of `vc-deduce-fileset'. Thanks! > > > It also doesn't explain the meaning of the return values > > FILESET-ONLY-FILES, STATE, and CHECKOUT-MODEL. > > This is hard to explain because this is internal data, I even don't know > where to begin. For example, here is some code from vc-next-action > that uses data returned from vc-deduce-fileset: > > (not (eq model 'implicit)) (eq state 'up-to-date) > > Do you know what 'implicit' model means here and where to find all other > possible model values? Also please help to find all possible states like > 'up-to-date' here. I see more states used in vc-deduce-fileset like > 'missing', 'ignored', 'needs-update', but where is a complete list? Would it make sense to document these values as internal for now, similar to what we do with the 11th return value of parse-partial-sexp?