From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: make pred customable in auto-save-visited-mode Date: Sun, 01 Apr 2018 19:51:51 +0000 Message-ID: References: <83a7uo8wk5.fsf@gnu.org> <83605c8qwr.fsf@gnu.org> <83d0zi7ruh.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000009488e50568cece4c" X-Trace: blaine.gmane.org 1522612211 3468 195.159.176.226 (1 Apr 2018 19:50:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 1 Apr 2018 19:50:11 +0000 (UTC) Cc: jixiuf@qq.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 01 21:50:06 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f2izO-0000np-Dd for ged-emacs-devel@m.gmane.org; Sun, 01 Apr 2018 21:50:06 +0200 Original-Received: from localhost ([::1]:58892 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f2j1R-0000Zh-Vk for ged-emacs-devel@m.gmane.org; Sun, 01 Apr 2018 15:52:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60987) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f2j1K-0000Z0-IF for emacs-devel@gnu.org; Sun, 01 Apr 2018 15:52:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f2j1J-0000Ku-Kv for emacs-devel@gnu.org; Sun, 01 Apr 2018 15:52:06 -0400 Original-Received: from mail-lf0-x229.google.com ([2a00:1450:4010:c07::229]:40875) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f2j1H-0000IJ-Ij; Sun, 01 Apr 2018 15:52:03 -0400 Original-Received: by mail-lf0-x229.google.com with SMTP id e5-v6so18209610lfb.7; Sun, 01 Apr 2018 12:52:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fIsR38Mylq+Zf1pvtVFCWrD467I2NthSh2PG4phZa9I=; b=NSGPAGkRxAz7iPogfT4cNlgcFjq1STxyTy3PwwTdbXjYOvUB9z87tDawbpIRYrS2zb KnF+9QxgZufUC6FJu7pEYH8ZP80uznSnbSnQTKdP/k2BNi/LlNJtsj8uktBrUUdHP/qO nNWpDSQ/k32tBoLh5gp2F4NPhFB0oJ5ZvmTJKZe35i5PO/EaacqlyQujiiSZtxZl9mRi C9THlglUd/tQ3Qw9jKk8qHzTtPMBqDFQeIVgGLelF1mo0M53vPHrkOz2YV+lN9NKgaX9 AZkJ2oAM8jS5mTKR74923cnITKErAwfsk8h2LA99egpl7fge1yMtlwr2j9l8FBMat384 RMDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fIsR38Mylq+Zf1pvtVFCWrD467I2NthSh2PG4phZa9I=; b=k1UBrBt3eyeiwtHg//P0yGav4kXQciamvorZU23f2E4k7ZexeEns/c4UKn+fFGtnpo 13+Grxwc52lLIoq0iPOHM34E23vG7pKAE//2Q0BioWTehoMH2B+47EjlMqXwraN2nt+h P3AHcaJVJ9/HgWduW67/DO36+hf2gUFaLl85JqipFNOrDQWg+egNJmGmeiA9jy/TqzFV AiakW/HrQMhALa9CQVrMhuUQ8r+5+CT8EjOdXR0pIDxWz/3ypgrdYUKEIaaMwiDgKof6 rkgZpmCyUZWP1acEECrzmpqr72x9lNZjbbPe91G5NI1Lptl/o7JZ+xe7EWpypP/ztX+Z MdVw== X-Gm-Message-State: ALQs6tDsLbYSZgkZ9BivH1xAsZnQ3Hxth6pRmDqrr9WhOComEV06ukhL 6xFucvF/dy/YN3Mfhn6V6rh/cGGBqQkkKVz75I4GPA== X-Google-Smtp-Source: AIpwx4+YT3Z2i0ZNa3Dq2EDvmGsFVpi0xhQpmA+naa7nFBePEQRAoQW9z9MC6irDyr541zuziqnKyH39YEiMMl4F2d4= X-Received: by 2002:a19:136a:: with SMTP id j103-v6mr3961871lfi.19.1522612321944; Sun, 01 Apr 2018 12:52:01 -0700 (PDT) In-Reply-To: <83d0zi7ruh.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:224227 Archived-At: --0000000000009488e50568cece4c Content-Type: text/plain; charset="UTF-8" Eli Zaretskii schrieb am So., 1. Apr. 2018 um 19:35 Uhr: > > From: Philipp Stephani > > Date: Sun, 01 Apr 2018 17:19:38 +0000 > > Cc: jixiuf@qq.com, emacs-devel@gnu.org > > > > > Probably the second option is better because the first option would > prevent PRED from running for > > > non-file-visiting buffers. Patch attached. > > > > AFAIU, this will unconditionally disable auto-saving in *ediff-merge* > > and all the similar buffers, when auto-save-visited-mode is turned > > on. Is that what we want? And if that's going to be the default, how > > are users supposed to override it if they want? > > > > I think not prompting is the right approach. It's not very user-friendly > to interrupt the user every couple of > > seconds, and no other application I know that has autosave prompts the > user for filenames. I think we should > > change the behavior by applying the patch; if some users do want to be > interrupted, we can still add a > > customization option later. > > AFAIU, you are not disabling the prompt, you are disabling the > auto-saving itself for such buffers. I'm asking if that is what we > want -- disable auto-saving for buffers like *ediff-merge* when > auto-save-visited-mode is turned on. > I think that's the right thing to do, yes. --0000000000009488e50568cece4c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Eli Za= retskii <eliz@gnu.org> schrieb am= So., 1. Apr. 2018 um 19:35=C2=A0Uhr:
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Sun, 01 Apr 2018 17:19:38 +0000
> Cc: jixiuf@qq.com, emacs-devel@gn= u.org
>
>=C2=A0 > Probably the second option is better because the first opti= on would prevent PRED from running for
>=C2=A0 > non-file-visiting buffers. Patch attached.
>
>=C2=A0 AFAIU, this will unconditionally disable auto-saving in *ediff-m= erge*
>=C2=A0 and all the similar buffers, when auto-save-visited-mode is turn= ed
>=C2=A0 on.=C2=A0 Is that what we want?=C2=A0 And if that's going to= be the default, how
>=C2=A0 are users supposed to override it if they want?
>
> I think not prompting is the right approach. It's not very user-fr= iendly to interrupt the user every couple of
> seconds, and no other application I know that has autosave prompts the= user for filenames. I think we should
> change the behavior by applying the patch; if some users do want to be= interrupted, we can still add a
> customization option later.

AFAIU, you are not disabling the prompt, you are disabling the
auto-saving itself for such buffers.=C2=A0 I'm asking if that is what w= e
want -- disable auto-saving for buffers like *ediff-merge* when
auto-save-visited-mode is turned on.

I = think that's the right thing to do, yes.=C2=A0
--0000000000009488e50568cece4c--