From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#28759: 26.0.60; Bovine apparently generates Elisp code with oldstyle backquotes Date: Sun, 29 Oct 2017 19:38:35 +0000 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="001a11470422a495c3055cb4abd9" X-Trace: blaine.gmane.org 1509305957 9500 195.159.176.226 (29 Oct 2017 19:39:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 29 Oct 2017 19:39:17 +0000 (UTC) To: 28759@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 29 20:39:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8tQI-0001Jz-CZ for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Oct 2017 20:39:06 +0100 Original-Received: from localhost ([::1]:37472 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e8tQP-0003ly-M4 for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Oct 2017 15:39:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47026) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e8tQJ-0003l2-4U for bug-gnu-emacs@gnu.org; Sun, 29 Oct 2017 15:39:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e8tQE-0006WN-JQ for bug-gnu-emacs@gnu.org; Sun, 29 Oct 2017 15:39:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60472) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e8tQE-0006W8-DC for bug-gnu-emacs@gnu.org; Sun, 29 Oct 2017 15:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e8tQE-0004Zw-5W for bug-gnu-emacs@gnu.org; Sun, 29 Oct 2017 15:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Oct 2017 19:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28759 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28759-submit@debbugs.gnu.org id=B28759.150930593717590 (code B ref 28759); Sun, 29 Oct 2017 19:39:02 +0000 Original-Received: (at 28759) by debbugs.gnu.org; 29 Oct 2017 19:38:57 +0000 Original-Received: from localhost ([127.0.0.1]:40920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8tQ8-0004Zd-Mk for submit@debbugs.gnu.org; Sun, 29 Oct 2017 15:38:57 -0400 Original-Received: from mail-qk0-f175.google.com ([209.85.220.175]:44554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8tQ4-0004ZL-TM for 28759@debbugs.gnu.org; Sun, 29 Oct 2017 15:38:55 -0400 Original-Received: by mail-qk0-f175.google.com with SMTP id r64so13820791qkc.1 for <28759@debbugs.gnu.org>; Sun, 29 Oct 2017 12:38:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=TcCwndQmhGp14/IkX2kVe2YVVFYl559ImSHYXI1qq1c=; b=MMyUNJDVY2Qz0PvytyQSeIllbFSRgO3gTNulqrw22QA7wKJna1kYOfBaxCC0CVgkig GRgulb3qHLDIUc8bccuXGov1P/fSyLNX2SSPFQV9FoSFhRXxN1XTePaH50IJ1QaXsT87 s+h3bjEGUx/sVNG4iNzBcn6XiS9wzMH1vSCd6qQ96tkTYIEjgoRDWCPK4eppjtSwietJ Ph4qilz/Z8RaJsjSPR2a2hdjjdReCzskjzJGvOBpkfxWyNlE/ERkZab8Jx9eCj7ClS4c NSpW4q1GHkG3RbuvpUTwDAdax0G+FLMqOWe+a4DbvTq6XevTpQzV/yS1mGcMyXONPYuO e81g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=TcCwndQmhGp14/IkX2kVe2YVVFYl559ImSHYXI1qq1c=; b=H4eOv+J0HqCAyp5bD2VHwnmJr6NtsXePxLJG90waZG1yY+7L1zJ35rRydl659WbQcw U8vcWOLxEm/7sFQDJ6InKKW8ABpENSxtyMxpS/q4GDCSXPhBAoDlYvJBj5znM+cqTl9N q6lnoHjYBAcq0Oy149FjIXCkib+OptUEpPszt3NvNxgreuCogzBvTvwUCm1ACz11I3by 2vQsppo2EJF+jF02FUU15oiUrhFeq8m3tQ1/XkselA71sZOuv3LRuOBfjdOzjJVWCddS BVf1B3HyjNOco3e0qKDBrj1ClbEAsHTfE0mfG2zba2V9ZwNILWcafm+q0LU2uYithta5 Y3lQ== X-Gm-Message-State: AMCzsaXC9W8PM4NNwaQL9PAmUPsDsCts/dCLc2EocXyZ6nEkFkYqFye5 Il0gvArEwKYPsl3ZCVdvlzvW8aIh5KZohcwSxyk91A== X-Google-Smtp-Source: ABhQp+RGVbLe+3cv/sXbMIJMy8Ts/L+Q5nQXm+ABbpRr5ZA0+UQUzjVUB8hZ1eUzP2XFM+ymI9/1sTuD4HdkjBOIERI= X-Received: by 10.55.48.70 with SMTP id w67mr9630426qkw.52.1509305927103; Sun, 29 Oct 2017 12:38:47 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139167 Archived-At: --001a11470422a495c3055cb4abd9 Content-Type: multipart/alternative; boundary="001a11470422a495bf055cb4abd7" --001a11470422a495bf055cb4abd7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Philipp Stephani schrieb am So., 15. Okt. 2017 um 21:41 Uhr: > Philipp schrieb am Mo., 9. Okt. 2017 um 16:20 Uhr= : > >> >> See https://lists.gnu.org/archive/html/emacs-devel/2017-10/msg00313.html >> >> The backtrace I got was >> >> $ (cd admin/grammars && EMACSLOADPATH=3D "../../src/emacs" -batch >> --no-site-file --no-site-lisp -eval '(setq debug-on-error t)' -l >> semantic/bovine/grammar -f bovine-batch-make-parser -o >> "../../lisp/cedet/semantic/bovine/make-by.el" make.by) >> ../../lisp/emacs-lisp/eieio.el: =E2=80=98eieio-object-name-string=E2=80= =99 is an obsolete >> generic function (as of 25.1); use =E2=80=98eieio-named=E2=80=99 instead= . >> ../../lisp/emacs-lisp/eieio.el: =E2=80=98object-print=E2=80=99 is an obs= olete generic >> function (as of 26.1); use =E2=80=98cl-print-object=E2=80=99 instead. >> ../../lisp/emacs-lisp/eieio-base.el: =E2=80=98eieio-object-name-string= =E2=80=99 is an >> obsolete generic function (as of 25.1); use =E2=80=98eieio-named=E2=80= =99 instead. >> Debugger entered--Lisp error: (error "Loading =E2=80=98nil=E2=80=99: old= -style backquotes >> detected!") >> read("( ,@$2 )") >> > > I looked a bit around, and found that these strings are copied verbatim > from the *.by files. > Looking at the comments of lread.c, this seems to be a limitation of the > reader: "Because it's more difficult to peek 2 chars ahead, a new-style ,= @ > can still not be used outside of a `, unless it's in the middle of a list= ." > Not sure what to do with this, though. Changing the reader would introduc= e > a breaking change for no good reason, since we're trying to get rid of > old-style backquotes. So I think this should rather be fixed in Bovine, > either by escaping the offending commas, or by removing the space between= ( > and ,. > Here is a minimal patch. --001a11470422a495bf055cb4abd7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Philip= p Stephani <p.stephani2@gmail.c= om> schrieb am So., 15. Okt. 2017 um 21:41=C2=A0Uhr:
Philipp <p.stephani2@gmail.com> schrieb am Mo., 9. Okt. 2017 um 16:20= =C2=A0Uhr:

See https://lists.gnu.org/archiv= e/html/emacs-devel/2017-10/msg00313.html

The backtrace I got was

$ (cd admin/grammars && EMACSLOADPATH=3D "../../src/emacs"= ; -batch --no-site-file --no-site-lisp -eval '(setq debug-on-error t)&#= 39; -l semantic/bovine/grammar=C2=A0 -f bovine-batch-make-parser -o ".= ./../lisp/cedet/semantic/bovine/make-by.el" make.by)
../../lisp/emacs-lisp/eieio.el: =E2=80=98eieio-object-name-string=E2=80=99 = is an obsolete generic function (as of 25.1); use =E2=80=98eieio-named=E2= =80=99 instead.
../../lisp/emacs-lisp/eieio.el: =E2=80=98object-print=E2=80=99 is an obsole= te generic function (as of 26.1); use =E2=80=98cl-print-object=E2=80=99 ins= tead.
../../lisp/emacs-lisp/eieio-base.el: =E2=80=98eieio-object-name-string=E2= =80=99 is an obsolete generic function (as of 25.1); use =E2=80=98eieio-nam= ed=E2=80=99 instead.
Debugger entered--Lisp error: (error "Loading =E2=80=98nil=E2=80=99: o= ld-style backquotes detected!")
=C2=A0 read("( ,@$2 )")

I looked a bit around, and found that these strings are copie= d verbatim from the *.by files.
Looking at the comments of lread.= c, this seems to be a limitation of the reader: "Because it's more= difficult to peek 2 chars ahead, a new-style=C2=A0,@ can still not be used= outside of a `, unless it's in the middle=C2=A0of a list."
<= div>Not sure what to do with this, though. Changing the reader would introd= uce a breaking change for no good reason, since we're trying to get rid= of old-style backquotes. So I think this should rather be fixed in Bovine,= either by escaping the offending commas, or by removing the space between = ( and ,.

Here is a minima= l patch.=C2=A0
--001a11470422a495bf055cb4abd7-- --001a11470422a495c3055cb4abd9 Content-Type: text/plain; charset="US-ASCII"; name="0001-Work-around-reader-limitations-for-old-style-backquote.txt" Content-Disposition: attachment; filename="0001-Work-around-reader-limitations-for-old-style-backquote.txt" Content-Transfer-Encoding: base64 Content-ID: <15f69a47cc620d786a31> X-Attachment-Id: 15f69a47cc620d786a31 RnJvbSAwYWMwMzBkMTUyNmVlN2Q3YzNiZjQ5YTIyY2RhZjRiMTc3YTk4MjEwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwIFN0ZXBoYW5pIDxwaHN0QGdvb2dsZS5jb20+CkRh dGU6IFN1biwgMTUgT2N0IDIwMTcgMjE6MzI6MTcgKzAyMDAKU3ViamVjdDogW1BBVENIXSBXb3Jr IGFyb3VuZCByZWFkZXIgbGltaXRhdGlvbnMgZm9yIG9sZC1zdHlsZSBiYWNrcXVvdGVzLgoKU2Vl IEJ1ZyMyODc1OS4KCiogYWRtaW4vZ3JhbW1hcnMvbWFrZS5ieTogRXNjYXBlICxAIHRvIGF2b2lk IG9sZC1zdHlsZSBiYWNrcXVvdGUKZGV0ZWN0aW9uCi0tLQogYWRtaW4vZ3JhbW1hcnMvbWFrZS5i eSB8IDE5ICsrKysrKysrKysrKy0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAxMiBpbnNlcnRpb25z KCspLCA3IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2FkbWluL2dyYW1tYXJzL21ha2UuYnkg Yi9hZG1pbi9ncmFtbWFycy9tYWtlLmJ5CmluZGV4IGQzYTAzZWFkNDcuLjRkMDI5MTg2ZDggMTAw NjQ0Ci0tLSBhL2FkbWluL2dyYW1tYXJzL21ha2UuYnkKKysrIGIvYWRtaW4vZ3JhbW1hcnMvbWFr ZS5ieQpAQCAtNTQsMTUgKzU0LDIwIEBACiAKICUlCiAKKzs7IEVzY2FwZSB0aGUgLEAgYmVsb3cg YmVjYXVzZSB0aGUgcmVhZGVyIGRvZXNuJ3QgY29ycmVjdGx5IGRldGVjdAorOzsgb2xkLXN0eWxl IGJhY2txdW90ZXMgZm9yIHRoaXMgY2FzZS4gIFRoZSBiYWNrc2xhc2hlcyBjYW4gYmUgcmVtb3Zl ZAorOzsgb25jZSBvbGQtc3R5bGUgYmFja3F1b3RlcyBhcmUgY29tcGxldGVseSBnb25lIChwcm9i YWJseSBpbgorOzsgRW1hY3MgMjgpLgorCiBNYWtlZmlsZSA6IGJvbCBuZXdsaW5lIChuaWwpCiAJ IHwgYm9sIHZhcmlhYmxlCi0JICAgKCAsQCQyICkKKwkgICAoIFwsQCQyICkKIAkgfCBib2wgcnVs ZQotCSAgICggLEAkMiApCisJICAgKCBcLEAkMiApCiAJIHwgYm9sIGNvbmRpdGlvbmFsCi0JICAg KCAsQCQyICkKKwkgICAoIFwsQCQyICkKIAkgfCBib2wgaW5jbHVkZQotCSAgICggLEAkMiApCisJ ICAgKCBcLEAkMiApCiAJIHwgd2hpdGVzcGFjZSAoIG5pbCApCiAJIHwgbmV3bGluZSAoIG5pbCAp CiAJIDsKQEAgLTEyNSwxMyArMTMwLDEzIEBAIGNvbG9uczogQ09MT04gQ09MT04gKCkKICAgICAg IDsKIAogZWxlbWVudC1saXN0OiBlbGVtZW50cyBuZXdsaW5lCi0JICAgICAgKCAsQCQxICkKKwkg ICAgICAoIFwsQCQxICkKIAkgICAgOwogCiBlbGVtZW50czogZWxlbWVudCBzb21lLXdoaXRlc3Bh Y2UgZWxlbWVudHMKLQkgICggLEAkMSAsQCQzICkKKwkgICggXCxAJDEgLEAkMyApCiAJfCBlbGVt ZW50Ci0JICAoICxAJDEgKQorCSAgKCBcLEAkMSApCiAJfCA7O0VNUFRZCiAJOwogCi0tIAoyLjE0 LjIKCg== --001a11470422a495c3055cb4abd9--